From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: Mike Turquette <mturquette@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Michael Welling <mwelling@ieee.org>,
Russell King <rmk+linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@free-electrons.com>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] clk: si5351: Some fixes
Date: Fri, 01 May 2015 11:30:18 +0200 [thread overview]
Message-ID: <554347AA.3070502@gmail.com> (raw)
In-Reply-To: <20150501111406.0aa23c7b@armhf>
On 01.05.2015 11:14, Jean-Francois Moine wrote:
> On Thu, 30 Apr 2015 19:45:50 +0200
> Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:
>> For Si5351 clock driver, Michael Welling and Jean-Francois Moine reported
>> issues with recent v4.x kernels due to broken/missing/wrong parent clock
>> claming. This patch set now deals with the issues reported.
>>
>> Patch 1 amends the binding documentation mention clock-names property
>> for the "xtal" and "clkin" parent clock inputs of Si5351 variants.
>>
>> Patch 2 adds the clock-names property for the SolidRun CuBox using Si5351
>> with a fixed oscillator connected to "xtal" input.
>>
>> Patch 3 reworks the way we claim parent clocks by using devm_clk_get()
>> for both DT and platform_data based registration. Also, properly check
>> for errors returned by devm_clk_get() and prepare/enable the parent clocks.
[...]
>
> I applied the patches 2 and 3, and the audio and video in the Cubox
> work fine again. Thanks.
Ok, good. You mentioned that on v3.19-rc1 it still "works" i.e. despite
the broken/missing clk_get/clk_prepare_enable?
Can you check the stable (v3.19, v4.0) versions and see how far we
should backport the fix?
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] clk: si5351: Some fixes
Date: Fri, 01 May 2015 11:30:18 +0200 [thread overview]
Message-ID: <554347AA.3070502@gmail.com> (raw)
In-Reply-To: <20150501111406.0aa23c7b@armhf>
On 01.05.2015 11:14, Jean-Francois Moine wrote:
> On Thu, 30 Apr 2015 19:45:50 +0200
> Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:
>> For Si5351 clock driver, Michael Welling and Jean-Francois Moine reported
>> issues with recent v4.x kernels due to broken/missing/wrong parent clock
>> claming. This patch set now deals with the issues reported.
>>
>> Patch 1 amends the binding documentation mention clock-names property
>> for the "xtal" and "clkin" parent clock inputs of Si5351 variants.
>>
>> Patch 2 adds the clock-names property for the SolidRun CuBox using Si5351
>> with a fixed oscillator connected to "xtal" input.
>>
>> Patch 3 reworks the way we claim parent clocks by using devm_clk_get()
>> for both DT and platform_data based registration. Also, properly check
>> for errors returned by devm_clk_get() and prepare/enable the parent clocks.
[...]
>
> I applied the patches 2 and 3, and the audio and video in the Cubox
> work fine again. Thanks.
Ok, good. You mentioned that on v3.19-rc1 it still "works" i.e. despite
the broken/missing clk_get/clk_prepare_enable?
Can you check the stable (v3.19, v4.0) versions and see how far we
should backport the fix?
Sebastian
next prev parent reply other threads:[~2015-05-01 9:30 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 17:45 [PATCH 0/4] clk: si5351: Some fixes Sebastian Hesselbarth
2015-04-30 17:45 ` Sebastian Hesselbarth
2015-04-30 17:45 ` Sebastian Hesselbarth
2015-04-30 17:45 ` [PATCH 1/4] clk: si5351: Mention clock-names in the binding documentation Sebastian Hesselbarth
2015-04-30 17:45 ` Sebastian Hesselbarth
2015-04-30 17:45 ` [PATCH 2/4] ARM: dove: Add clock-names to CuBox Si5351 clk generator Sebastian Hesselbarth
2015-04-30 17:45 ` Sebastian Hesselbarth
2015-04-30 17:45 ` [PATCH 3/4] clk: si5351: Do not pass struct clk in platform_data Sebastian Hesselbarth
2015-04-30 17:45 ` Sebastian Hesselbarth
2015-04-30 18:20 ` Fabio Estevam
2015-04-30 18:20 ` Fabio Estevam
2015-04-30 18:30 ` Michael Welling
2015-04-30 18:30 ` Michael Welling
2015-04-30 18:44 ` Sebastian Hesselbarth
2015-04-30 18:44 ` Sebastian Hesselbarth
2015-04-30 19:16 ` Fabio Estevam
2015-04-30 19:16 ` Fabio Estevam
2015-04-30 20:46 ` Sebastian Hesselbarth
2015-04-30 20:46 ` Sebastian Hesselbarth
2015-04-30 17:45 ` [PATCH 4/4] clk: si5351: Reset PLL after rate change Sebastian Hesselbarth
2015-04-30 17:45 ` Sebastian Hesselbarth
2015-04-30 18:49 ` Michael Welling
2015-04-30 18:49 ` Michael Welling
2015-04-30 18:58 ` Sebastian Hesselbarth
2015-04-30 18:58 ` Sebastian Hesselbarth
2015-04-30 18:47 ` [PATCH 0/4] clk: si5351: Some fixes Michael Welling
2015-04-30 18:47 ` Michael Welling
2015-04-30 19:33 ` Michael Welling
2015-04-30 19:33 ` Michael Welling
2015-04-30 19:33 ` Michael Welling
2015-04-30 20:44 ` Sebastian Hesselbarth
2015-04-30 20:44 ` Sebastian Hesselbarth
2015-04-30 20:44 ` Sebastian Hesselbarth
2015-04-30 21:20 ` Michael Welling
2015-04-30 21:20 ` Michael Welling
2015-04-30 21:20 ` Michael Welling
2015-04-30 22:21 ` Sebastian Hesselbarth
2015-04-30 22:21 ` Sebastian Hesselbarth
2015-04-30 22:21 ` Sebastian Hesselbarth
2015-04-30 22:36 ` Michael Welling
2015-04-30 22:36 ` Michael Welling
2015-04-30 22:36 ` Michael Welling
2015-05-01 8:17 ` Sebastian Hesselbarth
2015-05-01 8:17 ` Sebastian Hesselbarth
2015-05-01 8:17 ` Sebastian Hesselbarth
2015-05-08 0:52 ` Michael Welling
2015-05-08 0:52 ` Michael Welling
2015-05-01 9:14 ` Jean-Francois Moine
2015-05-01 9:14 ` Jean-Francois Moine
2015-05-01 9:14 ` Jean-Francois Moine
2015-05-01 9:14 ` Jean-Francois Moine
2015-05-01 9:30 ` Sebastian Hesselbarth [this message]
2015-05-01 9:30 ` Sebastian Hesselbarth
2015-05-02 8:53 ` Jean-Francois Moine
2015-05-02 8:55 ` Jean-Francois Moine
2015-05-02 8:55 ` Jean-Francois Moine
2015-05-02 8:55 ` Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554347AA.3070502@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=mturquette@linaro.org \
--cc=mwelling@ieee.org \
--cc=rmk+linux@arm.linux.org.uk \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.