All of lore.kernel.org
 help / color / mirror / Atom feed
From: Caesar Wang <sasukewxt-9Onoh4P/yGk@public.gmane.org>
To: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: Addy Ke <addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	Max Schwarz <max.schwarz-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>,
	Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	Dmitry Torokhov
	<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] i2c: rk3x: Increase wait timeout to 1 second
Date: Fri, 01 May 2015 11:40:37 +0800	[thread overview]
Message-ID: <5542F5B5.9000206@163.com> (raw)
In-Reply-To: <1430430247-9632-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>



在 2015年05月01日 05:44, Doug Anderson 写道:
> While it's not sensible for an i2c command to _actually_ need more
> than 200ms to complete, let's increase the timeout anyway.  Why?  It
> turns out that if you've got a large number of printks going out to a
> serial console, interrupts on a CPU can be disabled for hundreds of
> milliseconds. That's not a great situation to be in to start with
> (maybe we should put a cap in vprintk_emit()) but it's pretty annoying
> to start seeing unexplained i2c timeouts.
>
> A normal system shouldn't see i2c timeouts anyway, so increasing the
> timeout should help people debugging without hurting other people
> excessively.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
>   drivers/i2c/busses/i2c-rk3x.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index 019d542..72e97e30 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -72,7 +72,7 @@ enum {
>   #define REG_INT_ALL       0x7f
>   
>   /* Constants */
> -#define WAIT_TIMEOUT      200 /* ms */
> +#define WAIT_TIMEOUT      1000 /* ms */
Yeah, verified on veyron device.

Tested-by: Caesar Wang <wxt@rock-chips.com>



Thanks.

Caesar
>   #define DEFAULT_SCL_RATE  (100 * 1000) /* Hz */
>   
>   enum rk3x_i2c_state {



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: sasukewxt@163.com (Caesar Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: rk3x: Increase wait timeout to 1 second
Date: Fri, 01 May 2015 11:40:37 +0800	[thread overview]
Message-ID: <5542F5B5.9000206@163.com> (raw)
In-Reply-To: <1430430247-9632-1-git-send-email-dianders@chromium.org>



? 2015?05?01? 05:44, Doug Anderson ??:
> While it's not sensible for an i2c command to _actually_ need more
> than 200ms to complete, let's increase the timeout anyway.  Why?  It
> turns out that if you've got a large number of printks going out to a
> serial console, interrupts on a CPU can be disabled for hundreds of
> milliseconds. That's not a great situation to be in to start with
> (maybe we should put a cap in vprintk_emit()) but it's pretty annoying
> to start seeing unexplained i2c timeouts.
>
> A normal system shouldn't see i2c timeouts anyway, so increasing the
> timeout should help people debugging without hurting other people
> excessively.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
>   drivers/i2c/busses/i2c-rk3x.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index 019d542..72e97e30 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -72,7 +72,7 @@ enum {
>   #define REG_INT_ALL       0x7f
>   
>   /* Constants */
> -#define WAIT_TIMEOUT      200 /* ms */
> +#define WAIT_TIMEOUT      1000 /* ms */
Yeah, verified on veyron device.

Tested-by: Caesar Wang <wxt@rock-chips.com>



Thanks.

Caesar
>   #define DEFAULT_SCL_RATE  (100 * 1000) /* Hz */
>   
>   enum rk3x_i2c_state {

WARNING: multiple messages have this Message-ID (diff)
From: Caesar Wang <sasukewxt@163.com>
To: Doug Anderson <dianders@chromium.org>, Wolfram Sang <wsa@the-dreams.de>
Cc: Addy Ke <addy.ke@rock-chips.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Max Schwarz <max.schwarz@online.de>,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] i2c: rk3x: Increase wait timeout to 1 second
Date: Fri, 01 May 2015 11:40:37 +0800	[thread overview]
Message-ID: <5542F5B5.9000206@163.com> (raw)
In-Reply-To: <1430430247-9632-1-git-send-email-dianders@chromium.org>



在 2015年05月01日 05:44, Doug Anderson 写道:
> While it's not sensible for an i2c command to _actually_ need more
> than 200ms to complete, let's increase the timeout anyway.  Why?  It
> turns out that if you've got a large number of printks going out to a
> serial console, interrupts on a CPU can be disabled for hundreds of
> milliseconds. That's not a great situation to be in to start with
> (maybe we should put a cap in vprintk_emit()) but it's pretty annoying
> to start seeing unexplained i2c timeouts.
>
> A normal system shouldn't see i2c timeouts anyway, so increasing the
> timeout should help people debugging without hurting other people
> excessively.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
>   drivers/i2c/busses/i2c-rk3x.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index 019d542..72e97e30 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -72,7 +72,7 @@ enum {
>   #define REG_INT_ALL       0x7f
>   
>   /* Constants */
> -#define WAIT_TIMEOUT      200 /* ms */
> +#define WAIT_TIMEOUT      1000 /* ms */
Yeah, verified on veyron device.

Tested-by: Caesar Wang <wxt@rock-chips.com>



Thanks.

Caesar
>   #define DEFAULT_SCL_RATE  (100 * 1000) /* Hz */
>   
>   enum rk3x_i2c_state {



  parent reply	other threads:[~2015-05-01  3:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 21:44 [PATCH] i2c: rk3x: Increase wait timeout to 1 second Doug Anderson
2015-04-30 21:44 ` Doug Anderson
     [not found] ` <1430430247-9632-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2015-05-01  3:40   ` Caesar Wang [this message]
2015-05-01  3:40     ` Caesar Wang
2015-05-01  3:40     ` Caesar Wang
2015-05-04  8:33   ` Uwe Kleine-König
2015-05-04  8:33     ` Uwe Kleine-König
2015-05-04  8:33     ` Uwe Kleine-König
     [not found]     ` <20150504083312.GN25193-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-05-04 15:11       ` Doug Anderson
2015-05-04 15:11         ` Doug Anderson
2015-05-04 15:11         ` Doug Anderson
     [not found]         ` <CAD=FV=W1UMOfVCEYAHmsxQfoyXvGRSd63Sw26zEki+A-7G7eiw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-04 15:24           ` Uwe Kleine-König
2015-05-04 15:24             ` Uwe Kleine-König
2015-05-04 15:24             ` Uwe Kleine-König
     [not found]             ` <20150504152415.GS25193-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-05-04 16:38               ` Doug Anderson
2015-05-04 16:38                 ` Doug Anderson
2015-05-04 16:38                 ` Doug Anderson
2015-05-05 13:10                 ` Uwe Kleine-König
2015-05-05 13:10                   ` Uwe Kleine-König
2015-05-01  3:42 ` Caesar Wang
2015-05-01  3:42   ` Caesar Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5542F5B5.9000206@163.com \
    --to=sasukewxt-9onoh4p/ygk@public.gmane.org \
    --cc=addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=max.schwarz-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.