From: Hanjun Guo <hanjun.guo@linaro.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Cc: Lan Tianyu <tianyu.lan@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] drivers: acpi: make ACPI_PROCFS_POWER X86 only
Date: Sat, 02 May 2015 21:09:35 +0800 [thread overview]
Message-ID: <5544CC8F.70203@linaro.org> (raw)
In-Reply-To: <1430476021-12247-1-git-send-email-lorenzo.pieralisi@arm.com>
On 2015年05月01日 18:27, Lorenzo Pieralisi wrote:
> The ACPI procfs power interface is initialized by compilation units
> that are only selectable on X86 platforms. Since its usage is
> deprecated and it cannot even be used on platforms other than X86
> it should be compiled in only on X86 platforms.
>
> This patch makes CONFIG_ACPI_PROCFS_POWER dependent on X86, so
> that other architectures are prevented from compiling it in for
> no purpose.
>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Hanjun Guo <hanjun.guo@linaro.org>
> Cc: Lan Tianyu <tianyu.lan@intel.com>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
I think this proc fs was not used for IA64 (it is
for server platform) too.
Acked-by: Hanjun Guo <hanjun.guo@linaro.org>
> ---
> Lan, Rafael,
>
> I do not see any reason why this option is allowed to be selected
> on platforms other than X86, so let's make it X86 only. Please let
> me know what you think, thanks.
>
> Lorenzo
>
> drivers/acpi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index ab2cbb5..16da185 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -62,7 +62,7 @@ config ACPI_SLEEP
>
> config ACPI_PROCFS_POWER
> bool "Deprecated power /proc/acpi directories"
> - depends on PROC_FS
> + depends on X86 && PROC_FS
> help
> For backwards compatibility, this option allows
> deprecated power /proc/acpi/ directories to exist, even when
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Hanjun Guo <hanjun.guo@linaro.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Cc: Lan Tianyu <tianyu.lan@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] drivers: acpi: make ACPI_PROCFS_POWER X86 only
Date: Sat, 02 May 2015 21:09:35 +0800 [thread overview]
Message-ID: <5544CC8F.70203@linaro.org> (raw)
In-Reply-To: <1430476021-12247-1-git-send-email-lorenzo.pieralisi@arm.com>
On 2015年05月01日 18:27, Lorenzo Pieralisi wrote:
> The ACPI procfs power interface is initialized by compilation units
> that are only selectable on X86 platforms. Since its usage is
> deprecated and it cannot even be used on platforms other than X86
> it should be compiled in only on X86 platforms.
>
> This patch makes CONFIG_ACPI_PROCFS_POWER dependent on X86, so
> that other architectures are prevented from compiling it in for
> no purpose.
>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Hanjun Guo <hanjun.guo@linaro.org>
> Cc: Lan Tianyu <tianyu.lan@intel.com>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
I think this proc fs was not used for IA64 (it is
for server platform) too.
Acked-by: Hanjun Guo <hanjun.guo@linaro.org>
> ---
> Lan, Rafael,
>
> I do not see any reason why this option is allowed to be selected
> on platforms other than X86, so let's make it X86 only. Please let
> me know what you think, thanks.
>
> Lorenzo
>
> drivers/acpi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index ab2cbb5..16da185 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -62,7 +62,7 @@ config ACPI_SLEEP
>
> config ACPI_PROCFS_POWER
> bool "Deprecated power /proc/acpi directories"
> - depends on PROC_FS
> + depends on X86 && PROC_FS
> help
> For backwards compatibility, this option allows
> deprecated power /proc/acpi/ directories to exist, even when
>
next prev parent reply other threads:[~2015-05-02 13:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 10:27 [PATCH] drivers: acpi: make ACPI_PROCFS_POWER X86 only Lorenzo Pieralisi
2015-05-02 13:09 ` Hanjun Guo [this message]
2015-05-02 13:09 ` Hanjun Guo
2015-05-15 0:02 ` Rafael J. Wysocki
2015-05-15 0:02 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5544CC8F.70203@linaro.org \
--to=hanjun.guo@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=tianyu.lan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.