From: Paolo Bonzini <pbonzini@redhat.com>
To: Nadav Amit <namit@cs.technion.ac.il>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Call-far should not be emulated as stack op
Date: Thu, 07 May 2015 11:31:02 +0200 [thread overview]
Message-ID: <554B30D6.2030001@redhat.com> (raw)
In-Reply-To: <1430673777-15451-1-git-send-email-namit@cs.technion.ac.il>
On 03/05/2015 19:22, Nadav Amit wrote:
> Far call in 64-bit has a 32-bit operand size. Remove the marking of this
> operation as Stack so it can be emulated correctly in 64-bit.
>
> Signed-off-by: Nadav Amit <namit@cs.technion.ac.il>
> ---
> arch/x86/kvm/emulate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 630bcb0..5839fc5 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -3840,7 +3840,7 @@ static const struct opcode group5[] = {
> F(DstMem | SrcNone | Lock, em_inc),
> F(DstMem | SrcNone | Lock, em_dec),
> I(SrcMem | NearBranch, em_call_near_abs),
> - I(SrcMemFAddr | ImplicitOps | Stack, em_call_far),
> + I(SrcMemFAddr | ImplicitOps, em_call_far),
> I(SrcMem | NearBranch, em_jmp_abs),
> I(SrcMemFAddr | ImplicitOps, em_jmp_far),
> I(SrcMem | Stack, em_push), D(Undefined),
>
Applied, thanks.
Paolo
prev parent reply other threads:[~2015-05-07 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-03 17:22 [PATCH] KVM: x86: Call-far should not be emulated as stack op Nadav Amit
2015-05-07 9:31 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554B30D6.2030001@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=namit@cs.technion.ac.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.