* [PATCH] KVM: x86: Call-far should not be emulated as stack op
@ 2015-05-03 17:22 Nadav Amit
2015-05-07 9:31 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Nadav Amit @ 2015-05-03 17:22 UTC (permalink / raw)
To: pbonzini; +Cc: kvm, Nadav Amit
Far call in 64-bit has a 32-bit operand size. Remove the marking of this
operation as Stack so it can be emulated correctly in 64-bit.
Signed-off-by: Nadav Amit <namit@cs.technion.ac.il>
---
arch/x86/kvm/emulate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index 630bcb0..5839fc5 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -3840,7 +3840,7 @@ static const struct opcode group5[] = {
F(DstMem | SrcNone | Lock, em_inc),
F(DstMem | SrcNone | Lock, em_dec),
I(SrcMem | NearBranch, em_call_near_abs),
- I(SrcMemFAddr | ImplicitOps | Stack, em_call_far),
+ I(SrcMemFAddr | ImplicitOps, em_call_far),
I(SrcMem | NearBranch, em_jmp_abs),
I(SrcMemFAddr | ImplicitOps, em_jmp_far),
I(SrcMem | Stack, em_push), D(Undefined),
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: x86: Call-far should not be emulated as stack op
2015-05-03 17:22 [PATCH] KVM: x86: Call-far should not be emulated as stack op Nadav Amit
@ 2015-05-07 9:31 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2015-05-07 9:31 UTC (permalink / raw)
To: Nadav Amit; +Cc: kvm
On 03/05/2015 19:22, Nadav Amit wrote:
> Far call in 64-bit has a 32-bit operand size. Remove the marking of this
> operation as Stack so it can be emulated correctly in 64-bit.
>
> Signed-off-by: Nadav Amit <namit@cs.technion.ac.il>
> ---
> arch/x86/kvm/emulate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 630bcb0..5839fc5 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -3840,7 +3840,7 @@ static const struct opcode group5[] = {
> F(DstMem | SrcNone | Lock, em_inc),
> F(DstMem | SrcNone | Lock, em_dec),
> I(SrcMem | NearBranch, em_call_near_abs),
> - I(SrcMemFAddr | ImplicitOps | Stack, em_call_far),
> + I(SrcMemFAddr | ImplicitOps, em_call_far),
> I(SrcMem | NearBranch, em_jmp_abs),
> I(SrcMemFAddr | ImplicitOps, em_jmp_far),
> I(SrcMem | Stack, em_push), D(Undefined),
>
Applied, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-07 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-03 17:22 [PATCH] KVM: x86: Call-far should not be emulated as stack op Nadav Amit
2015-05-07 9:31 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.