All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Wood <michael.g.wood@intel.com>
To: toaster@yoctoproject.org
Subject: Re: [review-request] adamian/20150506_toasterloggerfixes
Date: Thu, 14 May 2015 18:15:21 +0100	[thread overview]
Message-ID: <5554D829.4070908@intel.com> (raw)
In-Reply-To: <CAJ2CSBuY=dY4Yv_KRQVki0TfoZ6i4KcwqPk-ohdmwY8rJgJ59Q@mail.gmail.com>

Looks fine to me (though I'm not that familiar with the buildinfohelper 
side of things).

Thanks

On 14/05/15 16:58, Damian, Alexandru wrote:
> Hi,
>
> I did a bit of refactoring on the toaster build logger which fixes 
> some issues, and clear up the path for future improvement.
>
> * the "local_path" property of the Layer is now moved to 
> Layer_Version. It was a mistake to assign specific build-local paths 
> to the generic Layer information, as it is naturally a property of a 
> specific Layer checkout, which is what a Layer Version is.
>
> * all the recipe paths are now relative to a Layer_Version checkout, 
> no more absolute paths. This allows us to link a recipe file directly 
> to a remote GIT repo of a Layer, if needed.
>
> * the "namespace" (e.g virtual:native: ) part of a recipe path is 
> stored in a new field; all paths are now clean paths, so they can be 
> manipulated as such. Storing the namespace separately should also fix 
> the mis-identification of tasks between native and normal tasks, for 
> example (multiple bugs opened on this one)
>
> * all the builds now occur under a Project. this is the first step for 
> the unification of Managed and Interactive modes. The UI interface is 
> not changed.
>
> * django auth tables are now created under interactive mode, too. This 
> allows us to get rid of the atrocity of storing display state on the 
> front-end cookies. Another step in the unification of modes.
>
> * some smaller fixes regarding data collection are in there.
>
> Can you please see if this makes sense to you ?
>
> Cheers,
> Alex
>
>
> -- 
> Alex Damian
> Yocto Project
> SSG / OTC
>
>



  reply	other threads:[~2015-05-14 17:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 15:58 [review-request] adamian/20150506_toasterloggerfixes Damian, Alexandru
2015-05-14 17:15 ` Michael Wood [this message]
2015-05-15  9:48 ` Barros Pena, Belen
2015-05-15 11:31   ` Barros Pena, Belen
2015-05-21  9:41     ` Damian, Alexandru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5554D829.4070908@intel.com \
    --to=michael.g.wood@intel.com \
    --cc=toaster@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.