[review-request] adamian/20150506_toasterloggerfixes

[review-request] adamian/20150506_toasterloggerfixes

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

Hi,

I did a bit of refactoring on the toaster build logger which fixes some
issues, and clear up the path for future improvement.

* the "local_path" property of the Layer is now moved to Layer_Version. It
was a mistake to assign specific build-local paths to the generic Layer
information, as it is naturally a property of a specific Layer checkout,
which is what a Layer Version is.

* all the recipe paths are now relative to a Layer_Version checkout, no
more absolute paths. This allows us to link a recipe file directly to a
remote GIT repo of a Layer, if needed.

* the "namespace" (e.g virtual:native: ) part of a recipe path is stored in
a new field; all paths are now clean paths, so they can be manipulated as
such. Storing the namespace separately should also fix the
mis-identification of tasks between native and normal tasks, for example
(multiple bugs opened on this one)

* all the builds now occur under a Project. this is the first step for the
unification of Managed and Interactive modes. The UI interface is not
changed.

* django auth tables are now created under interactive mode, too. This
allows us to get rid of the atrocity of storing display state on the
front-end cookies. Another step in the unification of modes.

* some smaller fixes regarding data collection are in there.

Can you please see if this makes sense to you ?

Cheers,
Alex


-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 3002 bytes --]

Re: [review-request] adamian/20150506_toasterloggerfixes

[Michael Wood]

Looks fine to me (though I'm not that familiar with the buildinfohelper 
side of things).

Thanks

On 14/05/15 16:58, Damian, Alexandru wrote:
> Hi,
>
> I did a bit of refactoring on the toaster build logger which fixes 
> some issues, and clear up the path for future improvement.
>
> * the "local_path" property of the Layer is now moved to 
> Layer_Version. It was a mistake to assign specific build-local paths 
> to the generic Layer information, as it is naturally a property of a 
> specific Layer checkout, which is what a Layer Version is.
>
> * all the recipe paths are now relative to a Layer_Version checkout, 
> no more absolute paths. This allows us to link a recipe file directly 
> to a remote GIT repo of a Layer, if needed.
>
> * the "namespace" (e.g virtual:native: ) part of a recipe path is 
> stored in a new field; all paths are now clean paths, so they can be 
> manipulated as such. Storing the namespace separately should also fix 
> the mis-identification of tasks between native and normal tasks, for 
> example (multiple bugs opened on this one)
>
> * all the builds now occur under a Project. this is the first step for 
> the unification of Managed and Interactive modes. The UI interface is 
> not changed.
>
> * django auth tables are now created under interactive mode, too. This 
> allows us to get rid of the atrocity of storing display state on the 
> front-end cookies. Another step in the unification of modes.
>
> * some smaller fixes regarding data collection are in there.
>
> Can you please see if this makes sense to you ?
>
> Cheers,
> Alex
>
>
> -- 
> Alex Damian
> Yocto Project
> SSG / OTC
>
>

Re: [review-request] adamian/20150506_toasterloggerfixes

[Barros Pena, Belen]

Sorry, I am not able to test this. I need new build data, but the builds
seem to be getting stuck at the 'checking out layers' stage.

Cheers

Belén

On 14/05/2015 16:58, "Damian, Alexandru" <alexandru.damian@intel.com>
wrote:

>Hi,
>
>
>I did a bit of refactoring on the toaster build logger which fixes some
>issues, and clear up the path for future improvement.
>
>
>* the "local_path" property of the Layer is now moved to Layer_Version.
>It was a mistake to assign specific build-local paths to the generic
>Layer information, as it is naturally a property of
> a specific Layer checkout, which is what a Layer Version is.
>
>
>* all the recipe paths are now relative to a Layer_Version checkout, no
>more absolute paths. This allows us to link a recipe file directly to a
>remote GIT repo of a Layer, if needed.
>
>
>* the "namespace" (e.g virtual:native: ) part of a recipe path is stored
>in a new field; all paths are now clean paths, so they can be manipulated
>as such. Storing the namespace separately should
> also fix the mis-identification of tasks between native and normal
>tasks, for example (multiple bugs opened on this one)
>
>
>* all the builds now occur under a Project. this is the first step for
>the unification of Managed and Interactive modes. The UI interface is not
>changed.
>
>
>* django auth tables are now created under interactive mode, too. This
>allows us to get rid of the atrocity of storing display state on the
>front-end cookies. Another step in the unification of
> modes.
>
>
>* some smaller fixes regarding data collection are in there.
>
>
>Can you please see if this makes sense to you ?
>
>
>Cheers,
>Alex
>
>
>
>
>-- 
>Alex Damian
>Yocto Project
>
>SSG / OTC 
>
>
>

Re: [review-request] adamian/20150506_toasterloggerfixes

[Barros Pena, Belen]

On 15/05/2015 10:48, "Barros Pena, Belen" <belen.barros.pena@intel.com>
wrote:

>Sorry, I am not able to test this. I need new build data, but the builds
>seem to be getting stuck at the 'checking out layers' stage.

Managed to have a look at it with help from Michael.

The recipe file information looks much cleaner.

Thanks!

Belén

>
>Cheers
>
>Belén
>
>On 14/05/2015 16:58, "Damian, Alexandru" <alexandru.damian@intel.com>
>wrote:
>>
>>* all the recipe paths are now relative to a Layer_Version checkout, no
>>more absolute paths. This allows us to link a recipe file directly to a
>>remote GIT repo of a Layer, if needed.
>>
>>
>>* the "namespace" (e.g virtual:native: ) part of a recipe path is stored
>>in a new field; all paths are now clean paths, so they can be manipulated
>>as such. Storing the namespace separately should
>> also fix the mis-identification of tasks between native and normal
>>tasks, for example (multiple bugs opened on this one)
>>
>>
>>* all the builds now occur under a Project. this is the first step for
>>the unification of Managed and Interactive modes. The UI interface is not
>>changed.
>>
>>
>>* django auth tables are now created under interactive mode, too. This
>>allows us to get rid of the atrocity of storing display state on the
>>front-end cookies. Another step in the unification of
>> modes.
>>
>>
>>* some smaller fixes regarding data collection are in there.
>>
>>
>>Can you please see if this makes sense to you ?
>>
>>
>>Cheers,
>>Alex
>>
>>
>>
>>
>>-- 
>>Alex Damian
>>Yocto Project
>>
>>SSG / OTC 
>>
>>
>>
>

Re: [review-request] adamian/20150506_toasterloggerfixes

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 1947 bytes --]

Taken for submission.

Alex

On Fri, May 15, 2015 at 12:31 PM, Barros Pena, Belen <
belen.barros.pena@intel.com> wrote:

>
>
> On 15/05/2015 10:48, "Barros Pena, Belen" <belen.barros.pena@intel.com>
> wrote:
>
> >Sorry, I am not able to test this. I need new build data, but the builds
> >seem to be getting stuck at the 'checking out layers' stage.
>
> Managed to have a look at it with help from Michael.
>
> The recipe file information looks much cleaner.
>
> Thanks!
>
> Belén
>
> >
> >Cheers
> >
> >Belén
> >
> >On 14/05/2015 16:58, "Damian, Alexandru" <alexandru.damian@intel.com>
> >wrote:
> >>
> >>* all the recipe paths are now relative to a Layer_Version checkout, no
> >>more absolute paths. This allows us to link a recipe file directly to a
> >>remote GIT repo of a Layer, if needed.
> >>
> >>
> >>* the "namespace" (e.g virtual:native: ) part of a recipe path is stored
> >>in a new field; all paths are now clean paths, so they can be manipulated
> >>as such. Storing the namespace separately should
> >> also fix the mis-identification of tasks between native and normal
> >>tasks, for example (multiple bugs opened on this one)
> >>
> >>
> >>* all the builds now occur under a Project. this is the first step for
> >>the unification of Managed and Interactive modes. The UI interface is not
> >>changed.
> >>
> >>
> >>* django auth tables are now created under interactive mode, too. This
> >>allows us to get rid of the atrocity of storing display state on the
> >>front-end cookies. Another step in the unification of
> >> modes.
> >>
> >>
> >>* some smaller fixes regarding data collection are in there.
> >>
> >>
> >>Can you please see if this makes sense to you ?
> >>
> >>
> >>Cheers,
> >>Alex
> >>
> >>
> >>
> >>
> >>--
> >>Alex Damian
> >>Yocto Project
> >>
> >>SSG / OTC
> >>
> >>
> >>
> >
>
>


-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 3177 bytes --]