From: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Jonathan Richardson
<jonathar-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: Scott Branden <sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Dmitry Torokhov <dtor-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Anatol Pomazau <anatol-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bcm-kernel-feedback-list
<bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.
Date: Thu, 14 May 2015 14:43:14 -0700 [thread overview]
Message-ID: <555516F2.6080201@gmail.com> (raw)
In-Reply-To: <20150514201221.GX2761-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On 14/05/15 13:12, Mark Brown wrote:
> On Thu, May 14, 2015 at 12:55:32PM -0700, Jonathan Richardson wrote:
>> On 15-05-14 12:08 PM, Mark Brown wrote:
>
>>> All it takes is one hardware engineer who sees a SPI controller and a
>>> GPIO they can use for chip select; I wouldn't be so sure that nobody
>>> ever fixed this up locally (or happened to use a device that only needed
>>> single duplex).
>
>> Hi Mark. Would it help if we just set the flags to half duplex using
>> SPI_MASTER_HALF_DUPLEX when we register the master?
>
> That would deal with the data corruption issues, yes. Though it seems
> like there are some people who want full duplex support here - I don't
> know if any of them can point you at suitable hardware to test?
I am fine with having the driver supporting only half-duplex for now,
considering that Jonathan and Scott have no peripheral to test
full-duplex with.
Getting you platforms and test setups could take more time than needed
so, let's proceed with the shortest path.
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Mark Brown <broonie@kernel.org>,
Jonathan Richardson <jonathar@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>,
Dmitry Torokhov <dtor@google.com>,
Anatol Pomazau <anatol@google.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.
Date: Thu, 14 May 2015 14:43:14 -0700 [thread overview]
Message-ID: <555516F2.6080201@gmail.com> (raw)
In-Reply-To: <20150514201221.GX2761@sirena.org.uk>
On 14/05/15 13:12, Mark Brown wrote:
> On Thu, May 14, 2015 at 12:55:32PM -0700, Jonathan Richardson wrote:
>> On 15-05-14 12:08 PM, Mark Brown wrote:
>
>>> All it takes is one hardware engineer who sees a SPI controller and a
>>> GPIO they can use for chip select; I wouldn't be so sure that nobody
>>> ever fixed this up locally (or happened to use a device that only needed
>>> single duplex).
>
>> Hi Mark. Would it help if we just set the flags to half duplex using
>> SPI_MASTER_HALF_DUPLEX when we register the master?
>
> That would deal with the data corruption issues, yes. Though it seems
> like there are some people who want full duplex support here - I don't
> know if any of them can point you at suitable hardware to test?
I am fine with having the driver supporting only half-duplex for now,
considering that Jonathan and Scott have no peripheral to test
full-duplex with.
Getting you platforms and test setups could take more time than needed
so, let's proceed with the shortest path.
--
Florian
next prev parent reply other threads:[~2015-05-14 21:43 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 17:38 [PATCH 0/2] Add Broadcom MSPI driver Jonathan Richardson
2015-05-12 17:38 ` Jonathan Richardson
2015-05-12 17:38 ` Jonathan Richardson
2015-05-12 17:38 ` [PATCH 1/2] ARM: dts: Add binding for " Jonathan Richardson
2015-05-12 17:38 ` Jonathan Richardson
[not found] ` <1431452293-16697-2-git-send-email-jonathar-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-05-12 18:38 ` Florian Fainelli
2015-05-12 18:38 ` Florian Fainelli
2015-05-12 17:38 ` [PATCH 2/2] spi: bcm-mspi: Add support " Jonathan Richardson
2015-05-12 17:38 ` Jonathan Richardson
[not found] ` <1431452293-16697-3-git-send-email-jonathar-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-05-12 18:46 ` Florian Fainelli
2015-05-12 18:46 ` Florian Fainelli
2015-05-12 19:17 ` Mark Brown
2015-05-12 19:17 ` Mark Brown
[not found] ` <20150512191718.GW3066-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-13 23:49 ` Jonathan Richardson
2015-05-13 23:49 ` Jonathan Richardson
2015-05-13 23:49 ` Jonathan Richardson
[not found] ` <5553E31A.8060309-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-05-14 0:19 ` Scott Branden
2015-05-14 0:19 ` Scott Branden
2015-05-14 0:19 ` Scott Branden
2015-05-14 10:31 ` Mark Brown
[not found] ` <20150514103144.GO2761-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-14 18:19 ` Scott Branden
2015-05-14 18:19 ` Scott Branden
2015-05-14 18:19 ` Scott Branden
[not found] ` <5554E715.7070203-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-05-14 18:28 ` Florian Fainelli
2015-05-14 18:28 ` Florian Fainelli
[not found] ` <5554E957.3030809-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-14 18:36 ` Scott Branden
2015-05-14 18:36 ` Scott Branden
2015-05-14 18:36 ` Scott Branden
[not found] ` <5554EB49.9020601-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-05-14 18:55 ` Jonathan Richardson
2015-05-14 18:55 ` Jonathan Richardson
2015-05-14 18:55 ` Jonathan Richardson
2015-05-14 19:08 ` Mark Brown
2015-05-14 19:08 ` Mark Brown
[not found] ` <20150514190823.GR2761-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-14 19:55 ` Jonathan Richardson
2015-05-14 19:55 ` Jonathan Richardson
2015-05-14 19:55 ` Jonathan Richardson
2015-05-14 20:12 ` Mark Brown
[not found] ` <20150514201221.GX2761-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-14 21:43 ` Florian Fainelli [this message]
2015-05-14 21:43 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555516F2.6080201@gmail.com \
--to=f.fainelli-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=anatol-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dtor-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jonathar-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.