* Re: "don't bugger nd->seq" seems to break umount sometimes
[not found] ` <21824.50281.405589.957467@mariner.uk.xensource.com>
@ 2015-04-29 12:21 ` Al Viro
2015-04-30 1:15 ` Zefan Li
0 siblings, 1 reply; 6+ messages in thread
From: Al Viro @ 2015-04-29 12:21 UTC (permalink / raw)
To: Ian Jackson
Cc: xen-tools, xen-devel, Andrew Cooper, stefano.stabellini, Zefan Li,
David Vrabel, Boris Ostrovsky
On Wed, Apr 29, 2015 at 12:45:45PM +0100, Ian Jackson wrote:
> The symptoms are that `umount' fails with EBUSY,
[lizf: Backported to 3.4:
- remove the changes to follow_link() as it doesn't call set_root()]
looks dubious - I don't have -stable in front of me, but set_root() in
follow_link() had migrated from __vfs_follow_link(), so could you try
(tr '#' '\t' | ed fs/namei.c) <<'EOF'
/__vfs_follow_link/
/set_root/s/^/#/
i
##if (!nd->root.mnt)
.
wq
EOF
and see if it helps?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: "don't bugger nd->seq" seems to break umount sometimes
2015-04-29 12:21 ` "don't bugger nd->seq" seems to break umount sometimes Al Viro
@ 2015-04-30 1:15 ` Zefan Li
2015-05-19 8:33 ` Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: Zefan Li @ 2015-04-30 1:15 UTC (permalink / raw)
To: Al Viro
Cc: xen-tools, xen-devel, Andrew Cooper, stefano.stabellini,
Ian Jackson, David Vrabel, Boris Ostrovsky
On 2015/4/29 20:21, Al Viro wrote:
> On Wed, Apr 29, 2015 at 12:45:45PM +0100, Ian Jackson wrote:
>
>> The symptoms are that `umount' fails with EBUSY,
>
> [lizf: Backported to 3.4:
> - remove the changes to follow_link() as it doesn't call set_root()]
>
> looks dubious - I don't have -stable in front of me, but set_root() in
> follow_link() had migrated from __vfs_follow_link(), so could you try
> (tr '#' '\t' | ed fs/namei.c) <<'EOF'
> /__vfs_follow_link/
> /set_root/s/^/#/
> i
> ##if (!nd->root.mnt)
> .
> wq
> EOF
> and see if it helps?
> .
>
My fault. I just checked 3.2.y, and it made the right change.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: "don't bugger nd->seq" seems to break umount sometimes
2015-04-30 1:15 ` Zefan Li
@ 2015-05-19 8:33 ` Ian Campbell
2015-05-19 9:05 ` Zefan Li
0 siblings, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2015-05-19 8:33 UTC (permalink / raw)
To: Zefan Li
Cc: xen-tools, xen-devel, stefano.stabellini, Andrew Cooper,
Ian Jackson, Al Viro, Boris Ostrovsky, David Vrabel
On Thu, 2015-04-30 at 09:15 +0800, Zefan Li wrote:
> On 2015/4/29 20:21, Al Viro wrote:
> > On Wed, Apr 29, 2015 at 12:45:45PM +0100, Ian Jackson wrote:
> >
> >> The symptoms are that `umount' fails with EBUSY,
> >
> > [lizf: Backported to 3.4:
> > - remove the changes to follow_link() as it doesn't call set_root()]
> >
> > looks dubious - I don't have -stable in front of me, but set_root() in
> > follow_link() had migrated from __vfs_follow_link(), so could you try
> > (tr '#' '\t' | ed fs/namei.c) <<'EOF'
> > /__vfs_follow_link/
> > /set_root/s/^/#/
> > i
> > ##if (!nd->root.mnt)
> > .
> > wq
> > EOF
> > and see if it helps?
> > .
> >
>
> My fault. I just checked 3.2.y, and it made the right change.
Is there going to be a 3.4.108 with a fix for this?
Thanks,
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: "don't bugger nd->seq" seems to break umount sometimes
2015-05-19 8:33 ` Ian Campbell
@ 2015-05-19 9:05 ` Zefan Li
2015-05-19 9:47 ` Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: Zefan Li @ 2015-05-19 9:05 UTC (permalink / raw)
To: Ian Campbell
Cc: xen-tools, xen-devel, stefano.stabellini, Andrew Cooper,
Ian Jackson, Al Viro, Boris Ostrovsky, David Vrabel
On 2015/5/19 16:33, Ian Campbell wrote:
> On Thu, 2015-04-30 at 09:15 +0800, Zefan Li wrote:
>> On 2015/4/29 20:21, Al Viro wrote:
>>> On Wed, Apr 29, 2015 at 12:45:45PM +0100, Ian Jackson wrote:
>>>
>>>> The symptoms are that `umount' fails with EBUSY,
>>>
>>> [lizf: Backported to 3.4:
>>> - remove the changes to follow_link() as it doesn't call set_root()]
>>>
>>> looks dubious - I don't have -stable in front of me, but set_root() in
>>> follow_link() had migrated from __vfs_follow_link(), so could you try
>>> (tr '#' '\t' | ed fs/namei.c) <<'EOF'
>>> /__vfs_follow_link/
>>> /set_root/s/^/#/
>>> i
>>> ##if (!nd->root.mnt)
>>> .
>>> wq
>>> EOF
>>> and see if it helps?
>>> .
>>>
>>
>> My fault. I just checked 3.2.y, and it made the right change.
>
> Is there going to be a 3.4.108 with a fix for this?
>
definitely.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: "don't bugger nd->seq" seems to break umount sometimes
2015-05-19 9:05 ` Zefan Li
@ 2015-05-19 9:47 ` Ian Campbell
2015-05-19 10:33 ` Zefan Li
0 siblings, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2015-05-19 9:47 UTC (permalink / raw)
To: Zefan Li
Cc: xen-tools, xen-devel, stefano.stabellini, Andrew Cooper,
Ian Jackson, Al Viro, Boris Ostrovsky, David Vrabel
On Tue, 2015-05-19 at 17:05 +0800, Zefan Li wrote:
> On 2015/5/19 16:33, Ian Campbell wrote:
> > On Thu, 2015-04-30 at 09:15 +0800, Zefan Li wrote:
> >> On 2015/4/29 20:21, Al Viro wrote:
> >>> On Wed, Apr 29, 2015 at 12:45:45PM +0100, Ian Jackson wrote:
> >>>
> >>>> The symptoms are that `umount' fails with EBUSY,
> >>>
> >>> [lizf: Backported to 3.4:
> >>> - remove the changes to follow_link() as it doesn't call set_root()]
> >>>
> >>> looks dubious - I don't have -stable in front of me, but set_root() in
> >>> follow_link() had migrated from __vfs_follow_link(), so could you try
> >>> (tr '#' '\t' | ed fs/namei.c) <<'EOF'
> >>> /__vfs_follow_link/
> >>> /set_root/s/^/#/
> >>> i
> >>> ##if (!nd->root.mnt)
> >>> .
> >>> wq
> >>> EOF
> >>> and see if it helps?
> >>> .
> >>>
> >>
> >> My fault. I just checked 3.2.y, and it made the right change.
> >
> > Is there going to be a 3.4.108 with a fix for this?
> >
>
> definitely.
Great. Do you have a timeline in mind?
We have a daily automated test which has been hitting this issue for a
while, I can continue to ignore the associated cron spam of course ;-)
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: "don't bugger nd->seq" seems to break umount sometimes
2015-05-19 9:47 ` Ian Campbell
@ 2015-05-19 10:33 ` Zefan Li
0 siblings, 0 replies; 6+ messages in thread
From: Zefan Li @ 2015-05-19 10:33 UTC (permalink / raw)
To: Ian Campbell
Cc: xen-tools, xen-devel, stefano.stabellini, Andrew Cooper,
Ian Jackson, Al Viro, Boris Ostrovsky, David Vrabel
>>> Is there going to be a 3.4.108 with a fix for this?
>>>
>>
>> definitely.
>
> Great. Do you have a timeline in mind?
>
Yeah, probably in early June.
> We have a daily automated test which has been hitting this issue for a
> while, I can continue to ignore the associated cron spam of course ;-)
>
:)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-19 10:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1YleTb-0005Ma-NN@osstest.test-lab.xenproject.org>
[not found] ` <21824.50281.405589.957467@mariner.uk.xensource.com>
2015-04-29 12:21 ` "don't bugger nd->seq" seems to break umount sometimes Al Viro
2015-04-30 1:15 ` Zefan Li
2015-05-19 8:33 ` Ian Campbell
2015-05-19 9:05 ` Zefan Li
2015-05-19 9:47 ` Ian Campbell
2015-05-19 10:33 ` Zefan Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.