All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xen: fix building on ARM with CONFIG_HIBERNATE_CALLBACKS
@ 2015-05-19 12:58 ` Arnd Bergmann
  0 siblings, 0 replies; 15+ messages in thread
From: Arnd Bergmann @ 2015-05-19 12:58 UTC (permalink / raw)
  To: linux-arm-kernel

A recent bug fix for x86 broke Xen on ARM for the case that
CONFIG_HIBERNATE_CALLBACKS is enabled:

drivers/built-in.o: In function `do_suspend':
/git/arm-soc/drivers/xen/manage.c:134: undefined reference to `xen_arch_suspend'
drivers/built-in.o:(.debug_addr+0xc3f4): undefined reference to `xen_arch_suspend'

It is not clear to me what needs to be done here, but this
patch avoids the build error by adding a stub for the
missing function.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 2b953a5e99 ("xen: Suspend ticks on all CPUs during suspend")
---
Please review, and submit an alternate patch if this one turns
out to be incorrect.

diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index 0ce4f32017ea..034dc8acd47e 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -13,7 +13,13 @@ void xen_arch_post_suspend(int suspend_cancelled);
 
 void xen_timer_resume(void);
 void xen_arch_resume(void);
+#ifdef CONFIG_X86
 void xen_arch_suspend(void);
+#else
+static inline void xen_arch_suspend(void)
+{
+}
+#endif
 
 void xen_resume_notifier_register(struct notifier_block *nb);
 void xen_resume_notifier_unregister(struct notifier_block *nb);

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [PATCH] xen: fix building on ARM with CONFIG_HIBERNATE_CALLBACKS
@ 2015-05-19 12:58 Arnd Bergmann
  0 siblings, 0 replies; 15+ messages in thread
From: Arnd Bergmann @ 2015-05-19 12:58 UTC (permalink / raw)
  To: Boris Ostrovsky
  Cc: xen-devel, linux-kernel, David Vrabel, linux-arm-kernel,
	Stefano Stabellini

A recent bug fix for x86 broke Xen on ARM for the case that
CONFIG_HIBERNATE_CALLBACKS is enabled:

drivers/built-in.o: In function `do_suspend':
/git/arm-soc/drivers/xen/manage.c:134: undefined reference to `xen_arch_suspend'
drivers/built-in.o:(.debug_addr+0xc3f4): undefined reference to `xen_arch_suspend'

It is not clear to me what needs to be done here, but this
patch avoids the build error by adding a stub for the
missing function.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 2b953a5e99 ("xen: Suspend ticks on all CPUs during suspend")
---
Please review, and submit an alternate patch if this one turns
out to be incorrect.

diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index 0ce4f32017ea..034dc8acd47e 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -13,7 +13,13 @@ void xen_arch_post_suspend(int suspend_cancelled);
 
 void xen_timer_resume(void);
 void xen_arch_resume(void);
+#ifdef CONFIG_X86
 void xen_arch_suspend(void);
+#else
+static inline void xen_arch_suspend(void)
+{
+}
+#endif
 
 void xen_resume_notifier_register(struct notifier_block *nb);
 void xen_resume_notifier_unregister(struct notifier_block *nb);

^ permalink raw reply related	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2015-05-19 15:16 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-19 12:58 [PATCH] xen: fix building on ARM with CONFIG_HIBERNATE_CALLBACKS Arnd Bergmann
2015-05-19 12:58 ` Arnd Bergmann
2015-05-19 13:57 ` Boris Ostrovsky
2015-05-19 13:57 ` Boris Ostrovsky
2015-05-19 13:57   ` Boris Ostrovsky
2015-05-19 14:36   ` Arnd Bergmann
2015-05-19 14:36   ` Arnd Bergmann
2015-05-19 14:36     ` Arnd Bergmann
2015-05-19 14:49     ` Boris Ostrovsky
2015-05-19 14:49     ` Boris Ostrovsky
2015-05-19 14:49       ` Boris Ostrovsky
2015-05-19 15:15       ` David Vrabel
2015-05-19 15:15         ` David Vrabel
2015-05-19 15:15       ` David Vrabel
  -- strict thread matches above, loose matches on Subject: below --
2015-05-19 12:58 Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.