From: Mikko Perttunen <mikko.perttunen-/1wQRMveznE@public.gmane.org>
To: Dan Carpenter
<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: clk: tegra: Add closed loop support for the DFLL
Date: Sat, 23 May 2015 21:55:37 +0300 [thread overview]
Message-ID: <5560CD29.5010206@kapsi.fi> (raw)
In-Reply-To: <20150523171549.GA27611@mwanda>
On 05/23/2015 08:15 PM, Dan Carpenter wrote:
> Hello Tuomas Tynkkynen,
>
> The patch 435874b0fdf4: "clk: tegra: Add closed loop support for the
> DFLL" from May 13, 2015, leads to the following static checker
> warning:
>
> drivers/clk/tegra/clk-dfll.c:1448 dfll_build_i2c_lut()
> warn: unsigned 'td->i2c_lut[0]' is never less than zero.
>
> drivers/clk/tegra/clk-dfll.c
> 1446 v = td->soc->min_millivolts * 1000;
> 1447 td->i2c_lut[0] = find_vdd_map_entry_exact(td, v);
> 1448 if (td->i2c_lut[0] < 0)
> ^^^^^^^^^^^^^^^^^^
> Never true.
>
> 1449 goto out;
> 1450
>
> regards,
> dan carpenter
Thanks for checking; for now, this shouldn't cause any problems. I will
post a patch on monday.
Cheers,
Mikko.
prev parent reply other threads:[~2015-05-23 18:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-23 17:15 clk: tegra: Add closed loop support for the DFLL Dan Carpenter
2015-05-23 18:55 ` Mikko Perttunen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5560CD29.5010206@kapsi.fi \
--to=mikko.perttunen-/1wqrmvezne@public.gmane.org \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.