re: clk: tegra: Add closed loop support for the DFLL

re: clk: tegra: Add closed loop support for the DFLL

[Dan Carpenter]

Hello Tuomas Tynkkynen,

The patch 435874b0fdf4: "clk: tegra: Add closed loop support for the
DFLL" from May 13, 2015, leads to the following static checker
warning:

	drivers/clk/tegra/clk-dfll.c:1448 dfll_build_i2c_lut()
	warn: unsigned 'td->i2c_lut[0]' is never less than zero.

drivers/clk/tegra/clk-dfll.c
  1446          v = td->soc->min_millivolts * 1000;
  1447          td->i2c_lut[0] = find_vdd_map_entry_exact(td, v);
  1448          if (td->i2c_lut[0] < 0)
                    ^^^^^^^^^^^^^^^^^^
Never true.

  1449                  goto out;
  1450  

regards,
dan carpenter

Re: clk: tegra: Add closed loop support for the DFLL

[Mikko Perttunen]

On 05/23/2015 08:15 PM, Dan Carpenter wrote:
> Hello Tuomas Tynkkynen,
>
> The patch 435874b0fdf4: "clk: tegra: Add closed loop support for the
> DFLL" from May 13, 2015, leads to the following static checker
> warning:
>
> 	drivers/clk/tegra/clk-dfll.c:1448 dfll_build_i2c_lut()
> 	warn: unsigned 'td->i2c_lut[0]' is never less than zero.
>
> drivers/clk/tegra/clk-dfll.c
>    1446          v = td->soc->min_millivolts * 1000;
>    1447          td->i2c_lut[0] = find_vdd_map_entry_exact(td, v);
>    1448          if (td->i2c_lut[0] < 0)
>                      ^^^^^^^^^^^^^^^^^^
> Never true.
>
>    1449                  goto out;
>    1450
>
> regards,
> dan carpenter

Thanks for checking; for now, this shouldn't cause any problems. I will 
post a patch on monday.

Cheers,
Mikko.