* [PATCH 1/1] drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static
@ 2015-05-16 4:22 Tolga Ceylan
2015-05-24 2:54 ` tolga ceylan
2015-05-24 20:32 ` Greg Kroah-Hartman
0 siblings, 2 replies; 4+ messages in thread
From: Tolga Ceylan @ 2015-05-16 4:22 UTC (permalink / raw)
To: Benjamin Romer, David Kershner, Greg Kroah-Hartman, Jes Sorensen,
sparmaintainer, devel, linux-kernel
Cc: Tolga Ceylan
visorchipset_file_init() and visorchipset_file_cleanup() functions
do not seem to be used from anywhere else and now are declared
as static. Sparse emitted "not declared" warnings for these two
functions.
Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
---
drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index ca22f49..66ae3d0 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -2351,7 +2351,7 @@ static const struct file_operations visorchipset_fops = {
.mmap = visorchipset_mmap,
};
-int
+static int
visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel)
{
int rc = 0;
@@ -2460,7 +2460,7 @@ cleanup:
return rc;
}
-void
+static void
visorchipset_file_cleanup(dev_t major_dev)
{
if (file_cdev.ops)
--
2.4.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static
2015-05-16 4:22 [PATCH 1/1] drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static Tolga Ceylan
@ 2015-05-24 2:54 ` tolga ceylan
2015-05-24 14:30 ` Jes Sorensen
2015-05-24 20:32 ` Greg Kroah-Hartman
1 sibling, 1 reply; 4+ messages in thread
From: tolga ceylan @ 2015-05-24 2:54 UTC (permalink / raw)
To: Benjamin Romer, David Kershner, Greg Kroah-Hartman, Jes Sorensen,
sparmaintainer, devel, linux-kernel
On 05/15/2015 09:22 PM, Tolga Ceylan wrote:
> visorchipset_file_init() and visorchipset_file_cleanup() functions
> do not seem to be used from anywhere else and now are declared
> as static. Sparse emitted "not declared" warnings for these two
> functions.
>
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
> ---
> drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
> index ca22f49..66ae3d0 100644
> --- a/drivers/staging/unisys/visorbus/visorchipset.c
> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> @@ -2351,7 +2351,7 @@ static const struct file_operations visorchipset_fops = {
> .mmap = visorchipset_mmap,
> };
>
> -int
> +static int
> visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel)
> {
> int rc = 0;
> @@ -2460,7 +2460,7 @@ cleanup:
> return rc;
> }
>
> -void
> +static void
> visorchipset_file_cleanup(dev_t major_dev)
> {
> if (file_cdev.ops)
>
I haven't received a response for this patch. Just checking back.
Regards,
Tolga Ceylan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static
2015-05-24 2:54 ` tolga ceylan
@ 2015-05-24 14:30 ` Jes Sorensen
0 siblings, 0 replies; 4+ messages in thread
From: Jes Sorensen @ 2015-05-24 14:30 UTC (permalink / raw)
To: tolga ceylan
Cc: Benjamin Romer, David Kershner, Greg Kroah-Hartman,
sparmaintainer, devel, linux-kernel
tolga ceylan <tolga.ceylan@gmail.com> writes:
> On 05/15/2015 09:22 PM, Tolga Ceylan wrote:
>> visorchipset_file_init() and visorchipset_file_cleanup() functions
>> do not seem to be used from anywhere else and now are declared
>> as static. Sparse emitted "not declared" warnings for these two
>> functions.
>>
>> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
>> ---
>> drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
>> index ca22f49..66ae3d0 100644
>> --- a/drivers/staging/unisys/visorbus/visorchipset.c
>> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
>> @@ -2351,7 +2351,7 @@ static const struct file_operations visorchipset_fops = {
>> .mmap = visorchipset_mmap,
>> };
>>
>> -int
>> +static int
>> visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel)
>> {
>> int rc = 0;
>> @@ -2460,7 +2460,7 @@ cleanup:
>> return rc;
>> }
>>
>> -void
>> +static void
>> visorchipset_file_cleanup(dev_t major_dev)
>> {
>> if (file_cdev.ops)
>>
>
> I haven't received a response for this patch. Just checking back.
>
> Regards,
> Tolga Ceylan
I don't think there is anything wrong with your patch. However, there is
a lot of active development going to clean up the code in the unisys
tree right now, and your patch conflicts with that. I would prefer to
hold off with this for now, until it settles down a bit.
Cheers,
Jes
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static
2015-05-16 4:22 [PATCH 1/1] drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static Tolga Ceylan
2015-05-24 2:54 ` tolga ceylan
@ 2015-05-24 20:32 ` Greg Kroah-Hartman
1 sibling, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2015-05-24 20:32 UTC (permalink / raw)
To: Tolga Ceylan
Cc: Benjamin Romer, David Kershner, Jes Sorensen, sparmaintainer,
devel, linux-kernel
On Fri, May 15, 2015 at 09:22:21PM -0700, Tolga Ceylan wrote:
> visorchipset_file_init() and visorchipset_file_cleanup() functions
> do not seem to be used from anywhere else and now are declared
> as static. Sparse emitted "not declared" warnings for these two
> functions.
>
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
> ---
> drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Doesn't apply to my tree :(
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-24 20:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-16 4:22 [PATCH 1/1] drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static Tolga Ceylan
2015-05-24 2:54 ` tolga ceylan
2015-05-24 14:30 ` Jes Sorensen
2015-05-24 20:32 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.