All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Adding support for directFB to mplayer2 recipe
@ 2015-05-27  7:41 Hector Roussille
  2015-05-27  7:52 ` Jussi Kukkonen
  0 siblings, 1 reply; 7+ messages in thread
From: Hector Roussille @ 2015-05-27  7:41 UTC (permalink / raw)
  To: openembedded-core

---
 meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
index 5b0e1de..b208144 100644
--- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
+++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
@@ -121,6 +121,7 @@ PACKAGECONFIG[postproc] = ",--disable-libpostproc,libpostproc"
 PACKAGECONFIG[vorbis] = ",--disable-libvorbis,libvorbis"
 PACKAGECONFIG[portaudio] = ",--disable-portaudio,portaudio-v19"
 PACKAGECONFIG[mpg123] = ",--disable-mpg123,mpg123"
+PACKAGECONFIG[directfb] = "--enable-directfb,--disable-directfb,directfb"
 
 FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math"
 BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}"
@@ -134,7 +135,7 @@ do_configure() {
     sed -i 's|/usr/\S*lib[\w/]*||g' ${S}/configure
     sed -i 's|_install_strip="-s"|_install_strip=""|g' ${S}/configure
     sed -i 's|HOST_CC|BUILD_CC|' ${S}/Makefile
-
+    sed -i 's|extra_cflags="-I. $extra_cflags"|extra_cflags="-I. -I${STAGING_INCDIR}/directfb $extra_cflags"|g' ${S}/configure
     export SIMPLE_TARGET_SYS="$(echo ${TARGET_SYS} | sed s:${TARGET_VENDOR}::g)"
     ./configure ${EXTRA_OECONF}
     
-- 
2.1.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] Adding support for directFB to mplayer2 recipe
  2015-05-27  7:41 Hector Roussille
@ 2015-05-27  7:52 ` Jussi Kukkonen
  0 siblings, 0 replies; 7+ messages in thread
From: Jussi Kukkonen @ 2015-05-27  7:52 UTC (permalink / raw)
  To: Hector Roussille; +Cc: Patches and discussions about the oe-core layer

Hi,

On 27 May 2015 at 10:41, Hector Roussille
<hroussille@adeneo-embedded.com> wrote:
> ---
>  meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 3 ++-

Please send patches against meta-oe to openembedded-devel list.

Jussi


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] Adding support for directFB to mplayer2 recipe
@ 2015-05-27  8:34 Hector Roussille
  2015-05-27 10:35 ` Martin Jansa
  0 siblings, 1 reply; 7+ messages in thread
From: Hector Roussille @ 2015-05-27  8:34 UTC (permalink / raw)
  To: openembedded-devel

---
 meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
index 5b0e1de..b208144 100644
--- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
+++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
@@ -121,6 +121,7 @@ PACKAGECONFIG[postproc] = ",--disable-libpostproc,libpostproc"
 PACKAGECONFIG[vorbis] = ",--disable-libvorbis,libvorbis"
 PACKAGECONFIG[portaudio] = ",--disable-portaudio,portaudio-v19"
 PACKAGECONFIG[mpg123] = ",--disable-mpg123,mpg123"
+PACKAGECONFIG[directfb] = "--enable-directfb,--disable-directfb,directfb"
 
 FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math"
 BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}"
@@ -134,7 +135,7 @@ do_configure() {
     sed -i 's|/usr/\S*lib[\w/]*||g' ${S}/configure
     sed -i 's|_install_strip="-s"|_install_strip=""|g' ${S}/configure
     sed -i 's|HOST_CC|BUILD_CC|' ${S}/Makefile
-
+    sed -i 's|extra_cflags="-I. $extra_cflags"|extra_cflags="-I. -I${STAGING_INCDIR}/directfb $extra_cflags"|g' ${S}/configure
     export SIMPLE_TARGET_SYS="$(echo ${TARGET_SYS} | sed s:${TARGET_VENDOR}::g)"
     ./configure ${EXTRA_OECONF}
     
-- 
2.1.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] Adding support for directFB to mplayer2 recipe
  2015-05-27  8:34 Hector Roussille
@ 2015-05-27 10:35 ` Martin Jansa
  0 siblings, 0 replies; 7+ messages in thread
From: Martin Jansa @ 2015-05-27 10:35 UTC (permalink / raw)
  To: openembedded-devel

On Wed, May 27, 2015 at 10:34:06AM +0200, Hector Roussille wrote:
> ---

I've fixed commit message format when cherry-picking to master-next, but
please confirm that it's OK to add you SOB line or re-send.

>  meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> index 5b0e1de..b208144 100644
> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> @@ -121,6 +121,7 @@ PACKAGECONFIG[postproc] = ",--disable-libpostproc,libpostproc"
>  PACKAGECONFIG[vorbis] = ",--disable-libvorbis,libvorbis"
>  PACKAGECONFIG[portaudio] = ",--disable-portaudio,portaudio-v19"
>  PACKAGECONFIG[mpg123] = ",--disable-mpg123,mpg123"
> +PACKAGECONFIG[directfb] = "--enable-directfb,--disable-directfb,directfb"
>  
>  FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math"
>  BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}"
> @@ -134,7 +135,7 @@ do_configure() {
>      sed -i 's|/usr/\S*lib[\w/]*||g' ${S}/configure
>      sed -i 's|_install_strip="-s"|_install_strip=""|g' ${S}/configure
>      sed -i 's|HOST_CC|BUILD_CC|' ${S}/Makefile
> -
> +    sed -i 's|extra_cflags="-I. $extra_cflags"|extra_cflags="-I. -I${STAGING_INCDIR}/directfb $extra_cflags"|g' ${S}/configure
>      export SIMPLE_TARGET_SYS="$(echo ${TARGET_SYS} | sed s:${TARGET_VENDOR}::g)"
>      ./configure ${EXTRA_OECONF}
>      
> -- 
> 2.1.0
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] Adding support for directFB to mplayer2 recipe
@ 2015-05-27 11:13 Hector Roussille
  2015-05-27 11:36 ` Gary Thomas
  0 siblings, 1 reply; 7+ messages in thread
From: Hector Roussille @ 2015-05-27 11:13 UTC (permalink / raw)
  To: openembedded-devel

Signed-off-by: Hector Roussille <hroussille@adeneo-embedded.com>
---
 meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
index 5b0e1de..b208144 100644
--- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
+++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
@@ -121,6 +121,7 @@ PACKAGECONFIG[postproc] = ",--disable-libpostproc,libpostproc"
 PACKAGECONFIG[vorbis] = ",--disable-libvorbis,libvorbis"
 PACKAGECONFIG[portaudio] = ",--disable-portaudio,portaudio-v19"
 PACKAGECONFIG[mpg123] = ",--disable-mpg123,mpg123"
+PACKAGECONFIG[directfb] = "--enable-directfb,--disable-directfb,directfb"
 
 FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math"
 BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}"
@@ -134,7 +135,7 @@ do_configure() {
     sed -i 's|/usr/\S*lib[\w/]*||g' ${S}/configure
     sed -i 's|_install_strip="-s"|_install_strip=""|g' ${S}/configure
     sed -i 's|HOST_CC|BUILD_CC|' ${S}/Makefile
-
+    sed -i 's|extra_cflags="-I. $extra_cflags"|extra_cflags="-I. -I${STAGING_INCDIR}/directfb $extra_cflags"|g' ${S}/configure
     export SIMPLE_TARGET_SYS="$(echo ${TARGET_SYS} | sed s:${TARGET_VENDOR}::g)"
     ./configure ${EXTRA_OECONF}
     
-- 
2.1.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] Adding support for directFB to mplayer2 recipe
  2015-05-27 11:13 [PATCH] Adding support for directFB to mplayer2 recipe Hector Roussille
@ 2015-05-27 11:36 ` Gary Thomas
  2015-05-27 11:41   ` ROUSSILLE Hector
  0 siblings, 1 reply; 7+ messages in thread
From: Gary Thomas @ 2015-05-27 11:36 UTC (permalink / raw)
  To: openembedded-devel

On 2015-05-27 05:13, Hector Roussille wrote:
> Signed-off-by: Hector Roussille <hroussille@adeneo-embedded.com>
> ---
>   meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> index 5b0e1de..b208144 100644
> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> @@ -121,6 +121,7 @@ PACKAGECONFIG[postproc] = ",--disable-libpostproc,libpostproc"
>   PACKAGECONFIG[vorbis] = ",--disable-libvorbis,libvorbis"
>   PACKAGECONFIG[portaudio] = ",--disable-portaudio,portaudio-v19"
>   PACKAGECONFIG[mpg123] = ",--disable-mpg123,mpg123"
> +PACKAGECONFIG[directfb] = "--enable-directfb,--disable-directfb,directfb"
>
>   FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math"
>   BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}"
> @@ -134,7 +135,7 @@ do_configure() {
>       sed -i 's|/usr/\S*lib[\w/]*||g' ${S}/configure
>       sed -i 's|_install_strip="-s"|_install_strip=""|g' ${S}/configure
>       sed -i 's|HOST_CC|BUILD_CC|' ${S}/Makefile
> -
> +    sed -i 's|extra_cflags="-I. $extra_cflags"|extra_cflags="-I. -I${STAGING_INCDIR}/directfb $extra_cflags"|g' ${S}/configure
>       export SIMPLE_TARGET_SYS="$(echo ${TARGET_SYS} | sed s:${TARGET_VENDOR}::g)"
>       ./configure ${EXTRA_OECONF}
>

Shouldn't this at least be conditional on directfb support in
DISTRO_FEATURES?  It won't do much good to enable it in this
recipe if the rest of the system isn't using directfb as well.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Adding support for directFB to mplayer2 recipe
  2015-05-27 11:36 ` Gary Thomas
@ 2015-05-27 11:41   ` ROUSSILLE Hector
  0 siblings, 0 replies; 7+ messages in thread
From: ROUSSILLE Hector @ 2015-05-27 11:41 UTC (permalink / raw)
  To: openembedded-devel

I Thought the PACKAGECONFIG option was enough, well that's the answer i had on the IRC 


De: "Gary Thomas" <gary@mlbassoc.com> 
À: openembedded-devel@lists.openembedded.org 
Envoyé: Mercredi 27 Mai 2015 13:36:35 
Objet: Re: [oe] [PATCH] Adding support for directFB to mplayer2 recipe 

On 2015-05-27 05:13, Hector Roussille wrote: 
> Signed-off-by: Hector Roussille <hroussille@adeneo-embedded.com> 
> --- 
> meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 3 ++- 
> 1 file changed, 2 insertions(+), 1 deletion(-) 
> 
> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb 
> index 5b0e1de..b208144 100644 
> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb 
> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb 
> @@ -121,6 +121,7 @@ PACKAGECONFIG[postproc] = ",--disable-libpostproc,libpostproc" 
> PACKAGECONFIG[vorbis] = ",--disable-libvorbis,libvorbis" 
> PACKAGECONFIG[portaudio] = ",--disable-portaudio,portaudio-v19" 
> PACKAGECONFIG[mpg123] = ",--disable-mpg123,mpg123" 
> +PACKAGECONFIG[directfb] = "--enable-directfb,--disable-directfb,directfb" 
> 
> FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math" 
> BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}" 
> @@ -134,7 +135,7 @@ do_configure() { 
> sed -i 's|/usr/\S*lib[\w/]*||g' ${S}/configure 
> sed -i 's|_install_strip="-s"|_install_strip=""|g' ${S}/configure 
> sed -i 's|HOST_CC|BUILD_CC|' ${S}/Makefile 
> - 
> + sed -i 's|extra_cflags="-I. $extra_cflags"|extra_cflags="-I. -I${STAGING_INCDIR}/directfb $extra_cflags"|g' ${S}/configure 
> export SIMPLE_TARGET_SYS="$(echo ${TARGET_SYS} | sed s:${TARGET_VENDOR}::g)" 
> ./configure ${EXTRA_OECONF} 
> 

Shouldn't this at least be conditional on directfb support in 
DISTRO_FEATURES? It won't do much good to enable it in this 
recipe if the rest of the system isn't using directfb as well. 

-- 
------------------------------------------------------------ 
Gary Thomas | Consulting for the 
MLB Associates | Embedded world 
------------------------------------------------------------ 
-- 
_______________________________________________ 
Openembedded-devel mailing list 
Openembedded-devel@lists.openembedded.org 
http://lists.openembedded.org/mailman/listinfo/openembedded-devel 


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2015-05-27 11:41 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-27 11:13 [PATCH] Adding support for directFB to mplayer2 recipe Hector Roussille
2015-05-27 11:36 ` Gary Thomas
2015-05-27 11:41   ` ROUSSILLE Hector
  -- strict thread matches above, loose matches on Subject: below --
2015-05-27  8:34 Hector Roussille
2015-05-27 10:35 ` Martin Jansa
2015-05-27  7:41 Hector Roussille
2015-05-27  7:52 ` Jussi Kukkonen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.