From: Julien Grall <julien.grall@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Chen Baozi <cbz@baozis.org>,
xen-devel@lists.xenproject.org
Cc: Chen Baozi <baozich@gmail.com>, Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH V4 7/8] xen/arm64: increase MAX_VIRT_CPUS to 128 on arm64
Date: Fri, 29 May 2015 17:45:08 +0100 [thread overview]
Message-ID: <55689794.9080000@citrix.com> (raw)
In-Reply-To: <556896CE.8050308@citrix.com>
On 29/05/15 17:41, Andrew Cooper wrote:
> On 29/05/15 17:20, Julien Grall wrote:
>> On 29/05/15 16:51, Julien Grall wrote:
>>>> diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h
>>>> index 3b23e05..817c216 100644
>>>> --- a/xen/include/asm-arm/config.h
>>>> +++ b/xen/include/asm-arm/config.h
>>>> @@ -47,7 +47,11 @@
>>>> #define NR_CPUS 128
>>>> #endif
>>>>
>>>> +#ifdef CONFIG_ARM_64
>>>> +#define MAX_VIRT_CPUS 128
>>>> +#else
>>>> #define MAX_VIRT_CPUS 8
>>>> +#endif
>> Looking to the last patch, the usage of MAX_VIRT_CPUS is now minimal.
>> Can't finish to replace MAX_VIRT_CPUS to another corresponding value and
>> drop the define?
>
> You cant drop MAX_VIRT_CPUS (I tried this when introducing
> max_domain_vcpus()). It is used for some conditional compilation in
> common code.
AFAICT only in the event channel code to avoid allocating memory when
less than 64 vCPU is used.
Anyway, if we can drop it. I would add a check in domain_max_vcpus for
safety.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-05-29 16:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 10:15 [PATCH V4 0/8] Support more than 8 vcpus on arm64 with GICv3 Chen Baozi
2015-05-28 10:15 ` [PATCH V4 1/8] xen/arm: gic-v3: Increase the size of GICR in address space for guest Chen Baozi
2015-05-28 10:15 ` [PATCH V4 2/8] xen/arm: Add functions of mapping between vCPUID and virtual affinity Chen Baozi
2015-05-29 14:27 ` Julien Grall
2015-05-28 10:15 ` [PATCH V4 3/8] xen/arm: Use the new functions for vCPUID/vaffinity transformation Chen Baozi
2015-05-29 14:34 ` Julien Grall
2015-05-28 10:15 ` [PATCH V4 4/8] xen/arm: Use cpumask_t type for vcpu_mask in vgic_to_sgi Chen Baozi
2015-05-29 15:20 ` Julien Grall
2015-05-28 10:15 ` [PATCH V4 5/8] tools/libxl: Set 'reg' of cpu node equal to MPIDR affinity for domU Chen Baozi
2015-05-29 15:44 ` Julien Grall
2015-05-29 15:55 ` Ian Campbell
2015-05-29 16:08 ` Julien Grall
2015-05-30 2:08 ` Chen Baozi
2015-05-30 2:27 ` Chen Baozi
2015-05-28 10:15 ` [PATCH V4 6/8] xen/arm: Set 'reg' of cpu node for dom0 to match MPIDR's affinity Chen Baozi
2015-05-29 15:49 ` Julien Grall
2015-05-30 2:10 ` Chen Baozi
2015-05-28 10:15 ` [PATCH V4 7/8] xen/arm64: increase MAX_VIRT_CPUS to 128 on arm64 Chen Baozi
2015-05-29 15:51 ` Julien Grall
2015-05-29 16:20 ` Julien Grall
2015-05-29 16:41 ` Andrew Cooper
2015-05-29 16:45 ` Julien Grall [this message]
2015-05-29 16:49 ` Andrew Cooper
2015-05-28 10:15 ` [PATCH V4 8/8] xen/arm: make domain_max_vcpus return value according to vGIC version Chen Baozi
2015-05-28 10:17 ` Andrew Cooper
2015-05-29 16:18 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55689794.9080000@citrix.com \
--to=julien.grall@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=baozich@gmail.com \
--cc=cbz@baozis.org \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.