* [Qemu-devel] [PATCH] translate-all: delete prototype for non-existent function
@ 2015-06-01 7:53 ` Paolo Bonzini
0 siblings, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2015-06-01 7:53 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
translate-all.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/translate-all.h b/translate-all.h
index ef9166c..0384640 100644
--- a/translate-all.h
+++ b/translate-all.h
@@ -24,7 +24,6 @@ void tb_invalidate_phys_page_fast(tb_page_addr_t start, int len);
void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end,
int is_cpu_write_access);
void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end);
-void cpu_unlink_tb(CPUState *cpu);
void tb_check_watchpoint(CPUState *cpu);
#ifdef CONFIG_USER_ONLY
--
2.4.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] translate-all: delete prototype for non-existent function
2015-06-01 7:53 ` [Qemu-devel] " Paolo Bonzini
@ 2015-06-01 17:01 ` Eric Blake
-1 siblings, 0 replies; 8+ messages in thread
From: Eric Blake @ 2015-06-01 17:01 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
On 06/01/2015 01:53 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Missed in commit 3a808cc40
> ---
> translate-all.h | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] translate-all: delete prototype for non-existent function
2015-06-01 7:53 ` [Qemu-devel] " Paolo Bonzini
@ 2015-06-01 18:38 ` Peter Crosthwaite
-1 siblings, 0 replies; 8+ messages in thread
From: Peter Crosthwaite @ 2015-06-01 18:38 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, qemu-devel@nongnu.org Developers
On Mon, Jun 1, 2015 at 12:53 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
[pcrost@xsjsorenbubuntu qemu-mainline]$ git grep cpu_unlink_tb
translate-all.h:24:void cpu_unlink_tb(CPUState *cpu);
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
> translate-all.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/translate-all.h b/translate-all.h
> index ef9166c..0384640 100644
> --- a/translate-all.h
> +++ b/translate-all.h
> @@ -24,7 +24,6 @@ void tb_invalidate_phys_page_fast(tb_page_addr_t start, int len);
> void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end,
> int is_cpu_write_access);
> void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end);
> -void cpu_unlink_tb(CPUState *cpu);
> void tb_check_watchpoint(CPUState *cpu);
>
> #ifdef CONFIG_USER_ONLY
> --
> 2.4.1
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] translate-all: delete prototype for non-existent function
@ 2015-06-01 18:38 ` Peter Crosthwaite
0 siblings, 0 replies; 8+ messages in thread
From: Peter Crosthwaite @ 2015-06-01 18:38 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, qemu-devel@nongnu.org Developers
On Mon, Jun 1, 2015 at 12:53 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
[pcrost@xsjsorenbubuntu qemu-mainline]$ git grep cpu_unlink_tb
translate-all.h:24:void cpu_unlink_tb(CPUState *cpu);
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
> translate-all.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/translate-all.h b/translate-all.h
> index ef9166c..0384640 100644
> --- a/translate-all.h
> +++ b/translate-all.h
> @@ -24,7 +24,6 @@ void tb_invalidate_phys_page_fast(tb_page_addr_t start, int len);
> void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end,
> int is_cpu_write_access);
> void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end);
> -void cpu_unlink_tb(CPUState *cpu);
> void tb_check_watchpoint(CPUState *cpu);
>
> #ifdef CONFIG_USER_ONLY
> --
> 2.4.1
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] translate-all: delete prototype for non-existent function
2015-06-01 7:53 ` [Qemu-devel] " Paolo Bonzini
@ 2015-06-02 5:38 ` Michael Tokarev
-1 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2015-06-02 5:38 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: qemu-trivial
01.06.2015 10:53, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> translate-all.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/translate-all.h b/translate-all.h
> index ef9166c..0384640 100644
> --- a/translate-all.h
> +++ b/translate-all.h
> @@ -24,7 +24,6 @@ void tb_invalidate_phys_page_fast(tb_page_addr_t start, int len);
> void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end,
> int is_cpu_write_access);
> void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end);
> -void cpu_unlink_tb(CPUState *cpu);
> void tb_check_watchpoint(CPUState *cpu);
>
> #ifdef CONFIG_USER_ONLY
Hmm. This does not apply due to context, my version of translate-all.h
is very short, without tb_invalidate_phys_page_range prototype and
without ifdef CONFIG_USER_ONLY, and after this prototype removal it
contains just 3 prototypes.
I reduced this to just the one-line removal and applied, and git pull
should do the right thing too.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] translate-all: delete prototype for non-existent function
@ 2015-06-02 5:38 ` Michael Tokarev
0 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2015-06-02 5:38 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: qemu-trivial
01.06.2015 10:53, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> translate-all.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/translate-all.h b/translate-all.h
> index ef9166c..0384640 100644
> --- a/translate-all.h
> +++ b/translate-all.h
> @@ -24,7 +24,6 @@ void tb_invalidate_phys_page_fast(tb_page_addr_t start, int len);
> void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end,
> int is_cpu_write_access);
> void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end);
> -void cpu_unlink_tb(CPUState *cpu);
> void tb_check_watchpoint(CPUState *cpu);
>
> #ifdef CONFIG_USER_ONLY
Hmm. This does not apply due to context, my version of translate-all.h
is very short, without tb_invalidate_phys_page_range prototype and
without ifdef CONFIG_USER_ONLY, and after this prototype removal it
contains just 3 prototypes.
I reduced this to just the one-line removal and applied, and git pull
should do the right thing too.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread