Re: [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]

On 06/01/2015 12:56 PM, Kirk Allan wrote:
> Test if –-extra-cflags is being used to include flags such as

Something in your workflow is substituting UTF-8 characters instead of
ASCII '-'.  s/–-/--/

> _WIN32_WINVER and WINVER to gain additional functionality offered
> by Windows Vista/2008 and newer.  If not, default WINVER to 0x501.
> 
> Add the iphlpapi library to use APIs such as GetAdaptersInfo and
> GetAdaptersAddresses.
> 
> Signed-off-by: Kirk Allan <kallan@suse.com>
> ---
>  configure | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 4e2f78a..67bd9af 100755
> --- a/configure
> +++ b/configure
> @@ -708,7 +708,12 @@ fi
>  if test "$mingw32" = "yes" ; then
>    EXESUF=".exe"
>    DSOSUF=".dll"
> -  QEMU_CFLAGS="-DWIN32_LEAN_AND_MEAN -DWINVER=0x501 $QEMU_CFLAGS"
> +  # --extra-cflags can be used to set flags such as -DWINVER and
> +  # -D_WIN32_WINNT.  If -DWINVER has not be set, default to XP (0x501).

s/be/been/

However, I'm not all that fluent in Windows compilation, so I'll let
others do the actual technical review.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]