Re: [Qemu-devel] [PATCH v4 2/2] qga: win32 implementation of qmp_guest_network_get_interfaces

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

On 06/01/2015 12:56 PM, Kirk Allan wrote:
> By default, IPv4 prefixes will be derived by matching the address
> to those returned by GetAdaptersInfo.  IPv6 prefixes can not be
> matched this way due to the unpredictable order of entries.
> 
> In Windows Vista/2008 guests and newer, both IPv4 and IPv6 prefixes
> can be retrieved from OnLinkPrefixLength.  Setting -–extra-cflags

s/-–/--/

> in the build configuration to ”- D_WIN32_WINNT-0x600 -DWINVER=0x600”

s/- D/-D/
and why the Unicode quotes? ASCII "" is good enough.

> or greater makes OnLinkPrefixLength available.  Setting –-ectra-cflags

s/–-ectra/--extra/

> is not required and if not set, the default approach to get the prefix
> will be taken.
> 
> Signed-off-by: Kirk Allan <kallan@suse.com>
> ---
>  qga/commands-win32.c | 220 ++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 217 insertions(+), 3 deletions(-)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]