From: Paolo Bonzini <pbonzini@redhat.com>
To: Kirk Allan <kallan@suse.com>, qemu-devel@nongnu.org
Cc: okrishtal@parallels.com, alex.bennee@linaro.org,
mdroth@linux.vnet.ibm.com, sw@weilnetz.de
Subject: Re: [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries
Date: Tue, 02 Jun 2015 21:41:03 +0200 [thread overview]
Message-ID: <556E06CF.6040903@redhat.com> (raw)
In-Reply-To: <556D77CC020000760012FDBB@prv-mh.provo.novell.com>
On 02/06/2015 17:30, Kirk Allan wrote:
> I was assuming that if you set _WIN32_WINNT=0x0600 (needed to gain
> access to the OnLinkPrefixLength field when running on Windows
> Vista/2008 and greater) you would also want to set WINVER=0x600 to
> match. Having WINVER in the flags as both 501 and 600 causes
> configure errors.
Hmm, right. It gives a "redefined" warning as if you had #define. And
the warning is fatal. So
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
> Testing with _WIN32_WINNT=0x0600 and WINVER=0x501 seems to be ok.
next prev parent reply other threads:[~2015-06-02 19:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 18:56 [Qemu-devel] [PATCH v4 0/2] qga: qmp_guest_network_get_interfaces for win32 Kirk Allan
2015-06-01 18:56 ` [Qemu-devel] [PATCH v4 1/2] qga: add additional win32 cflags and libraries Kirk Allan
2015-06-01 19:00 ` Eric Blake
2015-06-01 20:24 ` Paolo Bonzini
2015-06-01 21:19 ` Kirk Allan
2015-06-02 14:08 ` Paolo Bonzini
2015-06-02 15:30 ` Kirk Allan
2015-06-02 19:41 ` Paolo Bonzini [this message]
2015-06-01 18:56 ` [Qemu-devel] [PATCH v4 2/2] qga: win32 implementation of qmp_guest_network_get_interfaces Kirk Allan
2015-06-01 19:02 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556E06CF.6040903@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=kallan@suse.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=okrishtal@parallels.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.