[PATCH][meta-oe] php: add a vardeps for configure on sysconfdir

[PATCH][meta-oe] php: add a vardeps for configure on sysconfdir

[rongqing.li]

From: Roy Li <rongqing.li@windriver.com>

building php will fail when sstatus is used, since some hardcode paths
in php-native will make the wrong path, and try to fix it like below:
    do_install_append_virtclass-native() {
           create_wrapper ${D}${bindir}/php \
               PHP_PEAR_SYSCONF_DIR=${sysconfdir}/ \
    }
but php-native does not work for a 64bit target(qemuarm64) and if sstat is
from a 32bit(qemuppc) on the host same machine.

Consider no too much package depends on php-native, so add a vardeps for
configure on sysconfdir to force php-native to build always.

Signed-off-by: Roy Li <rongqing.li@windriver.com>
---
 meta-oe/recipes-devtools/php/php_5.5.24.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta-oe/recipes-devtools/php/php_5.5.24.bb b/meta-oe/recipes-devtools/php/php_5.5.24.bb
index 3e656af..9c0dd7f 100644
--- a/meta-oe/recipes-devtools/php/php_5.5.24.bb
+++ b/meta-oe/recipes-devtools/php/php_5.5.24.bb
@@ -106,6 +106,8 @@ EXTRA_OEMAKE = "INSTALL_ROOT=${D}"
 
 acpaths = ""
 
+do_configure[vardeps] += "${sysconfdir}"
+
 do_configure_prepend () {
     rm -f ${S}/build/libtool.m4 ${S}/ltmain.sh ${S}/aclocal.m4
     find ${S} -name config.m4 | xargs -n1 sed -i 's!APXS_HTTPD=.*!APXS_HTTPD=${STAGING_BINDIR_NATIVE}/httpd!'
-- 
1.9.1

Re: [PATCH][meta-oe] php: add a vardeps for configure on sysconfdir

[Martin Jansa]

On Wed, Jun 03, 2015 at 05:39:36PM +0800, rongqing.li@windriver.com wrote:
> From: Roy Li <rongqing.li@windriver.com>
> 
> building php will fail when sstatus is used, since some hardcode paths

what's sstatus? did you mean sstate?

> in php-native will make the wrong path, and try to fix it like below:
>     do_install_append_virtclass-native() {
>            create_wrapper ${D}${bindir}/php \
>                PHP_PEAR_SYSCONF_DIR=${sysconfdir}/ \
>     }
> but php-native does not work for a 64bit target(qemuarm64) and if sstat is
> from a 32bit(qemuppc) on the host same machine.
> 
> Consider no too much package depends on php-native, so add a vardeps for
> configure on sysconfdir to force php-native to build always.

Please improve the commit message, from this I'm still not sure what
this is supposed to fix.

> 
> Signed-off-by: Roy Li <rongqing.li@windriver.com>
> ---
>  meta-oe/recipes-devtools/php/php_5.5.24.bb | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta-oe/recipes-devtools/php/php_5.5.24.bb b/meta-oe/recipes-devtools/php/php_5.5.24.bb
> index 3e656af..9c0dd7f 100644
> --- a/meta-oe/recipes-devtools/php/php_5.5.24.bb
> +++ b/meta-oe/recipes-devtools/php/php_5.5.24.bb
> @@ -106,6 +106,8 @@ EXTRA_OEMAKE = "INSTALL_ROOT=${D}"
>  
>  acpaths = ""
>  
> +do_configure[vardeps] += "${sysconfdir}"
> +
>  do_configure_prepend () {
>      rm -f ${S}/build/libtool.m4 ${S}/ltmain.sh ${S}/aclocal.m4
>      find ${S} -name config.m4 | xargs -n1 sed -i 's!APXS_HTTPD=.*!APXS_HTTPD=${STAGING_BINDIR_NATIVE}/httpd!'
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

Re: [PATCH][meta-oe] php: add a vardeps for configure on sysconfdir

[Rongqing Li]

On 2015年06月03日 18:11, Martin Jansa wrote:
> On Wed, Jun 03, 2015 at 05:39:36PM +0800, rongqing.li@windriver.com wrote:
>> From: Roy Li <rongqing.li@windriver.com>
>>
>> building php will fail when sstatus is used, since some hardcode paths
>
> what's sstatus? did you mean sstate?
>
>> in php-native will make the wrong path, and try to fix it like below:
>>      do_install_append_virtclass-native() {
>>             create_wrapper ${D}${bindir}/php \
>>                 PHP_PEAR_SYSCONF_DIR=${sysconfdir}/ \
>>      }
>> but php-native does not work for a 64bit target(qemuarm64) and if sstat is
>> from a 32bit(qemuppc) on the host same machine.
>>
>> Consider no too much package depends on php-native, so add a vardeps for
>> configure on sysconfdir to force php-native to build always.
>
> Please improve the commit message, from this I'm still not sure what
> this is supposed to fix.
>

Ok, I will resend it, if the new commit log is not clear,
I think you can build two project with same sstate.

Thanks


-Roy


>>
>> Signed-off-by: Roy Li <rongqing.li@windriver.com>
>> ---
>>   meta-oe/recipes-devtools/php/php_5.5.24.bb | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta-oe/recipes-devtools/php/php_5.5.24.bb b/meta-oe/recipes-devtools/php/php_5.5.24.bb
>> index 3e656af..9c0dd7f 100644
>> --- a/meta-oe/recipes-devtools/php/php_5.5.24.bb
>> +++ b/meta-oe/recipes-devtools/php/php_5.5.24.bb
>> @@ -106,6 +106,8 @@ EXTRA_OEMAKE = "INSTALL_ROOT=${D}"
>>
>>   acpaths = ""
>>
>> +do_configure[vardeps] += "${sysconfdir}"
>> +
>>   do_configure_prepend () {
>>       rm -f ${S}/build/libtool.m4 ${S}/ltmain.sh ${S}/aclocal.m4
>>       find ${S} -name config.m4 | xargs -n1 sed -i 's!APXS_HTTPD=.*!APXS_HTTPD=${STAGING_BINDIR_NATIVE}/httpd!'
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

-- 
Best Reagrds,
Roy | RongQing Li