[PATCH wpan-tools] interface: fix interface type info

[PATCH wpan-tools] interface: fix interface type info

[Varka Bhadram]

Signed-off-by: Varka Bhadram <varkab@cdac.in>
---
 src/interface.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/interface.c b/src/interface.c
index e501763..1c59876 100644
--- a/src/interface.c
+++ b/src/interface.c
@@ -28,7 +28,7 @@ const char *iftype_name(enum nl802154_iftype iftype)
 	case NL802154_IFTYPE_COORD:
 		return "coordinator";
 	default:
-		sprintf(modebuf, "Unknown mode (%d)", iftype);
+		sprintf(modebuf, "Invalid iftype (%d)", iftype);
 		return modebuf;
 	}
 }
-- 
1.7.9.5

Re: [PATCH wpan-tools] interface: fix interface type info

[Alexander Aring]

On Wed, Jun 03, 2015 at 11:21:38AM +0530, Varka Bhadram wrote:
> 
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
> ---
>  src/interface.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/interface.c b/src/interface.c
> index e501763..1c59876 100644
> --- a/src/interface.c
> +++ b/src/interface.c
> @@ -28,7 +28,7 @@ const char *iftype_name(enum nl802154_iftype iftype)
>  	case NL802154_IFTYPE_COORD:
>  		return "coordinator";
>  	default:
> -		sprintf(modebuf, "Unknown mode (%d)", iftype);
> +		sprintf(modebuf, "Invalid iftype (%d)", iftype);
>  		return modebuf;

This error message is like iw tool. I don't know how we strict we should
make the behaviour like wireless here. I think it's okay to change that.

But note there is also a "modebuf" and you changed "Unknown mode ..." to
"Unknown iftype..." if you want to change it then I would assume to make
everything to "iftypeFOOBAR". I mean change "modebuf" to "iftypebuf" or
something else.

I can understand "Unknown mode" is confusing. But to handle now "iftypeFOO"
and "modeFOO" is more confusing than before.

- Alex

Re: [PATCH wpan-tools] interface: fix interface type info

[Varka Bhadram]

On 06/04/2015 12:34 PM, Alexander Aring wrote:
> On Wed, Jun 03, 2015 at 11:21:38AM +0530, Varka Bhadram wrote:
>> Signed-off-by: Varka Bhadram <varkab@cdac.in>
>> ---
>>   src/interface.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/interface.c b/src/interface.c
>> index e501763..1c59876 100644
>> --- a/src/interface.c
>> +++ b/src/interface.c
>> @@ -28,7 +28,7 @@ const char *iftype_name(enum nl802154_iftype iftype)
>>   	case NL802154_IFTYPE_COORD:
>>   		return "coordinator";
>>   	default:
>> -		sprintf(modebuf, "Unknown mode (%d)", iftype);
>> +		sprintf(modebuf, "Invalid iftype (%d)", iftype);
>>   		return modebuf;
> This error message is like iw tool. I don't know how we strict we should
> make the behaviour like wireless here. I think it's okay to change that.
>
> But note there is also a "modebuf" and you changed "Unknown mode ..." to
> "Unknown iftype..." if you want to change it then I would assume to make
> everything to "iftypeFOOBAR". I mean change "modebuf" to "iftypebuf" or
> something else.

Yes. Agree with you. This leads to a confusion.

I will change to *iftypebuf*. V2 is on the way.

Thanks

> I can understand "Unknown mode" is confusing. But to handle now "iftypeFOO"
> and "modeFOO" is more confusing than before.
>
> - Alex

-- 
Varka Bhadram


-------------------------------------------------------------------------------------------------------------------------------
[ C-DAC is on Social-Media too. Kindly follow us at:
Facebook: https://www.facebook.com/CDACINDIA & Twitter: @cdacindia ]

This e-mail is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. If you are not the
intended recipient, please contact the sender by reply e-mail and destroy
all copies and the original message. Any unauthorized review, use,
disclosure, dissemination, forwarding, printing or copying of this email
is strictly prohibited and appropriate legal action will be taken.
-------------------------------------------------------------------------------------------------------------------------------