From: Rajendra Nayak <rnayak@codeaurora.org>
To: Kevin Hilman <khilman@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
sboyd@codeaurora.org, srinivas.kandagatla@linaro.org,
nrajan@codeaurora.org, lina.iyer@linaro.org
Subject: Re: [RFC 1/7] thermal: qcom: tsens: Add a skeletal tsens drivers
Date: Mon, 08 Jun 2015 09:32:38 +0530 [thread overview]
Message-ID: <557513DE.2050505@codeaurora.org> (raw)
In-Reply-To: <7hpp59zpfv.fsf@deeprootsystems.com>
Hi Kevin,
>
> I was trying this series on linux-next with Srini's eeprom v4 and my
> first attempt was to build the eeprom, qfprom and tsens drivers as
> built-in. Unfortunately, the tsens driver probed before the
> eeprom/qfprom driver so failed here with the "calibration failed"
> message.
>
> Building things as modules worked better, but you might want to take a
> look at possibly using -EPROBE_DEFER here?
The driver does return -EPROBE_DEFER in case the calibration fails
when tsens is probed before qfprom. It does however also show the
error message "calibration failed" which is a little misleading and
needs fixing. What target were you trying this on? I will give it a
try again to make sure things work.
regards,
Rajendra
WARNING: multiple messages have this Message-ID (diff)
From: rnayak@codeaurora.org (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 1/7] thermal: qcom: tsens: Add a skeletal tsens drivers
Date: Mon, 08 Jun 2015 09:32:38 +0530 [thread overview]
Message-ID: <557513DE.2050505@codeaurora.org> (raw)
In-Reply-To: <7hpp59zpfv.fsf@deeprootsystems.com>
Hi Kevin,
>
> I was trying this series on linux-next with Srini's eeprom v4 and my
> first attempt was to build the eeprom, qfprom and tsens drivers as
> built-in. Unfortunately, the tsens driver probed before the
> eeprom/qfprom driver so failed here with the "calibration failed"
> message.
>
> Building things as modules worked better, but you might want to take a
> look at possibly using -EPROBE_DEFER here?
The driver does return -EPROBE_DEFER in case the calibration fails
when tsens is probed before qfprom. It does however also show the
error message "calibration failed" which is a little misleading and
needs fixing. What target were you trying this on? I will give it a
try again to make sure things work.
regards,
Rajendra
next prev parent reply other threads:[~2015-06-08 4:02 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 13:46 [RFC 0/7] qcom: Add support for tsens driver Rajendra Nayak
2015-04-23 13:46 ` Rajendra Nayak
2015-04-23 13:46 ` [RFC 1/7] thermal: qcom: tsens: Add a skeletal tsens drivers Rajendra Nayak
2015-04-23 13:46 ` Rajendra Nayak
2015-06-05 23:49 ` Kevin Hilman
2015-06-05 23:49 ` Kevin Hilman
2015-06-08 4:02 ` Rajendra Nayak [this message]
2015-06-08 4:02 ` Rajendra Nayak
2015-06-12 16:03 ` Lina Iyer
2015-06-12 16:03 ` Lina Iyer
2015-06-15 3:01 ` Rajendra Nayak
2015-06-15 3:01 ` Rajendra Nayak
2015-04-23 13:46 ` [RFC 2/7] thermal: qcom: tsens-8916: Add support for 8916 family of SoCs Rajendra Nayak
2015-04-23 13:46 ` Rajendra Nayak
2015-04-23 13:46 ` [RFC 3/7] thermal: qcom: tsens-8974: Add support for 8974 " Rajendra Nayak
2015-04-23 13:46 ` Rajendra Nayak
2015-04-23 13:46 ` [RFC 4/7] thermal: qcom: tsens-8960: Add support for 8960 " Rajendra Nayak
2015-04-23 13:46 ` Rajendra Nayak
2015-04-23 13:46 ` [RFC 5/7] arm: dts: msm8974: Add thermal zones, tsens and eeprom nodes Rajendra Nayak
2015-04-23 13:46 ` Rajendra Nayak
2015-04-23 16:51 ` Lina Iyer
2015-04-23 16:51 ` Lina Iyer
2015-04-24 2:49 ` Rajendra Nayak
2015-04-24 2:49 ` Rajendra Nayak
2015-04-23 13:46 ` [RFC 6/7] clk: qcom: gcc-msm8960: add child devices support Rajendra Nayak
2015-04-23 13:46 ` Rajendra Nayak
2015-04-23 13:46 ` [RFC 7/7] arm: dts: apq8064: Add thermal zones, tsens and eeprom nodes Rajendra Nayak
2015-04-23 13:46 ` Rajendra Nayak
2015-04-23 16:52 ` [RFC 0/7] qcom: Add support for tsens driver Lina Iyer
2015-04-23 16:52 ` Lina Iyer
2015-06-06 0:25 ` Kevin Hilman
2015-06-06 0:25 ` Kevin Hilman
2015-06-08 4:29 ` Rajendra Nayak
2015-06-08 4:29 ` Rajendra Nayak
2015-06-08 16:05 ` Kevin Hilman
2015-06-08 16:05 ` Kevin Hilman
2015-06-09 5:15 ` Rajendra Nayak
2015-06-09 5:15 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557513DE.2050505@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=khilman@kernel.org \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nrajan@codeaurora.org \
--cc=sboyd@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.