All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@kernel.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	sboyd@codeaurora.org, srinivas.kandagatla@linaro.org,
	nrajan@codeaurora.org, lina.iyer@linaro.org, javi.merino@arm.com,
	punit.agrawal@arm.com
Subject: Re: [RFC 0/7] qcom: Add support for tsens driver
Date: Fri, 05 Jun 2015 17:25:19 -0700	[thread overview]
Message-ID: <7hvbf1y974.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1429796773-7151-1-git-send-email-rnayak@codeaurora.org> (Rajendra Nayak's message of "Thu, 23 Apr 2015 19:16:06 +0530")

[+ Javi, Punit for power_allocator questions ]

Hi Rajendra,

Rajendra Nayak <rnayak@codeaurora.org> writes:

> This is an attempt to have a single tsens driver for
> the different versions of the tsens IP that exist, on
> different qcom msm/apq SoCs.
> Support is added for msm8916, msm8960 and msm8974 families.
> Based on top of the latest eeprom framework patches [1]

Curious how are you testing this?  with which thermal governor?

I'm experimenting with the new thermal power_allocator governor
currently in linux-next, and was hoping to use this to test it, but I'm
noticing it doesn't work with the power_allocator governor.

The first thing is that the power_allator goveror expects each thermal
zone to have a sustainable-power property in the DT, which this series
doesn't provide.  Hacking some dummy values in there to see what happens
next, I then hit the "thermal zone cpu-thermal0 has wrong trip setup for
power allocator" error from the power_allocator driver.

I stopped there as that made it clear this isn't yet ready to be used
with the power_allocator governor.

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@kernel.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 0/7] qcom: Add support for tsens driver
Date: Fri, 05 Jun 2015 17:25:19 -0700	[thread overview]
Message-ID: <7hvbf1y974.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1429796773-7151-1-git-send-email-rnayak@codeaurora.org> (Rajendra Nayak's message of "Thu, 23 Apr 2015 19:16:06 +0530")

[+ Javi, Punit for power_allocator questions ]

Hi Rajendra,

Rajendra Nayak <rnayak@codeaurora.org> writes:

> This is an attempt to have a single tsens driver for
> the different versions of the tsens IP that exist, on
> different qcom msm/apq SoCs.
> Support is added for msm8916, msm8960 and msm8974 families.
> Based on top of the latest eeprom framework patches [1]

Curious how are you testing this?  with which thermal governor?

I'm experimenting with the new thermal power_allocator governor
currently in linux-next, and was hoping to use this to test it, but I'm
noticing it doesn't work with the power_allocator governor.

The first thing is that the power_allator goveror expects each thermal
zone to have a sustainable-power property in the DT, which this series
doesn't provide.  Hacking some dummy values in there to see what happens
next, I then hit the "thermal zone cpu-thermal0 has wrong trip setup for
power allocator" error from the power_allocator driver.

I stopped there as that made it clear this isn't yet ready to be used
with the power_allocator governor.

Kevin

  parent reply	other threads:[~2015-06-06  0:25 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23 13:46 [RFC 0/7] qcom: Add support for tsens driver Rajendra Nayak
2015-04-23 13:46 ` Rajendra Nayak
2015-04-23 13:46 ` [RFC 1/7] thermal: qcom: tsens: Add a skeletal tsens drivers Rajendra Nayak
2015-04-23 13:46   ` Rajendra Nayak
2015-06-05 23:49   ` Kevin Hilman
2015-06-05 23:49     ` Kevin Hilman
2015-06-08  4:02     ` Rajendra Nayak
2015-06-08  4:02       ` Rajendra Nayak
2015-06-12 16:03   ` Lina Iyer
2015-06-12 16:03     ` Lina Iyer
2015-06-15  3:01     ` Rajendra Nayak
2015-06-15  3:01       ` Rajendra Nayak
2015-04-23 13:46 ` [RFC 2/7] thermal: qcom: tsens-8916: Add support for 8916 family of SoCs Rajendra Nayak
2015-04-23 13:46   ` Rajendra Nayak
2015-04-23 13:46 ` [RFC 3/7] thermal: qcom: tsens-8974: Add support for 8974 " Rajendra Nayak
2015-04-23 13:46   ` Rajendra Nayak
2015-04-23 13:46 ` [RFC 4/7] thermal: qcom: tsens-8960: Add support for 8960 " Rajendra Nayak
2015-04-23 13:46   ` Rajendra Nayak
2015-04-23 13:46 ` [RFC 5/7] arm: dts: msm8974: Add thermal zones, tsens and eeprom nodes Rajendra Nayak
2015-04-23 13:46   ` Rajendra Nayak
2015-04-23 16:51   ` Lina Iyer
2015-04-23 16:51     ` Lina Iyer
2015-04-24  2:49     ` Rajendra Nayak
2015-04-24  2:49       ` Rajendra Nayak
2015-04-23 13:46 ` [RFC 6/7] clk: qcom: gcc-msm8960: add child devices support Rajendra Nayak
2015-04-23 13:46   ` Rajendra Nayak
2015-04-23 13:46 ` [RFC 7/7] arm: dts: apq8064: Add thermal zones, tsens and eeprom nodes Rajendra Nayak
2015-04-23 13:46   ` Rajendra Nayak
2015-04-23 16:52 ` [RFC 0/7] qcom: Add support for tsens driver Lina Iyer
2015-04-23 16:52   ` Lina Iyer
2015-06-06  0:25 ` Kevin Hilman [this message]
2015-06-06  0:25   ` Kevin Hilman
2015-06-08  4:29   ` Rajendra Nayak
2015-06-08  4:29     ` Rajendra Nayak
2015-06-08 16:05     ` Kevin Hilman
2015-06-08 16:05       ` Kevin Hilman
2015-06-09  5:15       ` Rajendra Nayak
2015-06-09  5:15         ` Rajendra Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hvbf1y974.fsf@deeprootsystems.com \
    --to=khilman@kernel.org \
    --cc=javi.merino@arm.com \
    --cc=lina.iyer@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nrajan@codeaurora.org \
    --cc=punit.agrawal@arm.com \
    --cc=rnayak@codeaurora.org \
    --cc=sboyd@codeaurora.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.