Re: [PATCH 6/6] AMD-PVH: enable pvh if requirements met

[Boris Ostrovsky <boris.ostrovsky@oracle.com>]

On 06/23/2015 08:30 AM, Jan Beulich wrote:
>>>> On 22.06.15 at 18:37, <elena.ufimtseva@oracle.com> wrote:
>> --- a/xen/arch/x86/hvm/svm/svm.c
>> +++ b/xen/arch/x86/hvm/svm/svm.c
>> @@ -1444,6 +1444,9 @@ const struct hvm_function_table * __init
>> start_svm(void)
>>       svm_function_table.hap_capabilities = HVM_HAP_SUPERPAGE_2MB |
>>           ((cpuid_edx(0x80000001) & 0x04000000) ? HVM_HAP_SUPERPAGE_1GB : 0);
>>   
>> +    if ( cpu_has_svm_npt  && cpu_has_svm_decode )
>> +        svm_function_table.pvh_supported = 1;
> If svm_decode indeed is a prereq, then the earlier patch dealing
> with the handle_mmio() invocations doesn't need to fiddle with
> VMEXIT_INVLPG other than to maybe add a documenting ASSERT().
>

I am not sure we should require decode feature to be required for PVH 
support. I can't remember exactly but I think this feature was first 
introduced in family 15h so requiring it will leave at least family 10h 
processors as not supporting PVH.

-boris