All of lore.kernel.org
 help / color / mirror / Atom feed
From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH-v4 3/3] mfd: devicetree: bindings: Add new 88pm800 mfd binding
Date: Thu, 25 Jun 2015 16:52:14 +0530	[thread overview]
Message-ID: <558BE466.3090408@linaro.org> (raw)
In-Reply-To: <20150625102823.GD15013@x1>



On Thursday 25 June 2015 03:58 PM, Lee Jones wrote:
> On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
>
>> With addition of DT support to 88pm800 mfd driver, this patch
>> adds new DT binding documentation along with respective properties.
>>
>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
>> ---
>>   Documentation/devicetree/bindings/mfd/88pm800.txt | 54 +++++++++++++++++++++++
>>   1 file changed, 54 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt
>> new file mode 100644
>> index 0000000..f56b751
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt
>> @@ -0,0 +1,54 @@
>> +* Marvell 88PM8xx Power Management IC
>> +
>> +Required parent device properties:
>> +- compatible : "marvell,88pm800", "marvell,88pm805", "marvell,88pm860"
>> +- reg : the I2C slave address for the 88pm8xx chip
>> +- interrupts : IRQ line for the 88pm8xx chip
>> +- interrupt-controller: describes the 88pm8xx as an interrupt controller
>> +- #interrupt-cells : should be 1.
>> +		- The cell is the 88pm8xx local IRQ number
>
> Might just be a personal thing, but I would line up the ':', it's much
> easier on the eyes that way.

Ok,

>
>> +88pm8xx family of devices consists of varied group of sub-devices:
>> +
>> +Device		 	Supply Names	 Description
>> +------		 	------------	 -----------
>> +88pm80x-onkey		:		: On key
>> +88pm80x-rtc		:		: RTC
>> +88pm80x-regulator	:		: Regulators
>> +
>> +Note: More device list will follow
>
> No real need for this.
>

I deliberately added it, as I was sure i would get comment if I only
put e devices in the list. And guess what, as expected I got comment.

Anyway, I agree and Will remove it.

Thanks,
Vaibhav

WARNING: multiple messages have this Message-ID (diff)
From: Vaibhav Hiremath <vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	yizhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH-v4 3/3] mfd: devicetree: bindings: Add new 88pm800 mfd binding
Date: Thu, 25 Jun 2015 16:52:14 +0530	[thread overview]
Message-ID: <558BE466.3090408@linaro.org> (raw)
In-Reply-To: <20150625102823.GD15013@x1>



On Thursday 25 June 2015 03:58 PM, Lee Jones wrote:
> On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
>
>> With addition of DT support to 88pm800 mfd driver, this patch
>> adds new DT binding documentation along with respective properties.
>>
>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>>   Documentation/devicetree/bindings/mfd/88pm800.txt | 54 +++++++++++++++++++++++
>>   1 file changed, 54 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt
>> new file mode 100644
>> index 0000000..f56b751
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt
>> @@ -0,0 +1,54 @@
>> +* Marvell 88PM8xx Power Management IC
>> +
>> +Required parent device properties:
>> +- compatible : "marvell,88pm800", "marvell,88pm805", "marvell,88pm860"
>> +- reg : the I2C slave address for the 88pm8xx chip
>> +- interrupts : IRQ line for the 88pm8xx chip
>> +- interrupt-controller: describes the 88pm8xx as an interrupt controller
>> +- #interrupt-cells : should be 1.
>> +		- The cell is the 88pm8xx local IRQ number
>
> Might just be a personal thing, but I would line up the ':', it's much
> easier on the eyes that way.

Ok,

>
>> +88pm8xx family of devices consists of varied group of sub-devices:
>> +
>> +Device		 	Supply Names	 Description
>> +------		 	------------	 -----------
>> +88pm80x-onkey		:		: On key
>> +88pm80x-rtc		:		: RTC
>> +88pm80x-regulator	:		: Regulators
>> +
>> +Note: More device list will follow
>
> No real need for this.
>

I deliberately added it, as I was sure i would get comment if I only
put e devices in the list. And guess what, as expected I got comment.

Anyway, I agree and Will remove it.

Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	yizhang@marvell.com
Subject: Re: [PATCH-v4 3/3] mfd: devicetree: bindings: Add new 88pm800 mfd binding
Date: Thu, 25 Jun 2015 16:52:14 +0530	[thread overview]
Message-ID: <558BE466.3090408@linaro.org> (raw)
In-Reply-To: <20150625102823.GD15013@x1>



On Thursday 25 June 2015 03:58 PM, Lee Jones wrote:
> On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
>
>> With addition of DT support to 88pm800 mfd driver, this patch
>> adds new DT binding documentation along with respective properties.
>>
>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
>> ---
>>   Documentation/devicetree/bindings/mfd/88pm800.txt | 54 +++++++++++++++++++++++
>>   1 file changed, 54 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt
>> new file mode 100644
>> index 0000000..f56b751
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt
>> @@ -0,0 +1,54 @@
>> +* Marvell 88PM8xx Power Management IC
>> +
>> +Required parent device properties:
>> +- compatible : "marvell,88pm800", "marvell,88pm805", "marvell,88pm860"
>> +- reg : the I2C slave address for the 88pm8xx chip
>> +- interrupts : IRQ line for the 88pm8xx chip
>> +- interrupt-controller: describes the 88pm8xx as an interrupt controller
>> +- #interrupt-cells : should be 1.
>> +		- The cell is the 88pm8xx local IRQ number
>
> Might just be a personal thing, but I would line up the ':', it's much
> easier on the eyes that way.

Ok,

>
>> +88pm8xx family of devices consists of varied group of sub-devices:
>> +
>> +Device		 	Supply Names	 Description
>> +------		 	------------	 -----------
>> +88pm80x-onkey		:		: On key
>> +88pm80x-rtc		:		: RTC
>> +88pm80x-regulator	:		: Regulators
>> +
>> +Note: More device list will follow
>
> No real need for this.
>

I deliberately added it, as I was sure i would get comment if I only
put e devices in the list. And guess what, as expected I got comment.

Anyway, I agree and Will remove it.

Thanks,
Vaibhav

  reply	other threads:[~2015-06-25 11:22 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25  7:26 [PATCH-v4 0/3] mfd: 88pm800: Add Device tree support Vaibhav Hiremath
2015-06-25  7:26 ` Vaibhav Hiremath
2015-06-25  7:26 ` Vaibhav Hiremath
2015-06-25  7:26 ` [PATCH-v4 1/3] mfd: 88pm800: Add device " Vaibhav Hiremath
2015-06-25  7:26   ` Vaibhav Hiremath
2015-06-25 10:19   ` Lee Jones
2015-06-25 10:19     ` Lee Jones
2015-06-25 10:19     ` Lee Jones
2015-06-25 11:10     ` Vaibhav Hiremath
2015-06-25 11:10       ` Vaibhav Hiremath
2015-06-25 11:10       ` Vaibhav Hiremath
2015-06-25 14:48       ` Lee Jones
2015-06-25 14:48         ` Lee Jones
2015-06-25 14:48         ` Lee Jones
2015-06-25 15:27         ` Vaibhav Hiremath
2015-06-25 15:27           ` Vaibhav Hiremath
2015-06-26  5:53           ` Yi Zhang
2015-06-26  5:53             ` Yi Zhang
2015-06-26  5:53             ` Yi Zhang
2015-06-26  5:59             ` Vaibhav Hiremath
2015-06-26  5:59               ` Vaibhav Hiremath
2015-06-26  6:35               ` Krzysztof Kozlowski
2015-06-26  6:35                 ` Krzysztof Kozlowski
2015-06-26  6:35                 ` Krzysztof Kozlowski
2015-06-26  7:41               ` Yi Zhang
2015-06-26  7:41                 ` Yi Zhang
2015-06-26  7:41                 ` Yi Zhang
2015-06-25  7:26 ` [PATCH-v4 2/3] mfd: 88pm800: Set default interrupt clear method Vaibhav Hiremath
2015-06-25  7:26   ` Vaibhav Hiremath
2015-06-25 10:26   ` Lee Jones
2015-06-25 10:26     ` Lee Jones
2015-06-25 10:26     ` Lee Jones
2015-06-25 11:19     ` Vaibhav Hiremath
2015-06-25 11:19       ` Vaibhav Hiremath
2015-06-25 11:19       ` Vaibhav Hiremath
2015-06-25 11:45       ` Krzysztof Kozlowski
2015-06-25 11:45         ` Krzysztof Kozlowski
2015-06-25 11:45         ` Krzysztof Kozlowski
2015-06-25 12:36         ` Vaibhav Hiremath
2015-06-25 12:36           ` Vaibhav Hiremath
2015-06-25 12:36           ` Vaibhav Hiremath
2015-06-25 14:46       ` Lee Jones
2015-06-25 14:46         ` Lee Jones
2015-06-25 15:31         ` Vaibhav Hiremath
2015-06-25 15:31           ` Vaibhav Hiremath
2015-06-25 15:31           ` Vaibhav Hiremath
2015-06-26 18:01     ` Vaibhav Hiremath
2015-06-26 18:01       ` Vaibhav Hiremath
2015-06-26 18:01       ` Vaibhav Hiremath
2015-06-25  7:26 ` [PATCH-v4 3/3] mfd: devicetree: bindings: Add new 88pm800 mfd binding Vaibhav Hiremath
2015-06-25  7:26   ` Vaibhav Hiremath
2015-06-25  7:26   ` Vaibhav Hiremath
2015-06-25 10:28   ` Lee Jones
2015-06-25 10:28     ` Lee Jones
2015-06-25 10:28     ` Lee Jones
2015-06-25 11:22     ` Vaibhav Hiremath [this message]
2015-06-25 11:22       ` Vaibhav Hiremath
2015-06-25 11:22       ` Vaibhav Hiremath
2015-06-26  6:05   ` Yi Zhang
2015-06-26  6:05     ` Yi Zhang
2015-06-26  6:13     ` Vaibhav Hiremath
2015-06-26  6:13       ` Vaibhav Hiremath
2015-06-26  6:13       ` Vaibhav Hiremath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558BE466.3090408@linaro.org \
    --to=vaibhav.hiremath@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.