All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel@daenzer.net>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	pankaj.m@samsung.com
Subject: Re: [PATCH 1/1] gpu/drm: remove unnecessary check before kfree
Date: Fri, 26 Jun 2015 15:46:33 +0900	[thread overview]
Message-ID: <558CF549.7030909@daenzer.net> (raw)
In-Reply-To: <1435299946-4610-1-git-send-email-maninder1.s@samsung.com>

On 26.06.2015 15:25, Maninder Singh wrote:
> kfree(NULL) is safe and this check is probably not required
> 
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-by: Vaneet Narang <v.narang@samsung.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index fec487d..a85cd08 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1575,8 +1575,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev)
>  	amdgpu_fence_driver_fini(adev);
>  	amdgpu_fbdev_fini(adev);
>  	r = amdgpu_fini(adev);
> -	if (adev->ip_block_enabled)
> -		kfree(adev->ip_block_enabled);
> +	kfree(adev->ip_block_enabled);
>  	adev->ip_block_enabled = NULL;
>  	adev->accel_working = false;
>  	/* free i2c buses */
> 

The shortlog prefix of both your patches should be "drm/amdgpu:" instead
of "gpu/drm:". With that fixed, both are

Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Michel Dänzer" <michel@daenzer.net>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	pankaj.m@samsung.com
Subject: Re: [PATCH 1/1] gpu/drm: remove unnecessary check before kfree
Date: Fri, 26 Jun 2015 15:46:33 +0900	[thread overview]
Message-ID: <558CF549.7030909@daenzer.net> (raw)
In-Reply-To: <1435299946-4610-1-git-send-email-maninder1.s@samsung.com>

On 26.06.2015 15:25, Maninder Singh wrote:
> kfree(NULL) is safe and this check is probably not required
> 
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-by: Vaneet Narang <v.narang@samsung.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index fec487d..a85cd08 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1575,8 +1575,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev)
>  	amdgpu_fence_driver_fini(adev);
>  	amdgpu_fbdev_fini(adev);
>  	r = amdgpu_fini(adev);
> -	if (adev->ip_block_enabled)
> -		kfree(adev->ip_block_enabled);
> +	kfree(adev->ip_block_enabled);
>  	adev->ip_block_enabled = NULL;
>  	adev->accel_working = false;
>  	/* free i2c buses */
> 

The shortlog prefix of both your patches should be "drm/amdgpu:" instead
of "gpu/drm:". With that fixed, both are

Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

  reply	other threads:[~2015-06-26  6:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-26  6:25 [PATCH 1/1] gpu/drm: remove unnecessary check before kfree Maninder Singh
2015-06-26  6:25 ` Maninder Singh
2015-06-26  6:46 ` Michel Dänzer [this message]
2015-06-26  6:46   ` Michel Dänzer
  -- strict thread matches above, loose matches on Subject: below --
2015-06-26  6:54 Maninder Singh
2015-06-26  6:54 ` Maninder Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558CF549.7030909@daenzer.net \
    --to=michel@daenzer.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maninder1.s@samsung.com \
    --cc=pankaj.m@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.