Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler

[Paolo Bonzini <pbonzini@redhat.com>]

On 26/06/2015 11:19, Igor Mammedov wrote:
> That's one of the reasons, I've asked to get rid of icc-bus.
> 
> Another reason is to move default APIC MMIO mapping to CPU from board
> and handle region remapping from CPU itself as it's supposed to be if CPU
> would program another APIC base.
> 
> Paolo,
> would following change be acceptable:
> 
> x86_cpu_realize() {
>    if (tcg) {
>       memory_region_add_subregion_overlap(cpu->as, apic->mr)
>    } else {
>       if (map_once)
>           memory_region_add_subregion_overlap(get_system_memory(), apic->mr)
>    }
> }
> still a hack but a localized to CPU

Yes, this is better.

Paolo