From: vitalya@ti.com (Vitaly Andrianov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] keystone: psci: adds cpu_die implementation
Date: Fri, 26 Jun 2015 12:57:54 -0400 [thread overview]
Message-ID: <558D8492.2090503@ti.com> (raw)
In-Reply-To: <558C4B84.9030303@oracle.com>
On 06/25/2015 02:42 PM, santosh shilimkar wrote:
> On 6/25/2015 10:20 AM, Mark Rutland wrote:
>>>> I need rework and re-test the patch.
>>>> One more question. Shall I post the dts related commit, which add PSCI
>>>> command together with this commit? Or it may be posted later
>>>> independently?
>>>
>>> The DTS and Kconfig changes can be seaprate patches, but they'll need to
>>> go through at the same time.
>>
>> If your bootloader patches the DTB then you don't even need a dts
>> update. That should make things less confusing for existing users...
>>
> More than confusing we need to keep existing DTB binding work with
> updated kernel at least for as basic as booting all the CPUs.
>
> Regards,
> Santosh
>
>
OK. Now I'm confused :) We may have several different configurations here:
1) CONFIG_HOTPLUG_CPU and CONFIG_ARM_PSCI are not set.
In this case keystone arch needs to have
keystone_smp_boot_secondary();
2) CONFIG_HOTPLUG_CPU=y and CONFIG_ARM_PSCI is not set.
keystone_smp_boot_secondary() is required and non PSCI
implementation of keystone_cpu_die() is also required.
3) CONFIG_HOTPLUG_CPU is not set and CONFIG_ARM_PSCI=y
4) CONFIG_HOTPLUG_CPU=y and CONFIG_ARM_PSCI=y
How do I boot secondary CPUs in cases of 3 and 4?
Do I need to implement PSCI version of the
keystone_smp_boot_secondary() of adding PSCI commands to DTB is
enough?
Do I need to implement keystone_cpu_die() if PSCI commands are
added to DTB?
Thanks,
Vitaly
WARNING: multiple messages have this Message-ID (diff)
From: Vitaly Andrianov <vitalya@ti.com>
To: santosh shilimkar <santosh.shilimkar@oracle.com>,
Mark Rutland <mark.rutland@arm.com>
Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ssantosh@kernel.org" <ssantosh@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] keystone: psci: adds cpu_die implementation
Date: Fri, 26 Jun 2015 12:57:54 -0400 [thread overview]
Message-ID: <558D8492.2090503@ti.com> (raw)
In-Reply-To: <558C4B84.9030303@oracle.com>
On 06/25/2015 02:42 PM, santosh shilimkar wrote:
> On 6/25/2015 10:20 AM, Mark Rutland wrote:
>>>> I need rework and re-test the patch.
>>>> One more question. Shall I post the dts related commit, which add PSCI
>>>> command together with this commit? Or it may be posted later
>>>> independently?
>>>
>>> The DTS and Kconfig changes can be seaprate patches, but they'll need to
>>> go through at the same time.
>>
>> If your bootloader patches the DTB then you don't even need a dts
>> update. That should make things less confusing for existing users...
>>
> More than confusing we need to keep existing DTB binding work with
> updated kernel at least for as basic as booting all the CPUs.
>
> Regards,
> Santosh
>
>
OK. Now I'm confused :) We may have several different configurations here:
1) CONFIG_HOTPLUG_CPU and CONFIG_ARM_PSCI are not set.
In this case keystone arch needs to have
keystone_smp_boot_secondary();
2) CONFIG_HOTPLUG_CPU=y and CONFIG_ARM_PSCI is not set.
keystone_smp_boot_secondary() is required and non PSCI
implementation of keystone_cpu_die() is also required.
3) CONFIG_HOTPLUG_CPU is not set and CONFIG_ARM_PSCI=y
4) CONFIG_HOTPLUG_CPU=y and CONFIG_ARM_PSCI=y
How do I boot secondary CPUs in cases of 3 and 4?
Do I need to implement PSCI version of the
keystone_smp_boot_secondary() of adding PSCI commands to DTB is
enough?
Do I need to implement keystone_cpu_die() if PSCI commands are
added to DTB?
Thanks,
Vitaly
next prev parent reply other threads:[~2015-06-26 16:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 14:02 [PATCH] keystone: psci: adds cpu_die implementation Vitaly Andrianov
2015-06-25 14:02 ` Vitaly Andrianov
2015-06-25 14:45 ` Mark Rutland
2015-06-25 14:45 ` Mark Rutland
2015-06-25 14:59 ` santosh shilimkar
2015-06-25 14:59 ` santosh shilimkar
2015-06-25 16:01 ` Vitaly Andrianov
2015-06-25 16:01 ` Vitaly Andrianov
2015-06-25 16:13 ` Mark Rutland
2015-06-25 16:13 ` Mark Rutland
2015-06-25 16:55 ` Vitaly Andrianov
2015-06-25 16:55 ` Vitaly Andrianov
2015-06-25 16:57 ` Mark Rutland
2015-06-25 16:57 ` Mark Rutland
2015-06-25 17:20 ` Mark Rutland
2015-06-25 17:20 ` Mark Rutland
2015-06-25 18:42 ` santosh shilimkar
2015-06-25 18:42 ` santosh shilimkar
2015-06-26 16:57 ` Vitaly Andrianov [this message]
2015-06-26 16:57 ` Vitaly Andrianov
2015-06-26 16:59 ` Mark Rutland
2015-06-26 16:59 ` Mark Rutland
2015-06-26 17:47 ` Grygorii Strashko
2015-06-26 17:47 ` Grygorii Strashko
2015-06-26 18:06 ` Vitaly Andrianov
2015-06-26 18:06 ` Vitaly Andrianov
2015-06-26 18:41 ` santosh shilimkar
2015-06-26 18:41 ` santosh shilimkar
2015-06-25 14:54 ` santosh shilimkar
2015-06-25 14:54 ` santosh shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558D8492.2090503@ti.com \
--to=vitalya@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.