From: santosh.shilimkar@oracle.com (santosh shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] keystone: psci: adds cpu_die implementation
Date: Fri, 26 Jun 2015 11:41:30 -0700 [thread overview]
Message-ID: <558D9CDA.7080001@oracle.com> (raw)
In-Reply-To: <558D902B.1050603@ti.com>
On 6/26/2015 10:47 AM, Grygorii Strashko wrote:
> Hi,
>
> On 06/26/2015 07:57 PM, Vitaly Andrianov wrote:
>> On 06/25/2015 02:42 PM, santosh shilimkar wrote:
> Another question is how well current PSCI implementation supports keystone2/LPAE !?
>
> - It seems, at least below hack should be applied :(
>
> +++ b/arch/arm/kernel/psci_smp.c
> @@ -51,7 +51,7 @@ static int psci_boot_secondary(unsigned int cpu, struct task_struct *idle)
> {
> if (psci_ops.cpu_on)
> return psci_ops.cpu_on(cpu_logical_map(cpu),
> - __pa(secondary_startup));
> + virt_to_idmap(&secondary_startup));
This is legitimate change should be there irrespectively.
I think you should post this as a proper patch.
Regards,
Santosh
WARNING: multiple messages have this Message-ID (diff)
From: santosh shilimkar <santosh.shilimkar@oracle.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Vitaly Andrianov <vitalya@ti.com>,
Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"ssantosh@kernel.org" <ssantosh@kernel.org>
Subject: Re: [PATCH] keystone: psci: adds cpu_die implementation
Date: Fri, 26 Jun 2015 11:41:30 -0700 [thread overview]
Message-ID: <558D9CDA.7080001@oracle.com> (raw)
In-Reply-To: <558D902B.1050603@ti.com>
On 6/26/2015 10:47 AM, Grygorii Strashko wrote:
> Hi,
>
> On 06/26/2015 07:57 PM, Vitaly Andrianov wrote:
>> On 06/25/2015 02:42 PM, santosh shilimkar wrote:
> Another question is how well current PSCI implementation supports keystone2/LPAE !?
>
> - It seems, at least below hack should be applied :(
>
> +++ b/arch/arm/kernel/psci_smp.c
> @@ -51,7 +51,7 @@ static int psci_boot_secondary(unsigned int cpu, struct task_struct *idle)
> {
> if (psci_ops.cpu_on)
> return psci_ops.cpu_on(cpu_logical_map(cpu),
> - __pa(secondary_startup));
> + virt_to_idmap(&secondary_startup));
This is legitimate change should be there irrespectively.
I think you should post this as a proper patch.
Regards,
Santosh
next prev parent reply other threads:[~2015-06-26 18:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 14:02 [PATCH] keystone: psci: adds cpu_die implementation Vitaly Andrianov
2015-06-25 14:02 ` Vitaly Andrianov
2015-06-25 14:45 ` Mark Rutland
2015-06-25 14:45 ` Mark Rutland
2015-06-25 14:59 ` santosh shilimkar
2015-06-25 14:59 ` santosh shilimkar
2015-06-25 16:01 ` Vitaly Andrianov
2015-06-25 16:01 ` Vitaly Andrianov
2015-06-25 16:13 ` Mark Rutland
2015-06-25 16:13 ` Mark Rutland
2015-06-25 16:55 ` Vitaly Andrianov
2015-06-25 16:55 ` Vitaly Andrianov
2015-06-25 16:57 ` Mark Rutland
2015-06-25 16:57 ` Mark Rutland
2015-06-25 17:20 ` Mark Rutland
2015-06-25 17:20 ` Mark Rutland
2015-06-25 18:42 ` santosh shilimkar
2015-06-25 18:42 ` santosh shilimkar
2015-06-26 16:57 ` Vitaly Andrianov
2015-06-26 16:57 ` Vitaly Andrianov
2015-06-26 16:59 ` Mark Rutland
2015-06-26 16:59 ` Mark Rutland
2015-06-26 17:47 ` Grygorii Strashko
2015-06-26 17:47 ` Grygorii Strashko
2015-06-26 18:06 ` Vitaly Andrianov
2015-06-26 18:06 ` Vitaly Andrianov
2015-06-26 18:41 ` santosh shilimkar [this message]
2015-06-26 18:41 ` santosh shilimkar
2015-06-25 14:54 ` santosh shilimkar
2015-06-25 14:54 ` santosh shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558D9CDA.7080001@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.