Re: [Xen-staging] [xen staging] libxl: ao abort: Handle SIGTERM in save/restore helper

Re: [Xen-staging] [xen staging] libxl: ao abort: Handle SIGTERM in save/restore helper

[Ian Campbell]

On Fri, 2015-06-26 at 16:03 +0000, patchbot@xen.org wrote:
> commit b6ac9b7fc6bb18057a1aa114296b32f59b40e187
> Author:     Ian Jackson <ian.jackson@eu.citrix.com>
> AuthorDate: Tue Feb 10 19:05:06 2015 +0000
> Commit:     Ian Jackson <Ian.Jackson@eu.citrix.com>
> CommitDate: Fri Jun 26 16:53:51 2015 +0100
> 
>     libxl: ao abort: Handle SIGTERM in save/restore helper

Trying to do a build test of my libxenctrl split on FreeBSD I came
across this build failure with current staging (without my patches)
which I suspect is down to this change. Missing a header perhaps?

libxl_save_helper.c: In function 'setup_signals':
libxl_save_helper.c:158:22: error: storage size of 'sa' isn't known
     struct sigaction sa;
                      ^
libxl_save_helper.c:167:5: error: implicit declaration of function 'sigemptyset' [-Werror=implicit-function-declaration]
     sigemptyset(&sa.sa_mask);
     ^
libxl_save_helper.c:168:5: error: implicit declaration of function 'sigaction' [-Werror=implicit-function-declaration]
     r = sigaction(SIGTERM, &sa, 0);
     ^
libxl_save_helper.c:168:19: error: 'SIGTERM' undeclared (first use in this function)
     r = sigaction(SIGTERM, &sa, 0);
                   ^
libxl_save_helper.c:168:19: note: each undeclared identifier is reported only once for each function it appears in
libxl_save_helper.c:172:5: error: implicit declaration of function 'sigaddset' [-Werror=implicit-function-declaration]
     sigaddset(&spmask,SIGTERM);
     ^
libxl_save_helper.c:173:5: error: implicit declaration of function 'sigprocmask' [-Werror=implicit-function-declaration]
     r = sigprocmask(SIG_UNBLOCK,&spmask,0);
     ^
libxl_save_helper.c:173:21: error: 'SIG_UNBLOCK' undeclared (first use in this function)
     r = sigprocmask(SIG_UNBLOCK,&spmask,0);
                     ^
libxl_save_helper.c:158:22: error: unused variable 'sa' [-Werror=unused-variable]
     struct sigaction sa;
                      ^
libxl_save_helper.c: In function 'main':
libxl_save_helper.c:313:23: error: 'SIG_DFL' undeclared (first use in this function)
         setup_signals(SIG_DFL);
                       ^
cc1: all warnings being treated as errors

Re: [Xen-staging] [xen staging] libxl: ao abort: Handle SIGTERM in save/restore helper

[Ian Jackson]

Ian Campbell writes ("Re: [Xen-staging] [xen staging] libxl: ao abort: Handle SIGTERM in save/restore helper"):
> On Fri, 2015-06-26 at 16:03 +0000, patchbot@xen.org wrote:
> > commit b6ac9b7fc6bb18057a1aa114296b32f59b40e187
> > Author:     Ian Jackson <ian.jackson@eu.citrix.com>
> > AuthorDate: Tue Feb 10 19:05:06 2015 +0000
> > Commit:     Ian Jackson <Ian.Jackson@eu.citrix.com>
> > CommitDate: Fri Jun 26 16:53:51 2015 +0100
> > 
> >     libxl: ao abort: Handle SIGTERM in save/restore helper
> 
> Trying to do a build test of my libxenctrl split on FreeBSD I came
> across this build failure with current staging (without my patches)
> which I suspect is down to this change. Missing a header perhaps?

Sorry.  Try this ?

Ian.

diff --git a/tools/libxl/libxl_save_helper.c b/tools/libxl/libxl_save_helper.c
index 0be77c9..14675ae 100644
--- a/tools/libxl/libxl_save_helper.c
+++ b/tools/libxl/libxl_save_helper.c
@@ -41,6 +41,7 @@
 #include <assert.h>
 #include <inttypes.h>
 #include <fcntl.h>
+#include <signal.h>
 
 #include "libxl.h"
 #include "libxl_utils.h"

[PATCH] libxl: Add missing #include of <signal.h>

[Ian Jackson]

"libxl: ao abort: Handle SIGTERM in save/restore helper" requires
this; without it we fail to build on BSD.

Reported-by: Ian Campbell <ian.campbell@citrix.com>
CC: Ian Campbell <ian.campbell@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 tools/libxl/libxl_save_helper.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/libxl/libxl_save_helper.c b/tools/libxl/libxl_save_helper.c
index 0be77c9..14675ae 100644
--- a/tools/libxl/libxl_save_helper.c
+++ b/tools/libxl/libxl_save_helper.c
@@ -41,6 +41,7 @@
 #include <assert.h>
 #include <inttypes.h>
 #include <fcntl.h>
+#include <signal.h>
 
 #include "libxl.h"
 #include "libxl_utils.h"
-- 
1.7.10.4

Re: [PATCH] libxl: Add missing #include of <signal.h>

[Ian Jackson]

Ian Jackson writes ("[PATCH] libxl: Add missing #include of <signal.h>"):
> "libxl: ao abort: Handle SIGTERM in save/restore helper" requires
> this; without it we fail to build on BSD.
> 
> Reported-by: Ian Campbell <ian.campbell@citrix.com>
> CC: Ian Campbell <ian.campbell@citrix.com>
> CC: Roger Pau Monne <roger.pau@citrix.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Given that this is a build fix, I have taken the liberty of pushing it
without waiting for an ack.

Ian.

Re: [PATCH] libxl: Add missing #include of <signal.h>

[Roger Pau Monné]

El 26/06/15 a les 19.27, Ian Jackson ha escrit:
> Ian Jackson writes ("[PATCH] libxl: Add missing #include of <signal.h>"):
>> "libxl: ao abort: Handle SIGTERM in save/restore helper" requires
>> this; without it we fail to build on BSD.
>>
>> Reported-by: Ian Campbell <ian.campbell@citrix.com>
>> CC: Ian Campbell <ian.campbell@citrix.com>
>> CC: Roger Pau Monne <roger.pau@citrix.com>
>> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> 
> Given that this is a build fix, I have taken the liberty of pushing it
> without waiting for an ack.

Thanks. For the record:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Roger.