From: Timur Tabi <timur@tabi.org>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: Xiubo Li <Xiubo.Lee@gmail.com>, Takashi Iwai <tiwai@suse.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Mark Brown <broonie@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates
Date: Sun, 28 Jun 2015 09:01:50 -0500 [thread overview]
Message-ID: <558FFE4E.703@tabi.org> (raw)
In-Reply-To: <558FFAC4.2060608@maciej.szmigiero.name>
Maciej S. Szmigiero wrote:
> /* Are the RX and the TX clocks locked? */
> if (!of_find_property(np, "fsl,ssi-asynchronous", NULL)) {
> - ssi_private->cpu_dai_drv.symmetric_rates = 1;
> + if (!fsl_ssi_is_ac97(ssi_private))
> + ssi_private->cpu_dai_drv.symmetric_rates = 1;
> +
Is this necessary? Why not just add fsl,ssi-asynchronous to the AC97
device tree node?
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@tabi.org>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: Nicolin Chen <nicoleotsuka@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
linuxppc-dev@lists.ozlabs.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates
Date: Sun, 28 Jun 2015 09:01:50 -0500 [thread overview]
Message-ID: <558FFE4E.703@tabi.org> (raw)
In-Reply-To: <558FFAC4.2060608@maciej.szmigiero.name>
Maciej S. Szmigiero wrote:
> /* Are the RX and the TX clocks locked? */
> if (!of_find_property(np, "fsl,ssi-asynchronous", NULL)) {
> - ssi_private->cpu_dai_drv.symmetric_rates = 1;
> + if (!fsl_ssi_is_ac97(ssi_private))
> + ssi_private->cpu_dai_drv.symmetric_rates = 1;
> +
Is this necessary? Why not just add fsl,ssi-asynchronous to the AC97
device tree node?
next prev parent reply other threads:[~2015-06-28 14:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-28 13:46 [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates Maciej S. Szmigiero
2015-06-28 13:46 ` Maciej S. Szmigiero
2015-06-28 14:01 ` Timur Tabi [this message]
2015-06-28 14:01 ` Timur Tabi
2015-06-28 19:12 ` Maciej S. Szmigiero
2015-08-15 2:13 ` Applied "ASoC: fsl_ssi: enable AC'97 asymmetric rates" to the asoc tree Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2015-07-30 14:34 [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates Maciej S. Szmigiero
2015-07-31 5:27 ` Markus Pargmann
2015-07-31 5:53 ` Markus Pargmann
2015-07-31 14:38 ` Maciej S. Szmigiero
2015-07-31 14:38 ` Maciej S. Szmigiero
2015-08-02 18:46 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558FFE4E.703@tabi.org \
--to=timur@tabi.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mail@maciej.szmigiero.name \
--cc=nicoleotsuka@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.