All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Xishi Qiu <qiuxishi@huawei.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
	"Luck, Tony" <tony.luck@intel.com>,
	Hanjun Guo <guohanjun@huawei.com>, Xiexiuqi <xiexiuqi@huawei.com>,
	leon@leon.nu, Dave Hansen <dave.hansen@intel.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Vlastimil Babka <vbabka@suse.cz>, Mel Gorman <mgorman@suse.de>
Cc: Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC v2 PATCH 1/8] mm: add a new config to manage the code
Date: Mon, 29 Jun 2015 15:50:17 +0900	[thread overview]
Message-ID: <5590EAA9.5090104@jp.fujitsu.com> (raw)
In-Reply-To: <558E0913.7020501@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

On 2015/06/27 11:23, Xishi Qiu wrote:
> This patch introduces a new config called "CONFIG_ACPI_MIRROR_MEMORY", set it
                                              CONFIG_MEMORY_MIRROR
> off by default.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> ---
>   mm/Kconfig | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 390214d..c40bb8b 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -200,6 +200,14 @@ config MEMORY_HOTREMOVE
>   	depends on MEMORY_HOTPLUG && ARCH_ENABLE_MEMORY_HOTREMOVE
>   	depends on MIGRATION
>
> +config MEMORY_MIRROR

   In following patches, you use CONFIG_MEMORY_MIRROR.

I think the name is too generic besides it's depends on ACPI.
But I'm not sure address based memory mirror is planned in other platform.

So, hmm. How about dividing the config into 2 parts like attached ? (just an example)

Thanks,
-Kame

[-- Attachment #2: 0001-add-a-new-config-option-for-memory-mirror.patch --]
[-- Type: text/plain, Size: 0 bytes --]



WARNING: multiple messages have this Message-ID (diff)
From: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Xishi Qiu <qiuxishi@huawei.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
	"Luck, Tony" <tony.luck@intel.com>,
	Hanjun Guo <guohanjun@huawei.com>, Xiexiuqi <xiexiuqi@huawei.com>,
	leon@leon.nu, Dave Hansen <dave.hansen@intel.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Vlastimil Babka <vbabka@suse.cz>, Mel Gorman <mgorman@suse.de>
Cc: Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC v2 PATCH 1/8] mm: add a new config to manage the code
Date: Mon, 29 Jun 2015 15:50:17 +0900	[thread overview]
Message-ID: <5590EAA9.5090104@jp.fujitsu.com> (raw)
In-Reply-To: <558E0913.7020501@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

On 2015/06/27 11:23, Xishi Qiu wrote:
> This patch introduces a new config called "CONFIG_ACPI_MIRROR_MEMORY", set it
                                              CONFIG_MEMORY_MIRROR
> off by default.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> ---
>   mm/Kconfig | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 390214d..c40bb8b 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -200,6 +200,14 @@ config MEMORY_HOTREMOVE
>   	depends on MEMORY_HOTPLUG && ARCH_ENABLE_MEMORY_HOTREMOVE
>   	depends on MIGRATION
>
> +config MEMORY_MIRROR

   In following patches, you use CONFIG_MEMORY_MIRROR.

I think the name is too generic besides it's depends on ACPI.
But I'm not sure address based memory mirror is planned in other platform.

So, hmm. How about dividing the config into 2 parts like attached ? (just an example)

Thanks,
-Kame

[-- Attachment #2: 0001-add-a-new-config-option-for-memory-mirror.patch --]
[-- Type: text/plain, Size: 1918 bytes --]

>From 88213b0f76e2f603c5a38690cbd85a4df1e646ba Mon Sep 17 00:00:00 2001
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Date: Mon, 29 Jun 2015 15:35:47 +0900
Subject: [PATCH] add a new config option for memory mirror

Add a new config option "CONFIG_MEMORY_MIRROR" for kernel assisted
memory mirroring.

In UEFI2.5 spec, Address based memory mirror is defined and it allows
the system to create partial memory mirror.

The feature guards important(kernel) memory to be mirrored by using
the address based memory mirror.

Now this depends on cpu architecure Haswell? Broadwell?
---
 arch/x86/Kconfig | 6 ++++++
 mm/Kconfig       | 9 +++++++++
 2 files changed, 15 insertions(+)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index e33e01b..56f17df 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -596,6 +596,12 @@ config X86_SUPPORTS_MEMORY_FAILURE
 	depends on X86_64 || !SPARSEMEM
 	select ARCH_SUPPORTS_MEMORY_FAILURE
 
+config X86_SUPPORTS_MEMORY_MIRROR
+	def_bool y
+	# UEFI 2.5spec. address based memory mirror, supported only after XXX
+	depends on X86_64 && ARCH_SUPPORTS_MEMORY_FAILURE
+	select ARCH_MEMORY_MIRROR
+
 config STA2X11
 	bool "STA2X11 Companion Chip Support"
 	depends on X86_32_NON_STANDARD && PCI
diff --git a/mm/Kconfig b/mm/Kconfig
index b3a60ee..e14dc2d 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -200,6 +200,15 @@ config MEMORY_HOTREMOVE
 	depends on MEMORY_HOTPLUG && ARCH_ENABLE_MEMORY_HOTREMOVE
 	depends on MIGRATION
 
+config MEMORY_MIRROR
+	bool "Address range mirroring support"
+	depends on ARCH_MEMORY_MIRROR
+	default n
+	help
+	  This feature allows the kernel to assist address based memory
+	  mirror supported by architecture/firmware. And place some types
+          of memory (especially, kernel memory) placed into mirrored range.
+
 #
 # If we have space for more page flags then we can enable additional
 # optimizations and functionality.
-- 
1.9.3


  reply	other threads:[~2015-06-29  6:53 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-27  2:19 [RFC v2 PATCH 0/8] mm: mirrored memory support for page buddy allocations Xishi Qiu
2015-06-27  2:19 ` Xishi Qiu
2015-06-27  2:23 ` [RFC v2 PATCH 1/8] mm: add a new config to manage the code Xishi Qiu
2015-06-27  2:23   ` Xishi Qiu
2015-06-29  6:50   ` Kamezawa Hiroyuki [this message]
2015-06-29  6:50     ` Kamezawa Hiroyuki
2015-06-30  2:52     ` Xishi Qiu
2015-06-30  2:52       ` Xishi Qiu
2015-06-27  2:24 ` [RFC v2 PATCH 2/8] mm: introduce MIGRATE_MIRROR to manage the mirrored pages Xishi Qiu
2015-06-27  2:24   ` Xishi Qiu
2015-06-29  7:32   ` Kamezawa Hiroyuki
2015-06-29  7:32     ` Kamezawa Hiroyuki
2015-06-30  2:45     ` Xishi Qiu
2015-06-30  2:45       ` Xishi Qiu
2015-06-30  7:53       ` Kamezawa Hiroyuki
2015-06-30  7:53         ` Kamezawa Hiroyuki
2015-06-30  9:22         ` Xishi Qiu
2015-06-30  9:22           ` Xishi Qiu
2015-06-27  2:24 ` [RFC v2 PATCH 3/8] mm: find mirrored memory in memblock Xishi Qiu
2015-06-27  2:24   ` Xishi Qiu
2015-06-27  2:25 ` [RFC v2 PATCH 4/8] mm: add mirrored memory to buddy system Xishi Qiu
2015-06-27  2:25   ` Xishi Qiu
2015-06-29  7:39   ` Kamezawa Hiroyuki
2015-06-29  7:39     ` Kamezawa Hiroyuki
2015-06-27  2:26 ` [RFC v2 PATCH 5/8] mm: introduce a new zone_stat_item NR_FREE_MIRROR_PAGES Xishi Qiu
2015-06-27  2:26   ` Xishi Qiu
2015-06-27  2:27 ` [RFC v2 PATCH 6/8] mm: add free mirrored pages info Xishi Qiu
2015-06-27  2:27   ` Xishi Qiu
2015-06-27  2:27 ` [RFC v2 PATCH 7/8] mm: add the buddy system interface Xishi Qiu
2015-06-27  2:27   ` Xishi Qiu
2015-06-29 23:11   ` Luck, Tony
2015-06-29 23:11     ` Luck, Tony
2015-06-30  1:01     ` Kamezawa Hiroyuki
2015-06-30  1:01       ` Kamezawa Hiroyuki
2015-06-30  1:31       ` Xishi Qiu
2015-06-30  1:31         ` Xishi Qiu
2015-06-30  2:01         ` Kamezawa Hiroyuki
2015-06-30  2:01           ` Kamezawa Hiroyuki
2015-06-27  2:28 ` [RFC v2 PATCH 8/8] mm: add the PCP interface Xishi Qiu
2015-06-27  2:28   ` Xishi Qiu
2015-06-29 15:19 ` [RFC v2 PATCH 0/8] mm: mirrored memory support for page buddy allocations Dave Hansen
2015-06-29 15:19   ` Dave Hansen
2015-06-30  1:26   ` Xishi Qiu
2015-06-30  1:26     ` Xishi Qiu
2015-06-30  1:52     ` Dave Hansen
2015-06-30  1:52       ` Dave Hansen
2015-06-30  2:48       ` Xishi Qiu
2015-06-30  2:48         ` Xishi Qiu
2015-06-30  9:41 ` Mel Gorman
2015-06-30  9:41   ` Mel Gorman
2015-06-30 10:46   ` Ingo Molnar
2015-06-30 10:46     ` Ingo Molnar
2015-06-30 11:53     ` Mel Gorman
2015-06-30 11:53       ` Mel Gorman
2015-06-30 18:12       ` Luck, Tony
2015-06-30 18:12         ` Luck, Tony
2015-07-13  4:56       ` Xishi Qiu
2015-07-13  4:56         ` Xishi Qiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5590EAA9.5090104@jp.fujitsu.com \
    --to=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=guohanjun@huawei.com \
    --cc=hpa@zytor.com \
    --cc=leon@leon.nu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=qiuxishi@huawei.com \
    --cc=tony.luck@intel.com \
    --cc=vbabka@suse.cz \
    --cc=xiexiuqi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.