All of lore.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL] drm/rockchip: fixes and new features
@ 2015-06-30  6:50 Mark yao
  2015-07-01  8:03 ` Tomasz Figa
  0 siblings, 1 reply; 13+ messages in thread
From: Mark yao @ 2015-06-30  6:50 UTC (permalink / raw)
  To: David Airlie; +Cc: open list:ARM/Rockchip SoC..., dri-devel, Tomasz Figa

Hi Dave.

     Some fixes and some new features. I'd like you can pull them.

The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898:

   drm/nouveau: Pause between setting gpu to D3hot and cutting the power 
(2015-06-26 10:26:37 +1000)

are available in the git repository at:

   https://github.com/markyzq/kernel-drm-rockchip.git 
drm-rockchip-2015-06-30

for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:

   drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10 +0800)

----------------------------------------------------------------
Heiko Stübner (1):
       drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper 
present

Mark Yao (6):
       drm/rockchip: import dma_buf to gem
       drm/rockchip: vop: optimize virtual stride calculate
       drm/rockchip: vop: fix yuv plane support
       drm/rockchip: vop: support plane scale
       drm/rockchip: vop: switch cursor plane to window 3
       drm/rockchip: default enable win2/3 area0 bit

Tomasz Figa (1):
       drm/rockchip: Add BGR formats to VOP

  drivers/gpu/drm/rockchip/rockchip_drm_drv.c |    1 +
  drivers/gpu/drm/rockchip/rockchip_drm_fb.c  |    3 +-
  drivers/gpu/drm/rockchip/rockchip_drm_gem.c |   40 ++-
  drivers/gpu/drm/rockchip/rockchip_drm_gem.h |    5 +-
  drivers/gpu/drm/rockchip/rockchip_drm_vop.c |  500 
++++++++++++++++++++++++++-
  drivers/gpu/drm/rockchip/rockchip_drm_vop.h |   96 +++++
  6 files changed, 628 insertions(+), 17 deletions(-)

-- 
Mark


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [GIT PULL] drm/rockchip: fixes and new features
  2015-06-30  6:50 [GIT PULL] drm/rockchip: fixes and new features Mark yao
@ 2015-07-01  8:03 ` Tomasz Figa
  2015-07-01  8:20   ` Daniel Vetter
  2015-07-01  8:32   ` Mark yao
  0 siblings, 2 replies; 13+ messages in thread
From: Tomasz Figa @ 2015-07-01  8:03 UTC (permalink / raw)
  To: Mark yao; +Cc: open list:ARM/Rockchip SoC..., dri-devel

Hi Mark,

On Tue, Jun 30, 2015 at 3:50 PM, Mark yao <mark.yao@rock-chips.com> wrote:
>
> Hi Dave.
>
>     Some fixes and some new features. I'd like you can pull them.
>
> The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898:
>
>   drm/nouveau: Pause between setting gpu to D3hot and cutting the power (2015-06-26 10:26:37 +1000)
>
> are available in the git repository at:
>
>   https://github.com/markyzq/kernel-drm-rockchip.git drm-rockchip-2015-06-30
>
> for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:
>
>   drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10 +0800)
>
> ----------------------------------------------------------------
> Heiko Stübner (1):
>       drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper present
>
> Mark Yao (6):
>       drm/rockchip: import dma_buf to gem
>       drm/rockchip: vop: optimize virtual stride calculate
>       drm/rockchip: vop: fix yuv plane support
>       drm/rockchip: vop: support plane scale
>       drm/rockchip: vop: switch cursor plane to window 3
>       drm/rockchip: default enable win2/3 area0 bit

Has this series been reviewed properly? I can see that at least
"drm/rockchip: vop: support plane scale" is kind of "controversial".

By the way, if we're using window 3 for cursor plane, because the
cursor window needs special handling, is it okay to expose the cusor
window as an overlay plane to userspace, as we do currently?

Best regards,
Tomasz
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [GIT PULL] drm/rockchip: fixes and new features
  2015-07-01  8:03 ` Tomasz Figa
@ 2015-07-01  8:20   ` Daniel Vetter
  2015-07-01  8:32     ` Tomasz Figa
  2015-07-01  8:32   ` Mark yao
  1 sibling, 1 reply; 13+ messages in thread
From: Daniel Vetter @ 2015-07-01  8:20 UTC (permalink / raw)
  To: Tomasz Figa; +Cc: open list:ARM/Rockchip SoC..., dri-devel

On Wed, Jul 01, 2015 at 05:03:39PM +0900, Tomasz Figa wrote:
> Hi Mark,
> 
> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao <mark.yao@rock-chips.com> wrote:
> >
> > Hi Dave.
> >
> >     Some fixes and some new features. I'd like you can pull them.
> >
> > The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898:
> >
> >   drm/nouveau: Pause between setting gpu to D3hot and cutting the power (2015-06-26 10:26:37 +1000)
> >
> > are available in the git repository at:
> >
> >   https://github.com/markyzq/kernel-drm-rockchip.git drm-rockchip-2015-06-30
> >
> > for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:
> >
> >   drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10 +0800)
> >
> > ----------------------------------------------------------------
> > Heiko Stübner (1):
> >       drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper present
> >
> > Mark Yao (6):
> >       drm/rockchip: import dma_buf to gem
> >       drm/rockchip: vop: optimize virtual stride calculate
> >       drm/rockchip: vop: fix yuv plane support
> >       drm/rockchip: vop: support plane scale
> >       drm/rockchip: vop: switch cursor plane to window 3
> >       drm/rockchip: default enable win2/3 area0 bit
> 
> Has this series been reviewed properly? I can see that at least
> "drm/rockchip: vop: support plane scale" is kind of "controversial".

I don't see any discussion of this patch at all on dri-devel, where's this
controversy?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [GIT PULL] drm/rockchip: fixes and new features
  2015-07-01  8:20   ` Daniel Vetter
@ 2015-07-01  8:32     ` Tomasz Figa
  2015-07-01  8:56       ` Mark yao
  0 siblings, 1 reply; 13+ messages in thread
From: Tomasz Figa @ 2015-07-01  8:32 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: open list:ARM/Rockchip SoC..., dri-devel

On Wed, Jul 1, 2015 at 5:20 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Jul 01, 2015 at 05:03:39PM +0900, Tomasz Figa wrote:
>> Hi Mark,
>>
>> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao <mark.yao@rock-chips.com> wrote:
>> >
>> > Hi Dave.
>> >
>> >     Some fixes and some new features. I'd like you can pull them.
>> >
>> > The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898:
>> >
>> >   drm/nouveau: Pause between setting gpu to D3hot and cutting the power (2015-06-26 10:26:37 +1000)
>> >
>> > are available in the git repository at:
>> >
>> >   https://github.com/markyzq/kernel-drm-rockchip.git drm-rockchip-2015-06-30
>> >
>> > for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:
>> >
>> >   drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10 +0800)
>> >
>> > ----------------------------------------------------------------
>> > Heiko Stübner (1):
>> >       drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper present
>> >
>> > Mark Yao (6):
>> >       drm/rockchip: import dma_buf to gem
>> >       drm/rockchip: vop: optimize virtual stride calculate
>> >       drm/rockchip: vop: fix yuv plane support
>> >       drm/rockchip: vop: support plane scale
>> >       drm/rockchip: vop: switch cursor plane to window 3
>> >       drm/rockchip: default enable win2/3 area0 bit
>>
>> Has this series been reviewed properly? I can see that at least
>> "drm/rockchip: vop: support plane scale" is kind of "controversial".
>
> I don't see any discussion of this patch at all on dri-devel, where's this
> controversy?

Well, it adds a lot of seemingly complex, hard to read code with
obvious style issues. I'll review the series later this week.

Best regards,
Tomasz
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [GIT PULL] drm/rockchip: fixes and new features
  2015-07-01  8:03 ` Tomasz Figa
  2015-07-01  8:20   ` Daniel Vetter
@ 2015-07-01  8:32   ` Mark yao
  2015-07-01  8:42     ` Tomasz Figa
  2015-07-01  8:43     ` Mark yao
  1 sibling, 2 replies; 13+ messages in thread
From: Mark yao @ 2015-07-01  8:32 UTC (permalink / raw)
  To: Tomasz Figa; +Cc: open list:ARM/Rockchip SoC..., dri-devel

On 2015年07月01日 16:03, Tomasz Figa wrote:
> Hi Mark,
>
> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao <mark.yao@rock-chips.com> wrote:
>> Hi Dave.
>>
>>      Some fixes and some new features. I'd like you can pull them.
>>
>> The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898:
>>
>>    drm/nouveau: Pause between setting gpu to D3hot and cutting the power (2015-06-26 10:26:37 +1000)
>>
>> are available in the git repository at:
>>
>>    https://github.com/markyzq/kernel-drm-rockchip.git drm-rockchip-2015-06-30
>>
>> for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:
>>
>>    drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10 +0800)
>>
>> ----------------------------------------------------------------
>> Heiko Stübner (1):
>>        drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper present
>>
>> Mark Yao (6):
>>        drm/rockchip: import dma_buf to gem
>>        drm/rockchip: vop: optimize virtual stride calculate
>>        drm/rockchip: vop: fix yuv plane support
>>        drm/rockchip: vop: support plane scale
>>        drm/rockchip: vop: switch cursor plane to window 3
>>        drm/rockchip: default enable win2/3 area0 bit
> Has this series been reviewed properly? I can see that at least
> "drm/rockchip: vop: support plane scale" is kind of "controversial".

Sorry for that, can you review those patches, and give me some advices?

https://lkml.org/lkml/2015/6/18/77
v2: https://lkml.org/lkml/2015/6/26/192

> By the way, if we're using window 3 for cursor plane, because the
> cursor window needs special handling, is it okay to expose the cusor
> window as an overlay plane to userspace, as we do currently?

special handling? what means? "switch cursor plane to window 3" patch 
only switch cursor
  windows from win1 to win3. tag window 3 as DRM_PLANE_TYPE_CURSOR, 
userspace only
can found window 3 is a cursor plane.

>
> Best regards,
> Tomasz
>
>
>

Best regards,
Mark

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [GIT PULL] drm/rockchip: fixes and new features
  2015-07-01  8:32   ` Mark yao
@ 2015-07-01  8:42     ` Tomasz Figa
  2015-07-01  9:13       ` Mark yao
  2015-07-01  8:43     ` Mark yao
  1 sibling, 1 reply; 13+ messages in thread
From: Tomasz Figa @ 2015-07-01  8:42 UTC (permalink / raw)
  To: Mark yao; +Cc: open list:ARM/Rockchip SoC..., dri-devel

On Wed, Jul 1, 2015 at 5:32 PM, Mark yao <mark.yao@rock-chips.com> wrote:
> On 2015年07月01日 16:03, Tomasz Figa wrote:
>>
>> Hi Mark,
>>
>> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao <mark.yao@rock-chips.com> wrote:
>>>
>>> Hi Dave.
>>>
>>>      Some fixes and some new features. I'd like you can pull them.
>>>
>>> The following changes since commit
>>> c5fd936e992dd2829167d2adc63e151675ca6898:
>>>
>>>    drm/nouveau: Pause between setting gpu to D3hot and cutting the power
>>> (2015-06-26 10:26:37 +1000)
>>>
>>> are available in the git repository at:
>>>
>>>    https://github.com/markyzq/kernel-drm-rockchip.git
>>> drm-rockchip-2015-06-30
>>>
>>> for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:
>>>
>>>    drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10
>>> +0800)
>>>
>>> ----------------------------------------------------------------
>>> Heiko Stübner (1):
>>>        drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper
>>> present
>>>
>>> Mark Yao (6):
>>>        drm/rockchip: import dma_buf to gem
>>>        drm/rockchip: vop: optimize virtual stride calculate
>>>        drm/rockchip: vop: fix yuv plane support
>>>        drm/rockchip: vop: support plane scale
>>>        drm/rockchip: vop: switch cursor plane to window 3
>>>        drm/rockchip: default enable win2/3 area0 bit
>>
>> Has this series been reviewed properly? I can see that at least
>> "drm/rockchip: vop: support plane scale" is kind of "controversial".
>
>
> Sorry for that, can you review those patches, and give me some advices?
>
> https://lkml.org/lkml/2015/6/18/77
> v2: https://lkml.org/lkml/2015/6/26/192
>

Yes, will do that.

By the way, please feel free to ping patches on the lists if they idle
without any comments or tags for while.

>> By the way, if we're using window 3 for cursor plane, because the
>> cursor window needs special handling, is it okay to expose the cusor
>> window as an overlay plane to userspace, as we do currently?
>
>
> special handling? what means? "switch cursor plane to window 3" patch only
> switch cursor
>  windows from win1 to win3. tag window 3 as DRM_PLANE_TYPE_CURSOR, userspace
> only
> can found window 3 is a cursor plane.
>

Ah, this was a question slightly unrelated to that patch, but I just
noticed in that patch that the hardware cursor window is still exposed
to the userspace as overlay plane, even if it's not quite suitable for
being such.

Best regards,
Tomasz
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [GIT PULL] drm/rockchip: fixes and new features
  2015-07-01  8:32   ` Mark yao
  2015-07-01  8:42     ` Tomasz Figa
@ 2015-07-01  8:43     ` Mark yao
  1 sibling, 0 replies; 13+ messages in thread
From: Mark yao @ 2015-07-01  8:43 UTC (permalink / raw)
  To: Tomasz Figa; +Cc: open list:ARM/Rockchip SoC..., dri-devel

On 2015年07月01日 16:32, Mark yao wrote:
> On 2015年07月01日 16:03, Tomasz Figa wrote:
>> Hi Mark,
>>
>> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao <mark.yao@rock-chips.com> 
>> wrote:
>>> Hi Dave.
>>>
>>>      Some fixes and some new features. I'd like you can pull them.
>>>
>>> The following changes since commit 
>>> c5fd936e992dd2829167d2adc63e151675ca6898:
>>>
>>>    drm/nouveau: Pause between setting gpu to D3hot and cutting the 
>>> power (2015-06-26 10:26:37 +1000)
>>>
>>> are available in the git repository at:
>>>
>>>    https://github.com/markyzq/kernel-drm-rockchip.git 
>>> drm-rockchip-2015-06-30
>>>
>>> for you to fetch changes up to 
>>> 5295c05eb30d743987172853179333c80b8242bc:
>>>
>>>    drm/rockchip: default enable win2/3 area0 bit (2015-06-30 
>>> 14:24:10 +0800)
>>>
>>> ----------------------------------------------------------------
>>> Heiko Stübner (1):
>>>        drm/rockchip: only call drm_fb_helper_hotplug_event if 
>>> fb_helper present
>>>
>>> Mark Yao (6):
>>>        drm/rockchip: import dma_buf to gem
>>>        drm/rockchip: vop: optimize virtual stride calculate
>>>        drm/rockchip: vop: fix yuv plane support
>>>        drm/rockchip: vop: support plane scale
>>>        drm/rockchip: vop: switch cursor plane to window 3
>>>        drm/rockchip: default enable win2/3 area0 bit
>> Has this series been reviewed properly? I can see that at least
>> "drm/rockchip: vop: support plane scale" is kind of "controversial".
>
> Sorry for that, can you review those patches, and give me some advices?
>
> https://lkml.org/lkml/2015/6/18/77
> v2: https://lkml.org/lkml/2015/6/26/192
>
>> By the way, if we're using window 3 for cursor plane, because the
>> cursor window needs special handling, is it okay to expose the cusor
>> window as an overlay plane to userspace, as we do currently?
>
> special handling? what means? "switch cursor plane to window 3" patch 
> only switch cursor
>  windows from win1 to win3. tag window 3 as DRM_PLANE_TYPE_CURSOR, 
> userspace only
> can found window 3 is a cursor plane.

switch cursor win1 to win3 because we want to use win1 as a overlay for 
yuv image, win3 not
support yuv format.  not for special handling.

By the way, win3 power power consume less than win1, cursor use win3 
would save power.

>
>>
>> Best regards,
>> Tomasz
>>
>>
>>
>
> Best regards,
> Mark
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel


-- 
Mark


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [GIT PULL] drm/rockchip: fixes and new features
  2015-07-01  8:32     ` Tomasz Figa
@ 2015-07-01  8:56       ` Mark yao
  0 siblings, 0 replies; 13+ messages in thread
From: Mark yao @ 2015-07-01  8:56 UTC (permalink / raw)
  To: Tomasz Figa, Daniel Vetter; +Cc: open list:ARM/Rockchip SoC..., dri-devel

On 2015年07月01日 16:32, Tomasz Figa wrote:
> On Wed, Jul 1, 2015 at 5:20 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
>> On Wed, Jul 01, 2015 at 05:03:39PM +0900, Tomasz Figa wrote:
>>> Hi Mark,
>>>
>>> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao <mark.yao@rock-chips.com> wrote:
>>>> Hi Dave.
>>>>
>>>>      Some fixes and some new features. I'd like you can pull them.
>>>>
>>>> The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898:
>>>>
>>>>    drm/nouveau: Pause between setting gpu to D3hot and cutting the power (2015-06-26 10:26:37 +1000)
>>>>
>>>> are available in the git repository at:
>>>>
>>>>    https://github.com/markyzq/kernel-drm-rockchip.git drm-rockchip-2015-06-30
>>>>
>>>> for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:
>>>>
>>>>    drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10 +0800)
>>>>
>>>> ----------------------------------------------------------------
>>>> Heiko Stübner (1):
>>>>        drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper present
>>>>
>>>> Mark Yao (6):
>>>>        drm/rockchip: import dma_buf to gem
>>>>        drm/rockchip: vop: optimize virtual stride calculate
>>>>        drm/rockchip: vop: fix yuv plane support
>>>>        drm/rockchip: vop: support plane scale
>>>>        drm/rockchip: vop: switch cursor plane to window 3
>>>>        drm/rockchip: default enable win2/3 area0 bit
>>> Has this series been reviewed properly? I can see that at least
>>> "drm/rockchip: vop: support plane scale" is kind of "controversial".
>> I don't see any discussion of this patch at all on dri-devel, where's this
>> controversy?
> Well, it adds a lot of seemingly complex, hard to read code with
> obvious style issues. I'll review the series later this week.
>
> Best regards,
> Tomasz
>
>
Hi Tomasz

     Thanks, those compute code you can found from RK3288 TRM->"27.3.3 
Win Scaling", too complex.
I had do some clean for the code, but for full function and little bug, 
hard to cleanup.

Best regards,

-- 
Mark


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [GIT PULL] drm/rockchip: fixes and new features
  2015-07-01  8:42     ` Tomasz Figa
@ 2015-07-01  9:13       ` Mark yao
  2015-07-01  9:17         ` Tomasz Figa
  0 siblings, 1 reply; 13+ messages in thread
From: Mark yao @ 2015-07-01  9:13 UTC (permalink / raw)
  To: Tomasz Figa; +Cc: open list:ARM/Rockchip SoC..., dri-devel

On 2015年07月01日 16:42, Tomasz Figa wrote:
> On Wed, Jul 1, 2015 at 5:32 PM, Mark yao <mark.yao@rock-chips.com> wrote:
>> On 2015年07月01日 16:03, Tomasz Figa wrote:
>>> Hi Mark,
>>>
>>> On Tue, Jun 30, 2015 at 3:50 PM, Mark yao <mark.yao@rock-chips.com> wrote:
>>>> Hi Dave.
>>>>
>>>>       Some fixes and some new features. I'd like you can pull them.
>>>>
>>>> The following changes since commit
>>>> c5fd936e992dd2829167d2adc63e151675ca6898:
>>>>
>>>>     drm/nouveau: Pause between setting gpu to D3hot and cutting the power
>>>> (2015-06-26 10:26:37 +1000)
>>>>
>>>> are available in the git repository at:
>>>>
>>>>     https://github.com/markyzq/kernel-drm-rockchip.git
>>>> drm-rockchip-2015-06-30
>>>>
>>>> for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:
>>>>
>>>>     drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10
>>>> +0800)
>>>>
>>>> ----------------------------------------------------------------
>>>> Heiko Stübner (1):
>>>>         drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper
>>>> present
>>>>
>>>> Mark Yao (6):
>>>>         drm/rockchip: import dma_buf to gem
>>>>         drm/rockchip: vop: optimize virtual stride calculate
>>>>         drm/rockchip: vop: fix yuv plane support
>>>>         drm/rockchip: vop: support plane scale
>>>>         drm/rockchip: vop: switch cursor plane to window 3
>>>>         drm/rockchip: default enable win2/3 area0 bit
>>> Has this series been reviewed properly? I can see that at least
>>> "drm/rockchip: vop: support plane scale" is kind of "controversial".
>>
>> Sorry for that, can you review those patches, and give me some advices?
>>
>> https://lkml.org/lkml/2015/6/18/77
>> v2: https://lkml.org/lkml/2015/6/26/192
>>
> Yes, will do that.
>
> By the way, please feel free to ping patches on the lists if they idle
> without any comments or tags for while.
>
>>> By the way, if we're using window 3 for cursor plane, because the
>>> cursor window needs special handling, is it okay to expose the cusor
>>> window as an overlay plane to userspace, as we do currently?
>>
>> special handling? what means? "switch cursor plane to window 3" patch only
>> switch cursor
>>   windows from win1 to win3. tag window 3 as DRM_PLANE_TYPE_CURSOR, userspace
>> only
>> can found window 3 is a cursor plane.
>>
> Ah, this was a question slightly unrelated to that patch, but I just
> noticed in that patch that the hardware cursor window is still exposed
> to the userspace as overlay plane, even if it's not quite suitable for
> being such.

Oh, I know your mean, you mean that code:
         { .base = 0x00, .phy = &cursor_data, .type = 
DRM_PLANE_TYPE_OVERLAY },

right?

That is I plan to do.

hardware cursor window have a problem that hard to resolved.
the window can't support width virtual and can't move out of left top top.
But linux desktop or chromiumos should move cursor out of left or top.

I'm considering remove it or find a another way to reuse it.

> Best regards,
> Tomasz
>
>
>


-- 
Mark


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [GIT PULL] drm/rockchip: fixes and new features
  2015-07-01  9:13       ` Mark yao
@ 2015-07-01  9:17         ` Tomasz Figa
  0 siblings, 0 replies; 13+ messages in thread
From: Tomasz Figa @ 2015-07-01  9:17 UTC (permalink / raw)
  To: Mark yao; +Cc: open list:ARM/Rockchip SoC..., dri-devel

On Wed, Jul 1, 2015 at 6:13 PM, Mark yao <mark.yao@rock-chips.com> wrote:
>>>> By the way, if we're using window 3 for cursor plane, because the
>>>> cursor window needs special handling, is it okay to expose the cusor
>>>> window as an overlay plane to userspace, as we do currently?
>>>
>>>
>>> special handling? what means? "switch cursor plane to window 3" patch
>>> only
>>> switch cursor
>>>   windows from win1 to win3. tag window 3 as DRM_PLANE_TYPE_CURSOR,
>>> userspace
>>> only
>>> can found window 3 is a cursor plane.
>>>
>> Ah, this was a question slightly unrelated to that patch, but I just
>> noticed in that patch that the hardware cursor window is still exposed
>> to the userspace as overlay plane, even if it's not quite suitable for
>> being such.
>
>
> Oh, I know your mean, you mean that code:
>         { .base = 0x00, .phy = &cursor_data, .type = DRM_PLANE_TYPE_OVERLAY
> },
>
> right?
>
> That is I plan to do.
>
> hardware cursor window have a problem that hard to resolved.
> the window can't support width virtual and can't move out of left top top.
> But linux desktop or chromiumos should move cursor out of left or top.
>
> I'm considering remove it or find a another way to reuse it.

I think we should remove it for now, because I believe this breaks
applications that enumerate all available planes and use them for
hardware compose. Otherwise they will try to use the hardware cursor
window and will fail, because hardware cursor window has quite strict
requirements.

Best regards,
Tomasz
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [GIT PULL] drm/rockchip: fixes and new features
  2015-07-27  2:05 [PATCH v4 0/6] " Mark Yao
  2015-08-26  6:34   ` Mark yao
@ 2015-08-26  6:34   ` Mark yao
  0 siblings, 0 replies; 13+ messages in thread
From: Mark yao @ 2015-08-26  6:34 UTC (permalink / raw)
  To: dri-devel
  Cc: zwl, linux-kernel, tfiga, linux-rockchip, dkm, sandy.huang,
	linux-arm-kernel

Hi Dave
     Here are some fixes and some new features for rockchip drm,
     tested on popmetal rk3288 board, can you land them?

The following changes since commit db56176025cee5e242dfeed5f4e304d095d29fa3:

   Revert "drm/atomic: Call ww_acquire_done after check phase is 
complete" (2015-08-25 17:23:36 +1000)

are available in the git repository at:

   https://github.com/markyzq/kernel-drm-rockchip.git 
drm-rockchip-2015-08-26

for you to fetch changes up to 4c156c21c7948a0be854cbe5914af3181303e529:

   drm/rockchip: vop: support plane scale (2015-08-26 14:16:26 +0800)

----------------------------------------------------------------
Mark Yao (6):
       drm/rockchip: vop: Fix virtual stride calculation
       drm/rockchip: vop: Fix window dest start point
       drm/rockchip: vop: Add yuv plane support
       drm/rockchip: vop: Default enable win2/3 area0 bit
       drm/rockchip: vop: restore vop registers when resume
       drm/rockchip: vop: support plane scale

  drivers/gpu/drm/rockchip/rockchip_drm_vop.c |  269 
++++++++++++++++++++++++++-
  drivers/gpu/drm/rockchip/rockchip_drm_vop.h |   88 +++++++++
  2 files changed, 348 insertions(+), 9 deletions(-)

-Mark

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [GIT PULL] drm/rockchip: fixes and new features
@ 2015-08-26  6:34   ` Mark yao
  0 siblings, 0 replies; 13+ messages in thread
From: Mark yao @ 2015-08-26  6:34 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Dave
     Here are some fixes and some new features for rockchip drm,
     tested on popmetal rk3288 board, can you land them?

The following changes since commit db56176025cee5e242dfeed5f4e304d095d29fa3:

   Revert "drm/atomic: Call ww_acquire_done after check phase is 
complete" (2015-08-25 17:23:36 +1000)

are available in the git repository at:

   https://github.com/markyzq/kernel-drm-rockchip.git 
drm-rockchip-2015-08-26

for you to fetch changes up to 4c156c21c7948a0be854cbe5914af3181303e529:

   drm/rockchip: vop: support plane scale (2015-08-26 14:16:26 +0800)

----------------------------------------------------------------
Mark Yao (6):
       drm/rockchip: vop: Fix virtual stride calculation
       drm/rockchip: vop: Fix window dest start point
       drm/rockchip: vop: Add yuv plane support
       drm/rockchip: vop: Default enable win2/3 area0 bit
       drm/rockchip: vop: restore vop registers when resume
       drm/rockchip: vop: support plane scale

  drivers/gpu/drm/rockchip/rockchip_drm_vop.c |  269 
++++++++++++++++++++++++++-
  drivers/gpu/drm/rockchip/rockchip_drm_vop.h |   88 +++++++++
  2 files changed, 348 insertions(+), 9 deletions(-)

-Mark

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [GIT PULL] drm/rockchip: fixes and new features
@ 2015-08-26  6:34   ` Mark yao
  0 siblings, 0 replies; 13+ messages in thread
From: Mark yao @ 2015-08-26  6:34 UTC (permalink / raw)
  To: dri-devel
  Cc: David Airlie, Heiko Stuebner, Daniel Kurtz, Philipp Zabel,
	Daniel Vetter, Rob Clark, tfiga, linux-arm-kernel, linux-rockchip,
	linux-kernel, sandy.huang, dkm, zwl

Hi Dave
     Here are some fixes and some new features for rockchip drm,
     tested on popmetal rk3288 board, can you land them?

The following changes since commit db56176025cee5e242dfeed5f4e304d095d29fa3:

   Revert "drm/atomic: Call ww_acquire_done after check phase is 
complete" (2015-08-25 17:23:36 +1000)

are available in the git repository at:

   https://github.com/markyzq/kernel-drm-rockchip.git 
drm-rockchip-2015-08-26

for you to fetch changes up to 4c156c21c7948a0be854cbe5914af3181303e529:

   drm/rockchip: vop: support plane scale (2015-08-26 14:16:26 +0800)

----------------------------------------------------------------
Mark Yao (6):
       drm/rockchip: vop: Fix virtual stride calculation
       drm/rockchip: vop: Fix window dest start point
       drm/rockchip: vop: Add yuv plane support
       drm/rockchip: vop: Default enable win2/3 area0 bit
       drm/rockchip: vop: restore vop registers when resume
       drm/rockchip: vop: support plane scale

  drivers/gpu/drm/rockchip/rockchip_drm_vop.c |  269 
++++++++++++++++++++++++++-
  drivers/gpu/drm/rockchip/rockchip_drm_vop.h |   88 +++++++++
  2 files changed, 348 insertions(+), 9 deletions(-)

-Mark


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2015-08-26  6:35 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-30  6:50 [GIT PULL] drm/rockchip: fixes and new features Mark yao
2015-07-01  8:03 ` Tomasz Figa
2015-07-01  8:20   ` Daniel Vetter
2015-07-01  8:32     ` Tomasz Figa
2015-07-01  8:56       ` Mark yao
2015-07-01  8:32   ` Mark yao
2015-07-01  8:42     ` Tomasz Figa
2015-07-01  9:13       ` Mark yao
2015-07-01  9:17         ` Tomasz Figa
2015-07-01  8:43     ` Mark yao
  -- strict thread matches above, loose matches on Subject: below --
2015-07-27  2:05 [PATCH v4 0/6] " Mark Yao
2015-08-26  6:34 ` [GIT PULL] " Mark yao
2015-08-26  6:34   ` Mark yao
2015-08-26  6:34   ` Mark yao

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.