All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sohny Thomas <sohnythomas@zoho.com>
To: benjamin.romer@unisys.com, david.kershner@unisys.com,
	bryan.thompson@unisys.com, erik.arfvidson@unisys.com,
	devel@driverdev.osuosl.org
Cc: gregkh@linuxfoundation.org, sparmaintainer@unisys.com,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue
Date: Tue, 30 Jun 2015 21:47:45 +0000	[thread overview]
Message-ID: <55930BB1.10502@zoho.com> (raw)


FIX 2 unnecessary braces found by checkpatch.pl

Signed-off-by: Sohny Thomas <sohnythomas@zoho.com>
---
 drivers/staging/unisys/virtpci/virtpci.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/unisys/virtpci/virtpci.c b/drivers/staging/unisys/virtpci/virtpci.c
index d5ad017..f3674de 100644
--- a/drivers/staging/unisys/virtpci/virtpci.c
+++ b/drivers/staging/unisys/virtpci/virtpci.c
@@ -190,9 +190,10 @@ static int write_vbus_chp_info(struct spar_vbus_channel_protocol *chan,
 		return -1;
 
 	off = sizeof(struct channel_header) + chan->hdr_info.chp_info_offset;
-	if (chan->hdr_info.chp_info_offset = 0) {
+
+	if (chan->hdr_info.chp_info_offset = 0)
 		return -1;
-	}
+
 	memcpy(((u8 *)(chan)) + off, info, sizeof(*info));
 	return 0;
 }
@@ -484,10 +485,10 @@ static int delete_vhba(struct del_virt_guestpart *delparams)
 
 	i = virtpci_device_del(NULL /*no parent bus */, VIRTHBA_TYPE,
 			       &scsi.wwnn, NULL);
-	if (i) {
+	if (i)
 		return 1;
-	}
-	return 0;
+	else
+		return 0;
 }
 
 /* deletes a vnic
-- 


WARNING: multiple messages have this Message-ID (diff)
From: Sohny Thomas <sohnythomas@zoho.com>
To: benjamin.romer@unisys.com, david.kershner@unisys.com,
	bryan.thompson@unisys.com, erik.arfvidson@unisys.com,
	devel@driverdev.osuosl.org
Cc: gregkh@linuxfoundation.org, sparmaintainer@unisys.com,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue
Date: Wed, 1 Jul 2015 03:05:45 +0530	[thread overview]
Message-ID: <55930BB1.10502@zoho.com> (raw)


FIX 2 unnecessary braces found by checkpatch.pl

Signed-off-by: Sohny Thomas <sohnythomas@zoho.com>
---
 drivers/staging/unisys/virtpci/virtpci.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/unisys/virtpci/virtpci.c b/drivers/staging/unisys/virtpci/virtpci.c
index d5ad017..f3674de 100644
--- a/drivers/staging/unisys/virtpci/virtpci.c
+++ b/drivers/staging/unisys/virtpci/virtpci.c
@@ -190,9 +190,10 @@ static int write_vbus_chp_info(struct spar_vbus_channel_protocol *chan,
 		return -1;
 
 	off = sizeof(struct channel_header) + chan->hdr_info.chp_info_offset;
-	if (chan->hdr_info.chp_info_offset == 0) {
+
+	if (chan->hdr_info.chp_info_offset == 0)
 		return -1;
-	}
+
 	memcpy(((u8 *)(chan)) + off, info, sizeof(*info));
 	return 0;
 }
@@ -484,10 +485,10 @@ static int delete_vhba(struct del_virt_guestpart *delparams)
 
 	i = virtpci_device_del(NULL /*no parent bus */, VIRTHBA_TYPE,
 			       &scsi.wwnn, NULL);
-	if (i) {
+	if (i)
 		return 1;
-	}
-	return 0;
+	else
+		return 0;
 }
 
 /* deletes a vnic
-- 


             reply	other threads:[~2015-06-30 21:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30 21:35 Sohny Thomas [this message]
2015-06-30 21:47 ` [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue Sohny Thomas
2015-07-01  6:57 ` Sudip Mukherjee
2015-07-01  6:58   ` Sudip Mukherjee
2015-07-01  7:36   ` Sohny Thomas
2015-07-01  7:48     ` Sohny Thomas
2015-07-01  8:01     ` Julia Lawall
2015-07-01  8:01       ` Julia Lawall
2015-07-01  9:20       ` Sohny Thomas
2015-07-01  9:32         ` Sohny Thomas
2015-07-01  9:35         ` Julia Lawall
2015-07-01  9:35           ` Julia Lawall
2015-07-01  8:02     ` Sudip Mukherjee
2015-07-01  8:14       ` Sudip Mukherjee
2015-07-01  8:34       ` Sohny Thomas
2015-07-01  8:46         ` Sohny Thomas
2015-07-01  9:15         ` Sudip Mukherjee
2015-07-01  9:27           ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55930BB1.10502@zoho.com \
    --to=sohnythomas@zoho.com \
    --cc=benjamin.romer@unisys.com \
    --cc=bryan.thompson@unisys.com \
    --cc=david.kershner@unisys.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=erik.arfvidson@unisys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparmaintainer@unisys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.