From: Sohny Thomas <sohnythomas@zoho.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
benjamin.romer@unisys.com, david.kershner@unisys.com,
bryan.thompson@unisys.com, erik.arfvidson@unisys.com,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
sparmaintainer@unisys.com, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue
Date: Wed, 01 Jul 2015 09:32:42 +0000 [thread overview]
Message-ID: <5593B0EA.1070101@zoho.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1507010959260.2374@hadrien>
>>>> i = virtpci_device_del(NULL /*no parent bus */, VIRTHBA_TYPE,
>>>> &scsi.wwnn, NULL);
>>>> - if (i) {
>>>> + if (i)
>>>> return 1;
>>>> - }
>>>> - return 0;
>>>> + else
>>>> + return 0;
>>> No, now this will introduce a new checkpatch warning that "else is not
>>> required after return". why did you introduce this "else"?
>> I did this so that the code is more readable and understandable, I checked and
>> checkpatch didn't call this out , so its clean.
>>
>> Otherwise the above code looks like this
>>
>> if(i)
>> return 1;
>> return 0;
>
> That looks fine.
>
> I haven't looked at the code in detail. Is it normal that the return
> values seem to be 0 1 and -1? Which values represent success and which
> represent an error? It is nicer to have the errors under if and success
> as a direct return at the end.
Here in this driver directory, return 1 means SUCCESS and return 0 means FAILURE
So you mean my code change is fine?
>
> julia
>
WARNING: multiple messages have this Message-ID (diff)
From: Sohny Thomas <sohnythomas@zoho.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
benjamin.romer@unisys.com, david.kershner@unisys.com,
bryan.thompson@unisys.com, erik.arfvidson@unisys.com,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
sparmaintainer@unisys.com, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue
Date: Wed, 1 Jul 2015 14:50:42 +0530 [thread overview]
Message-ID: <5593B0EA.1070101@zoho.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1507010959260.2374@hadrien>
>>>> i = virtpci_device_del(NULL /*no parent bus */, VIRTHBA_TYPE,
>>>> &scsi.wwnn, NULL);
>>>> - if (i) {
>>>> + if (i)
>>>> return 1;
>>>> - }
>>>> - return 0;
>>>> + else
>>>> + return 0;
>>> No, now this will introduce a new checkpatch warning that "else is not
>>> required after return". why did you introduce this "else"?
>> I did this so that the code is more readable and understandable, I checked and
>> checkpatch didn't call this out , so its clean.
>>
>> Otherwise the above code looks like this
>>
>> if(i)
>> return 1;
>> return 0;
>
> That looks fine.
>
> I haven't looked at the code in detail. Is it normal that the return
> values seem to be 0 1 and -1? Which values represent success and which
> represent an error? It is nicer to have the errors under if and success
> as a direct return at the end.
Here in this driver directory, return 1 means SUCCESS and return 0 means FAILURE
So you mean my code change is fine?
>
> julia
>
next prev parent reply other threads:[~2015-07-01 9:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 21:35 [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue Sohny Thomas
2015-06-30 21:47 ` Sohny Thomas
2015-07-01 6:57 ` Sudip Mukherjee
2015-07-01 6:58 ` Sudip Mukherjee
2015-07-01 7:36 ` Sohny Thomas
2015-07-01 7:48 ` Sohny Thomas
2015-07-01 8:01 ` Julia Lawall
2015-07-01 8:01 ` Julia Lawall
2015-07-01 9:20 ` Sohny Thomas [this message]
2015-07-01 9:32 ` Sohny Thomas
2015-07-01 9:35 ` Julia Lawall
2015-07-01 9:35 ` Julia Lawall
2015-07-01 8:02 ` Sudip Mukherjee
2015-07-01 8:14 ` Sudip Mukherjee
2015-07-01 8:34 ` Sohny Thomas
2015-07-01 8:46 ` Sohny Thomas
2015-07-01 9:15 ` Sudip Mukherjee
2015-07-01 9:27 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5593B0EA.1070101@zoho.com \
--to=sohnythomas@zoho.com \
--cc=benjamin.romer@unisys.com \
--cc=bryan.thompson@unisys.com \
--cc=david.kershner@unisys.com \
--cc=devel@driverdev.osuosl.org \
--cc=erik.arfvidson@unisys.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparmaintainer@unisys.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.