* [PATCH] drm/rockchip: vop: remove hardware cursor window @ 2015-07-01 9:49 ` Mark Yao 0 siblings, 0 replies; 8+ messages in thread From: Mark Yao @ 2015-07-01 9:49 UTC (permalink / raw) To: dri-devel Cc: zwl, linux-kernel, tfiga, linux-rockchip, xw, dkm, sandy.huang, linux-arm-kernel hardware cursor windows only have some fixed size, and not support width virtual, when move hardware cursor windows outside of left, the display would be wrong, so this window can't for cursor now. And Tag hardware cursor window as a overlay is wrong, will make userspace wrong behaviour. So just remove the hardware cursor window Signed-off-by: Mark Yao <mark.yao@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 4603412..7373ba1 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -368,7 +368,6 @@ static const struct vop_win_data rk3288_vop_win_data[] = { { .base = 0x40, .phy = &win01_data, .type = DRM_PLANE_TYPE_OVERLAY }, { .base = 0x00, .phy = &win23_data, .type = DRM_PLANE_TYPE_OVERLAY }, { .base = 0x50, .phy = &win23_data, .type = DRM_PLANE_TYPE_CURSOR }, - { .base = 0x00, .phy = &cursor_data, .type = DRM_PLANE_TYPE_OVERLAY }, }; static const struct vop_data rk3288_vop = { -- 1.7.9.5 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] drm/rockchip: vop: remove hardware cursor window @ 2015-07-01 9:49 ` Mark Yao 0 siblings, 0 replies; 8+ messages in thread From: Mark Yao @ 2015-07-01 9:49 UTC (permalink / raw) To: dri-devel Cc: David Airlie, Heiko Stuebner, Daniel Kurtz, Mark Yao, Philipp Zabel, Daniel Vetter, Rob Clark, tfiga, linux-arm-kernel, linux-rockchip, linux-kernel, sandy.huang, dkm, zwl, xw hardware cursor windows only have some fixed size, and not support width virtual, when move hardware cursor windows outside of left, the display would be wrong, so this window can't for cursor now. And Tag hardware cursor window as a overlay is wrong, will make userspace wrong behaviour. So just remove the hardware cursor window Signed-off-by: Mark Yao <mark.yao@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 4603412..7373ba1 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -368,7 +368,6 @@ static const struct vop_win_data rk3288_vop_win_data[] = { { .base = 0x40, .phy = &win01_data, .type = DRM_PLANE_TYPE_OVERLAY }, { .base = 0x00, .phy = &win23_data, .type = DRM_PLANE_TYPE_OVERLAY }, { .base = 0x50, .phy = &win23_data, .type = DRM_PLANE_TYPE_CURSOR }, - { .base = 0x00, .phy = &cursor_data, .type = DRM_PLANE_TYPE_OVERLAY }, }; static const struct vop_data rk3288_vop = { -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] drm/rockchip: vop: remove hardware cursor window @ 2015-07-01 9:49 ` Mark Yao 0 siblings, 0 replies; 8+ messages in thread From: Mark Yao @ 2015-07-01 9:49 UTC (permalink / raw) To: linux-arm-kernel hardware cursor windows only have some fixed size, and not support width virtual, when move hardware cursor windows outside of left, the display would be wrong, so this window can't for cursor now. And Tag hardware cursor window as a overlay is wrong, will make userspace wrong behaviour. So just remove the hardware cursor window Signed-off-by: Mark Yao <mark.yao@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 4603412..7373ba1 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -368,7 +368,6 @@ static const struct vop_win_data rk3288_vop_win_data[] = { { .base = 0x40, .phy = &win01_data, .type = DRM_PLANE_TYPE_OVERLAY }, { .base = 0x00, .phy = &win23_data, .type = DRM_PLANE_TYPE_OVERLAY }, { .base = 0x50, .phy = &win23_data, .type = DRM_PLANE_TYPE_CURSOR }, - { .base = 0x00, .phy = &cursor_data, .type = DRM_PLANE_TYPE_OVERLAY }, }; static const struct vop_data rk3288_vop = { -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/rockchip: vop: remove hardware cursor window 2015-07-01 9:49 ` Mark Yao (?) @ 2015-07-01 11:52 ` Heiko Stübner -1 siblings, 0 replies; 8+ messages in thread From: Heiko Stübner @ 2015-07-01 11:52 UTC (permalink / raw) To: Mark Yao Cc: zwl, linux-kernel, tfiga, linux-rockchip, dri-devel, xw, dkm, sandy.huang, linux-arm-kernel Hi Mark, Am Mittwoch, 1. Juli 2015, 17:49:33 schrieb Mark Yao: > hardware cursor windows only have some fixed size, and not support > width virtual, when move hardware cursor windows outside of left, > the display would be wrong, so this window can't for cursor now. > > And Tag hardware cursor window as a overlay is wrong, will make > userspace wrong behaviour. > > So just remove the hardware cursor window > > Signed-off-by: Mark Yao <mark.yao@rock-chips.com> > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 4603412..7373ba1 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -368,7 +368,6 @@ static const struct vop_win_data rk3288_vop_win_data[] = > { { .base = 0x40, .phy = &win01_data, .type = DRM_PLANE_TYPE_OVERLAY }, { > .base = 0x00, .phy = &win23_data, .type = DRM_PLANE_TYPE_OVERLAY }, { .base > = 0x50, .phy = &win23_data, .type = DRM_PLANE_TYPE_CURSOR }, - { .base = > 0x00, .phy = &cursor_data, .type = DRM_PLANE_TYPE_OVERLAY }, }; > > static const struct vop_data rk3288_vop = { you should probably also remove the static const struct vop_win_phy cursor_data completely then, as it is now unused? Heiko _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/rockchip: vop: remove hardware cursor window @ 2015-07-01 11:52 ` Heiko Stübner 0 siblings, 0 replies; 8+ messages in thread From: Heiko Stübner @ 2015-07-01 11:52 UTC (permalink / raw) To: Mark Yao Cc: dri-devel, David Airlie, Daniel Kurtz, Philipp Zabel, Daniel Vetter, Rob Clark, tfiga, linux-arm-kernel, linux-rockchip, linux-kernel, sandy.huang, dkm, zwl, xw Hi Mark, Am Mittwoch, 1. Juli 2015, 17:49:33 schrieb Mark Yao: > hardware cursor windows only have some fixed size, and not support > width virtual, when move hardware cursor windows outside of left, > the display would be wrong, so this window can't for cursor now. > > And Tag hardware cursor window as a overlay is wrong, will make > userspace wrong behaviour. > > So just remove the hardware cursor window > > Signed-off-by: Mark Yao <mark.yao@rock-chips.com> > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 4603412..7373ba1 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -368,7 +368,6 @@ static const struct vop_win_data rk3288_vop_win_data[] = > { { .base = 0x40, .phy = &win01_data, .type = DRM_PLANE_TYPE_OVERLAY }, { > .base = 0x00, .phy = &win23_data, .type = DRM_PLANE_TYPE_OVERLAY }, { .base > = 0x50, .phy = &win23_data, .type = DRM_PLANE_TYPE_CURSOR }, - { .base = > 0x00, .phy = &cursor_data, .type = DRM_PLANE_TYPE_OVERLAY }, }; > > static const struct vop_data rk3288_vop = { you should probably also remove the static const struct vop_win_phy cursor_data completely then, as it is now unused? Heiko ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drm/rockchip: vop: remove hardware cursor window @ 2015-07-01 11:52 ` Heiko Stübner 0 siblings, 0 replies; 8+ messages in thread From: Heiko Stübner @ 2015-07-01 11:52 UTC (permalink / raw) To: linux-arm-kernel Hi Mark, Am Mittwoch, 1. Juli 2015, 17:49:33 schrieb Mark Yao: > hardware cursor windows only have some fixed size, and not support > width virtual, when move hardware cursor windows outside of left, > the display would be wrong, so this window can't for cursor now. > > And Tag hardware cursor window as a overlay is wrong, will make > userspace wrong behaviour. > > So just remove the hardware cursor window > > Signed-off-by: Mark Yao <mark.yao@rock-chips.com> > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 4603412..7373ba1 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -368,7 +368,6 @@ static const struct vop_win_data rk3288_vop_win_data[] = > { { .base = 0x40, .phy = &win01_data, .type = DRM_PLANE_TYPE_OVERLAY }, { > .base = 0x00, .phy = &win23_data, .type = DRM_PLANE_TYPE_OVERLAY }, { .base > = 0x50, .phy = &win23_data, .type = DRM_PLANE_TYPE_CURSOR }, - { .base = > 0x00, .phy = &cursor_data, .type = DRM_PLANE_TYPE_OVERLAY }, }; > > static const struct vop_data rk3288_vop = { you should probably also remove the static const struct vop_win_phy cursor_data completely then, as it is now unused? Heiko ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/rockchip: vop: remove hardware cursor window 2015-07-01 11:52 ` Heiko Stübner @ 2015-07-02 7:03 ` Mark yao -1 siblings, 0 replies; 8+ messages in thread From: Mark yao @ 2015-07-02 7:03 UTC (permalink / raw) To: Heiko Stübner Cc: dri-devel, David Airlie, Daniel Kurtz, Philipp Zabel, Daniel Vetter, Rob Clark, tfiga, linux-arm-kernel, linux-rockchip, linux-kernel, sandy.huang, dkm, zwl, xw On 2015年07月01日 19:52, Heiko Stübner wrote: > Hi Mark, > > Am Mittwoch, 1. Juli 2015, 17:49:33 schrieb Mark Yao: >> hardware cursor windows only have some fixed size, and not support >> width virtual, when move hardware cursor windows outside of left, >> the display would be wrong, so this window can't for cursor now. >> >> And Tag hardware cursor window as a overlay is wrong, will make >> userspace wrong behaviour. >> >> So just remove the hardware cursor window >> >> Signed-off-by: Mark Yao <mark.yao@rock-chips.com> >> --- >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 4603412..7373ba1 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> @@ -368,7 +368,6 @@ static const struct vop_win_data rk3288_vop_win_data[] = >> { { .base = 0x40, .phy = &win01_data, .type = DRM_PLANE_TYPE_OVERLAY }, { >> .base = 0x00, .phy = &win23_data, .type = DRM_PLANE_TYPE_OVERLAY }, { .base >> = 0x50, .phy = &win23_data, .type = DRM_PLANE_TYPE_CURSOR }, - { .base = >> 0x00, .phy = &cursor_data, .type = DRM_PLANE_TYPE_OVERLAY }, }; >> >> static const struct vop_data rk3288_vop = { > you should probably also remove the > > static const struct vop_win_phy cursor_data > > completely then, as it is now unused? > > > Heiko > > > OK -- Ｍark ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drm/rockchip: vop: remove hardware cursor window @ 2015-07-02 7:03 ` Mark yao 0 siblings, 0 replies; 8+ messages in thread From: Mark yao @ 2015-07-02 7:03 UTC (permalink / raw) To: linux-arm-kernel On 2015?07?01? 19:52, Heiko St?bner wrote: > Hi Mark, > > Am Mittwoch, 1. Juli 2015, 17:49:33 schrieb Mark Yao: >> hardware cursor windows only have some fixed size, and not support >> width virtual, when move hardware cursor windows outside of left, >> the display would be wrong, so this window can't for cursor now. >> >> And Tag hardware cursor window as a overlay is wrong, will make >> userspace wrong behaviour. >> >> So just remove the hardware cursor window >> >> Signed-off-by: Mark Yao <mark.yao@rock-chips.com> >> --- >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 4603412..7373ba1 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> @@ -368,7 +368,6 @@ static const struct vop_win_data rk3288_vop_win_data[] = >> { { .base = 0x40, .phy = &win01_data, .type = DRM_PLANE_TYPE_OVERLAY }, { >> .base = 0x00, .phy = &win23_data, .type = DRM_PLANE_TYPE_OVERLAY }, { .base >> = 0x50, .phy = &win23_data, .type = DRM_PLANE_TYPE_CURSOR }, - { .base = >> 0x00, .phy = &cursor_data, .type = DRM_PLANE_TYPE_OVERLAY }, }; >> >> static const struct vop_data rk3288_vop = { > you should probably also remove the > > static const struct vop_win_phy cursor_data > > completely then, as it is now unused? > > > Heiko > > > OK -- ?ark ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-07-02 7:03 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-07-01 9:49 [PATCH] drm/rockchip: vop: remove hardware cursor window Mark Yao 2015-07-01 9:49 ` Mark Yao 2015-07-01 9:49 ` Mark Yao 2015-07-01 11:52 ` Heiko Stübner 2015-07-01 11:52 ` Heiko Stübner 2015-07-01 11:52 ` Heiko Stübner 2015-07-02 7:03 ` Mark yao 2015-07-02 7:03 ` Mark yao
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.