All of lore.kernel.org
 help / color / mirror / Atom feed
From: Terje Bergstrom <tbergstrom@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] gpu: host1x: Fix MLOCK's debug info
Date: Thu, 2 Jul 2015 14:15:01 -0700	[thread overview]
Message-ID: <5595A9D5.5000209@nvidia.com> (raw)
In-Reply-To: <1435519624-16444-1-git-send-email-digetx@gmail.com>


On 06/28/2015 12:27 PM, Dmitry Osipenko wrote:
> MLOCK's debug info, spewed on CDMA timeout, contains meaningless MLOCK
> owner channel ID because HOST1X_SYNC_MLOCK_OWNER_CHID_F() returns shifted
> value, while unshifted should be used. Fix it by changing '_F' to '_V'.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>   drivers/gpu/host1x/hw/debug_hw.c         | 2 +-
>   drivers/gpu/host1x/hw/hw_host1x01_sync.h | 8 ++++----
>   drivers/gpu/host1x/hw/hw_host1x02_sync.h | 8 ++++----
>   drivers/gpu/host1x/hw/hw_host1x04_sync.h | 8 ++++----
>   4 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/host1x/hw/debug_hw.c b/drivers/gpu/host1x/hw/debug_hw.c
> index 791de93..cc3f182 100644
> --- a/drivers/gpu/host1x/hw/debug_hw.c
> +++ b/drivers/gpu/host1x/hw/debug_hw.c
> @@ -298,7 +298,7 @@ static void host1x_debug_show_mlocks(struct host1x *host, struct output *o)
>   			host1x_sync_readl(host, HOST1X_SYNC_MLOCK_OWNER(i));
>   		if (HOST1X_SYNC_MLOCK_OWNER_CH_OWNS_V(owner))
>   			host1x_debug_output(o, "%d: locked by channel %d\n",
> -				i, HOST1X_SYNC_MLOCK_OWNER_CHID_F(owner));
> +				i, HOST1X_SYNC_MLOCK_OWNER_CHID_V(owner));
>   		else if (HOST1X_SYNC_MLOCK_OWNER_CPU_OWNS_V(owner))
>   			host1x_debug_output(o, "%d: locked by cpu\n", i);
>   		else
(...)

Looks good, and fixes a bad gotcha.

Reviewed-By: Terje Bergstrom <tbergstrom@nvidia.com>

Terje
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Terje Bergstrom <tbergstrom@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>
Cc: <dri-devel@lists.freedesktop.org>, <linux-tegra@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpu: host1x: Fix MLOCK's debug info
Date: Thu, 2 Jul 2015 14:15:01 -0700	[thread overview]
Message-ID: <5595A9D5.5000209@nvidia.com> (raw)
In-Reply-To: <1435519624-16444-1-git-send-email-digetx@gmail.com>


On 06/28/2015 12:27 PM, Dmitry Osipenko wrote:
> MLOCK's debug info, spewed on CDMA timeout, contains meaningless MLOCK
> owner channel ID because HOST1X_SYNC_MLOCK_OWNER_CHID_F() returns shifted
> value, while unshifted should be used. Fix it by changing '_F' to '_V'.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>   drivers/gpu/host1x/hw/debug_hw.c         | 2 +-
>   drivers/gpu/host1x/hw/hw_host1x01_sync.h | 8 ++++----
>   drivers/gpu/host1x/hw/hw_host1x02_sync.h | 8 ++++----
>   drivers/gpu/host1x/hw/hw_host1x04_sync.h | 8 ++++----
>   4 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/host1x/hw/debug_hw.c b/drivers/gpu/host1x/hw/debug_hw.c
> index 791de93..cc3f182 100644
> --- a/drivers/gpu/host1x/hw/debug_hw.c
> +++ b/drivers/gpu/host1x/hw/debug_hw.c
> @@ -298,7 +298,7 @@ static void host1x_debug_show_mlocks(struct host1x *host, struct output *o)
>   			host1x_sync_readl(host, HOST1X_SYNC_MLOCK_OWNER(i));
>   		if (HOST1X_SYNC_MLOCK_OWNER_CH_OWNS_V(owner))
>   			host1x_debug_output(o, "%d: locked by channel %d\n",
> -				i, HOST1X_SYNC_MLOCK_OWNER_CHID_F(owner));
> +				i, HOST1X_SYNC_MLOCK_OWNER_CHID_V(owner));
>   		else if (HOST1X_SYNC_MLOCK_OWNER_CPU_OWNS_V(owner))
>   			host1x_debug_output(o, "%d: locked by cpu\n", i);
>   		else
(...)

Looks good, and fixes a bad gotcha.

Reviewed-By: Terje Bergstrom <tbergstrom@nvidia.com>

Terje

  reply	other threads:[~2015-07-02 21:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-28 19:27 [PATCH] gpu: host1x: Fix MLOCK's debug info Dmitry Osipenko
2015-06-28 19:27 ` Dmitry Osipenko
2015-07-02 21:15 ` Terje Bergstrom [this message]
2015-07-02 21:15   ` Terje Bergstrom
     [not found] ` <1435519624-16444-1-git-send-email-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-07  9:22   ` Dmitry Osipenko
2015-09-07  9:22     ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5595A9D5.5000209@nvidia.com \
    --to=tbergstrom@nvidia.com \
    --cc=digetx@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.