All of lore.kernel.org
 help / color / mirror / Atom feed
From: periyasa@codeaurora.org
To: Adrian Chadd <adrian@freebsd.org>
Cc: adrian.chadd@gmail.com, linux-wireless@vger.kernel.org,
	ath10k@lists.infradead.org
Subject: Re: [PATCH] Revert "ath10k: send (re)assoc peer command when NSS changed"
Date: Mon, 26 Feb 2018 16:11:38 +0530	[thread overview]
Message-ID: <559965cc9735f6616957f9ee84a17e52@codeaurora.org> (raw)
In-Reply-To: <CAJ-Vmo=xxG_Jp=uC-Cx96R0YzO8O0tOVe2G6Nyx8ceWopiwvXQ@mail.gmail.com>

On 2018-02-26 14:15, Adrian Chadd wrote:
> hi!
> 
> On 25 February 2018 at 22:16, Karthikeyan Periyasamy
> <periyasa@codeaurora.org> wrote:
>> This reverts commit 55884c045d31a29cf69db8332d1064a1b61dd159.
>> 
>> When Ath10k is in AP mode and an unassociated STA sends a VHT action 
>> frame
>> (Operating Mode Notification for the NSS change) periodically to AP 
>> this causes
>> ath10k to call ath10k_station_assoc() which sends WMI_PEER_ASSOC_CMDID 
>> during
>> NSS update. Over the time (with a certain client it can happen within 
>> 15 mins
>> when there are over 500 of these VHT action frames) continuous calls 
>> of
>> WMI_PEER_ASSOC_CMDID cause firmware to assert due to resource exhaust.
>> 
>> To my knowledge setting WMI_PEER_NSS peer param itself enough to 
>> handle NSS
>> updates and no need to call ath10k_station_assoc(). So revert the 
>> original
>> commit from 2014 as it's unclear why the change was really needed.
>> Now the firmware assert doesn't happen anymore.
>> 
>> Issue observed in QCA9984 platform with firmware 
>> version:10.4-3.5.3-00053.
>> This Change tested in QCA9984 with firmware version: 10.4-3.5.3-00053 
>> and
>> QCA988x platform with firmware version: 10.2.4-1.0-00036.
> 
> Did you test this on any of the other major firmware variants? I
> wonder if it snuck in because of some firmware quirk in something way
> before dakota/cascade and 10.4 were a thing.
> 
> Eg, Peregrine? Rome? Maybe even earlier Beeliner, just to double check?
> 
Yes. I tested this on peregrine, Beeliner, Dakota and Cascade. This code 
was introduced before Rome.

Thanks,
Karthikeyan.

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: periyasa@codeaurora.org
To: Adrian Chadd <adrian@freebsd.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	adrian.chadd@gmail.com
Subject: Re: [PATCH] Revert "ath10k: send (re)assoc peer command when NSS changed"
Date: Mon, 26 Feb 2018 16:11:38 +0530	[thread overview]
Message-ID: <559965cc9735f6616957f9ee84a17e52@codeaurora.org> (raw)
In-Reply-To: <CAJ-Vmo=xxG_Jp=uC-Cx96R0YzO8O0tOVe2G6Nyx8ceWopiwvXQ@mail.gmail.com>

On 2018-02-26 14:15, Adrian Chadd wrote:
> hi!
> 
> On 25 February 2018 at 22:16, Karthikeyan Periyasamy
> <periyasa@codeaurora.org> wrote:
>> This reverts commit 55884c045d31a29cf69db8332d1064a1b61dd159.
>> 
>> When Ath10k is in AP mode and an unassociated STA sends a VHT action 
>> frame
>> (Operating Mode Notification for the NSS change) periodically to AP 
>> this causes
>> ath10k to call ath10k_station_assoc() which sends WMI_PEER_ASSOC_CMDID 
>> during
>> NSS update. Over the time (with a certain client it can happen within 
>> 15 mins
>> when there are over 500 of these VHT action frames) continuous calls 
>> of
>> WMI_PEER_ASSOC_CMDID cause firmware to assert due to resource exhaust.
>> 
>> To my knowledge setting WMI_PEER_NSS peer param itself enough to 
>> handle NSS
>> updates and no need to call ath10k_station_assoc(). So revert the 
>> original
>> commit from 2014 as it's unclear why the change was really needed.
>> Now the firmware assert doesn't happen anymore.
>> 
>> Issue observed in QCA9984 platform with firmware 
>> version:10.4-3.5.3-00053.
>> This Change tested in QCA9984 with firmware version: 10.4-3.5.3-00053 
>> and
>> QCA988x platform with firmware version: 10.2.4-1.0-00036.
> 
> Did you test this on any of the other major firmware variants? I
> wonder if it snuck in because of some firmware quirk in something way
> before dakota/cascade and 10.4 were a thing.
> 
> Eg, Peregrine? Rome? Maybe even earlier Beeliner, just to double check?
> 
Yes. I tested this on peregrine, Beeliner, Dakota and Cascade. This code 
was introduced before Rome.

Thanks,
Karthikeyan.

  reply	other threads:[~2018-02-26 10:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26  6:16 [PATCH] Revert "ath10k: send (re)assoc peer command when NSS changed" Karthikeyan Periyasamy
2018-02-26  6:16 ` Karthikeyan Periyasamy
2018-02-26  8:45 ` Adrian Chadd
2018-02-26  8:45   ` Adrian Chadd
2018-02-26 10:41   ` periyasa [this message]
2018-02-26 10:41     ` periyasa
2018-02-26 15:56 ` Ben Greear
2018-02-26 15:56   ` Ben Greear
2018-02-26 17:06   ` periyasa
2018-02-26 17:06     ` periyasa
2018-02-26 19:21     ` Adrian Chadd
2018-02-26 19:21       ` Adrian Chadd
2018-02-27  4:00       ` periyasa
2018-02-27  4:00         ` periyasa
2018-02-26 19:17 ` Peter Oh
2018-02-26 19:17   ` Peter Oh
2018-02-27  8:49 ` fixed bit rate 9Mbps set as 24Mbps in g mode(legacy) KAVITA MATHUR
2018-02-27  8:49   ` KAVITA MATHUR
2018-02-27  8:49   ` KAVITA MATHUR
2018-02-27 16:41   ` Ben Greear
2018-02-27 16:41     ` Ben Greear
2018-02-27 16:41     ` Ben Greear
2018-02-28  4:03     ` KAVITA MATHUR
2018-02-28 19:43       ` Ben Greear
2018-02-28 19:43         ` Ben Greear
2018-02-28 19:43         ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559965cc9735f6616957f9ee84a17e52@codeaurora.org \
    --to=periyasa@codeaurora.org \
    --cc=adrian.chadd@gmail.com \
    --cc=adrian@freebsd.org \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.