All of lore.kernel.org
 help / color / mirror / Atom feed
From: periyasa@codeaurora.org
To: Adrian Chadd <adrian@freebsd.org>
Cc: adrian.chadd@gmail.com, Ben Greear <greearb@candelatech.com>,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] Revert "ath10k: send (re)assoc peer command when NSS changed"
Date: Tue, 27 Feb 2018 09:30:14 +0530	[thread overview]
Message-ID: <83292eb1f9fe6bd2ee9ef82e80693388@codeaurora.org> (raw)
In-Reply-To: <CAJ-VmokdboP37J8csaj=xKOpiXDxXfF7wrv+cdJp+UCYFjtU_g@mail.gmail.com>

Hi,

This is not a bug, Firmware treats every WMI_PEER_ASSOC_CMDID as a new 
peer assoc. so driver should not give WMI_PEER_ASSOC_CMDID for the 
already associated peer.
For the NSS update, wmi_peer_set_param is enough to update the new NSS 
value.

Regards,
Karthikeyan P.

On 2018-02-27 00:51, Adrian Chadd wrote:
> hi,
> 
> so it's going to eventually leak? Can we fix the firmware bug too? :)
> 
> 
> -a
> 
> 
> On 26 February 2018 at 09:06,  <periyasa@codeaurora.org> wrote:
>> Hi,
>> 
>> 
>>> Can you share exactly which resource the firmware ran out of?  It 
>>> would
>>> seem to
>>> be a FW bug if it is leaking, so maybe it can be fixed as well...
>>> 
>> 
>> Firmware have total user_id = 528 (512 clients + 16 VAPs). Each 
>> user_id is
>> allocated to peer when Firmware receive the WMI_PEER_ASSOC_CMDID 
>> request
>> from host driver. Firmware free the user_id in peer delete operation.
>> 
>> Regards,
>> Karthikeyan P.
>> 
>> _______________________________________________
>> ath10k mailing list
>> ath10k@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/ath10k

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: periyasa@codeaurora.org
To: Adrian Chadd <adrian@freebsd.org>
Cc: Ben Greear <greearb@candelatech.com>,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
	adrian.chadd@gmail.com
Subject: Re: [PATCH] Revert "ath10k: send (re)assoc peer command when NSS changed"
Date: Tue, 27 Feb 2018 09:30:14 +0530	[thread overview]
Message-ID: <83292eb1f9fe6bd2ee9ef82e80693388@codeaurora.org> (raw)
In-Reply-To: <CAJ-VmokdboP37J8csaj=xKOpiXDxXfF7wrv+cdJp+UCYFjtU_g@mail.gmail.com>

Hi,

This is not a bug, Firmware treats every WMI_PEER_ASSOC_CMDID as a new 
peer assoc. so driver should not give WMI_PEER_ASSOC_CMDID for the 
already associated peer.
For the NSS update, wmi_peer_set_param is enough to update the new NSS 
value.

Regards,
Karthikeyan P.

On 2018-02-27 00:51, Adrian Chadd wrote:
> hi,
> 
> so it's going to eventually leak? Can we fix the firmware bug too? :)
> 
> 
> -a
> 
> 
> On 26 February 2018 at 09:06,  <periyasa@codeaurora.org> wrote:
>> Hi,
>> 
>> 
>>> Can you share exactly which resource the firmware ran out of?  It 
>>> would
>>> seem to
>>> be a FW bug if it is leaking, so maybe it can be fixed as well...
>>> 
>> 
>> Firmware have total user_id = 528 (512 clients + 16 VAPs). Each 
>> user_id is
>> allocated to peer when Firmware receive the WMI_PEER_ASSOC_CMDID 
>> request
>> from host driver. Firmware free the user_id in peer delete operation.
>> 
>> Regards,
>> Karthikeyan P.
>> 
>> _______________________________________________
>> ath10k mailing list
>> ath10k@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2018-02-27  4:00 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26  6:16 [PATCH] Revert "ath10k: send (re)assoc peer command when NSS changed" Karthikeyan Periyasamy
2018-02-26  6:16 ` Karthikeyan Periyasamy
2018-02-26  8:45 ` Adrian Chadd
2018-02-26  8:45   ` Adrian Chadd
2018-02-26 10:41   ` periyasa
2018-02-26 10:41     ` periyasa
2018-02-26 15:56 ` Ben Greear
2018-02-26 15:56   ` Ben Greear
2018-02-26 17:06   ` periyasa
2018-02-26 17:06     ` periyasa
2018-02-26 19:21     ` Adrian Chadd
2018-02-26 19:21       ` Adrian Chadd
2018-02-27  4:00       ` periyasa [this message]
2018-02-27  4:00         ` periyasa
2018-02-26 19:17 ` Peter Oh
2018-02-26 19:17   ` Peter Oh
2018-02-27  8:49 ` fixed bit rate 9Mbps set as 24Mbps in g mode(legacy) KAVITA MATHUR
2018-02-27  8:49   ` KAVITA MATHUR
2018-02-27  8:49   ` KAVITA MATHUR
2018-02-27 16:41   ` Ben Greear
2018-02-27 16:41     ` Ben Greear
2018-02-27 16:41     ` Ben Greear
2018-02-28  4:03     ` KAVITA MATHUR
2018-02-28 19:43       ` Ben Greear
2018-02-28 19:43         ` Ben Greear
2018-02-28 19:43         ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83292eb1f9fe6bd2ee9ef82e80693388@codeaurora.org \
    --to=periyasa@codeaurora.org \
    --cc=adrian.chadd@gmail.com \
    --cc=adrian@freebsd.org \
    --cc=ath10k@lists.infradead.org \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.