Re: [lm-sensors] hwmon: (f71882fg) Add f81866/f71868 SuperIO support

Re: [lm-sensors] hwmon: (f71882fg) Add f81866/f71868 SuperIO support

[Dan Carpenter]

Hello Peter Hung,

The patch b7bca9b681e3: "hwmon: (f71882fg) Add f81866/f71868 SuperIO
support" from Jun 30, 2015, leads to the following static checker
warning:

	drivers/hwmon/f71882fg.c:2425 f71882fg_probe()
	warn: buffer overflow 'fxxxx_in_attr' 9 <= 9

drivers/hwmon/f71882fg.c
  2422                  for (i = 0; i < F71882FG_MAX_INS; i++) {
                                        ^^^^^^^^^^^^^^^^
We increased this from 9 to 10.

  2423                          if (f71882fg_has_in[data->type][i]) {
  2424                                  err = device_create_file(&pdev->dev,
  2425                                                  &fxxxx_in_attr[i].dev_attr);
                                                         ^^^^^^^^^^^^^^^^
But this array still only has 9 elements.

  2426                                  if (err)
  2427                                          goto exit_unregister_sysfs;
  2428                          }
  2429                  }

regards,
dan carpenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] hwmon: (f71882fg) Add f81866/f71868 SuperIO support

[Guenter Roeck]

On 07/06/2015 08:35 AM, Dan Carpenter wrote:
> Hello Peter Hung,
>
> The patch b7bca9b681e3: "hwmon: (f71882fg) Add f81866/f71868 SuperIO
> support" from Jun 30, 2015, leads to the following static checker
> warning:
>
> 	drivers/hwmon/f71882fg.c:2425 f71882fg_probe()
> 	warn: buffer overflow 'fxxxx_in_attr' 9 <= 9
>
> drivers/hwmon/f71882fg.c
>    2422                  for (i = 0; i < F71882FG_MAX_INS; i++) {
>                                          ^^^^^^^^^^^^^^^^
> We increased this from 9 to 10.
>
>    2423                          if (f71882fg_has_in[data->type][i]) {
>    2424                                  err = device_create_file(&pdev->dev,
>    2425                                                  &fxxxx_in_attr[i].dev_attr);
>                                                           ^^^^^^^^^^^^^^^^
> But this array still only has 9 elements.
>
>    2426                                  if (err)
>    2427                                          goto exit_unregister_sysfs;
>    2428                          }
>    2429                  }
>

Peter,

easy to fix, and annoying that I didn't catch it earlier.

I decided to pull the entire series, since you obviously
did not test the code. When you resubmit, please let me know
how you tested it.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] hwmon: (f71882fg) Add f81866/f71868 SuperIO support

[Peter Hung]

SGkgRGFuLAoKRGFuIENhcnBlbnRlciCp8yAyMDE1LzcvNiCkVaTIIDExOjM1ILxnuUQ6Cj4gQnV0
IHRoaXMgYXJyYXkgc3RpbGwgb25seSBoYXMgOSBlbGVtZW50cy4KPiAKPiAgICAyNDI2ICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChlcnIpCj4gICAgMjQyNyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdvdG8gZXhpdF91bnJlZ2lzdGVyX3N5c2Zz
Owo+ICAgIDI0MjggICAgICAgICAgICAgICAgICAgICAgICAgIH0KPiAgICAyNDI5ICAgICAgICAg
ICAgICAgICAgfQoKQ291bGQgeW91IHRlbGwgbWUgd2hhdCBzdGF0aWMgY29kZSBhbmFseXNpcyB0
b29scwpkaWQgeW91IHVzZSB0byBnZW5lcmF0ZSB0aGlzIHJlcG9ydD8KCkkgaGFkIHRyaWVkIHdp
dGggc3BhcnNlIGFuZCB1c2UgbWFrZSBDPTIgPGRyaXZlciBkaXI+CmJ1dCBJIGdvdCBubyB3YXJu
aW5nLgoKLS0gCldpdGggQmVzdCBSZWdhcmRzLApQZXRlciBIdW5nCgpfX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsbS1zZW5zb3JzIG1haWxpbmcgbGlzdAps
bS1zZW5zb3JzQGxtLXNlbnNvcnMub3JnCmh0dHA6Ly9saXN0cy5sbS1zZW5zb3JzLm9yZy9tYWls
bWFuL2xpc3RpbmZvL2xtLXNlbnNvcnM

Re: [lm-sensors] hwmon: (f71882fg) Add f81866/f71868 SuperIO support

[Peter Hung]

Hi Guenter,

> easy to fix, and annoying that I didn't catch it earlier.
>
> I decided to pull the entire series, since you obviously
> did not test the code. When you resubmit, please let me know
> how you tested it.

I'll take more tests with this series patch.
Sorry for my mistakes.

-- 
With Best Regards,
Peter Hung

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] hwmon: (f71882fg) Add f81866/f71868 SuperIO support

[Guenter Roeck]

T24gMDcvMDYvMjAxNSAwNjoxOSBQTSwgUGV0ZXIgSHVuZyB3cm90ZToKPiBIaSBEYW4sCj4gCj4g
RGFuIENhcnBlbnRlciCp8yAyMDE1LzcvNiCkVaTIIDExOjM1ILxnuUQ6Cj4+IEJ1dCB0aGlzIGFy
cmF5IHN0aWxsIG9ubHkgaGFzIDkgZWxlbWVudHMuCj4+Cj4+ICAgICAyNDI2ICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIGlmIChlcnIpCj4+ICAgICAyNDI3ICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgZ290byBleGl0X3VucmVnaXN0ZXJfc3lzZnM7Cj4+
ICAgICAyNDI4ICAgICAgICAgICAgICAgICAgICAgICAgICB9Cj4+ICAgICAyNDI5ICAgICAgICAg
ICAgICAgICAgfQo+IAo+IENvdWxkIHlvdSB0ZWxsIG1lIHdoYXQgc3RhdGljIGNvZGUgYW5hbHlz
aXMgdG9vbHMKPiBkaWQgeW91IHVzZSB0byBnZW5lcmF0ZSB0aGlzIHJlcG9ydD8KPiAKPiBJIGhh
ZCB0cmllZCB3aXRoIHNwYXJzZSBhbmQgdXNlIG1ha2UgQz0yIDxkcml2ZXIgZGlyPgo+IGJ1dCBJ
IGdvdCBubyB3YXJuaW5nLgo+IApIaSBQZXRlciwKClRoaXMgaXMgd2l0aCBzbWF0Y2guCgptYWtl
IEM9MSBDSEVDSz0icGF0aC10by1zbWF0Y2ggLS1wcm9qZWN0PWtlcm5lbCIgZmlsZW5hbWUKCkd1
ZW50ZXIKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps
bS1zZW5zb3JzIG1haWxpbmcgbGlzdApsbS1zZW5zb3JzQGxtLXNlbnNvcnMub3JnCmh0dHA6Ly9s
aXN0cy5sbS1zZW5zb3JzLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xtLXNlbnNvcnM

Re: [lm-sensors] hwmon: (f71882fg) Add f81866/f71868 SuperIO support

[Dan Carpenter]

T24gVHVlLCBKdWwgMDcsIDIwMTUgYXQgMDk6MTk6MDNBTSArMDgwMCwgUGV0ZXIgSHVuZyB3cm90
ZToKPiBIaSBEYW4sCj4gCj4gRGFuIENhcnBlbnRlciDmlrwgMjAxNS83LzYg5LiL5Y2IIDExOjM1
IOWvq+mBkzoKPiA+IEJ1dCB0aGlzIGFycmF5IHN0aWxsIG9ubHkgaGFzIDkgZWxlbWVudHMuCj4g
PiAKPiA+ICAgIDI0MjYgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGVycikK
PiA+ICAgIDI0MjcgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnb3Rv
IGV4aXRfdW5yZWdpc3Rlcl9zeXNmczsKPiA+ICAgIDI0MjggICAgICAgICAgICAgICAgICAgICAg
ICAgIH0KPiA+ICAgIDI0MjkgICAgICAgICAgICAgICAgICB9Cj4gCj4gQ291bGQgeW91IHRlbGwg
bWUgd2hhdCBzdGF0aWMgY29kZSBhbmFseXNpcyB0b29scwo+IGRpZCB5b3UgdXNlIHRvIGdlbmVy
YXRlIHRoaXMgcmVwb3J0Pwo+IAo+IEkgaGFkIHRyaWVkIHdpdGggc3BhcnNlIGFuZCB1c2UgbWFr
ZSBDPTIgPGRyaXZlciBkaXI+Cj4gYnV0IEkgZ290IG5vIHdhcm5pbmcuCgpUaGlzIHdhcyBhIFNt
YXRjaCB0aGluZzoKCn4vcGF0aC90by9zbWF0Y2gvc21hdGNoX3NjcmlwdHMva2NoZWNrZXIgZHJp
dmVycy9od21vbi9mNzE4ODJmZy5jCgpyZWdhcmRzLApkYW4gY2FycGVudGVyCgpfX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsbS1zZW5zb3JzIG1haWxpbmcg
bGlzdApsbS1zZW5zb3JzQGxtLXNlbnNvcnMub3JnCmh0dHA6Ly9saXN0cy5sbS1zZW5zb3JzLm9y
Zy9tYWlsbWFuL2xpc3RpbmZvL2xtLXNlbnNvcnM