[uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

[uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

[David Binderman]

Hello there,

[linux-4.2-rc2/arch/um/drivers/net_user.c:258]: (error) va_list 'ap' was opened but not closed by va_end().

Source code is

    va_start(ap, str);
    while ((arg = va_arg(ap, char **)) != NULL) {
        if (*str == '\0')
            return NULL;
        end = strchr(str, ',');
        if (end != str)
            *arg = str;
        if (end == NULL)
            return NULL;
        *end++ = '\0';
        str = end;
    }
    va_end(ap);
    return str;

If va_end needs to be called for successful return, it probably also
needs to be called for NULL return (twice).

Regards

David Binderman

 		 	   		  
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

[Richard Weinberger]

Hi!

Can you please render this into a proper patch and re-send to the mailinglist?

Thanks,
//richard

Am 13.07.2015 um 11:08 schrieb David Binderman:
> Hello there,
> 
> [linux-4.2-rc2/arch/um/drivers/net_user.c:258]: (error) va_list 'ap' was opened but not closed by va_end().
> 
> Source code is
> 
>     va_start(ap, str);
>     while ((arg = va_arg(ap, char **)) != NULL) {
>         if (*str == '\0')
>             return NULL;
>         end = strchr(str, ',');
>         if (end != str)
>             *arg = str;
>         if (end == NULL)
>             return NULL;
>         *end++ = '\0';
>         str = end;
>     }
>     va_end(ap);
>     return str;
> 
> If va_end needs to be called for successful return, it probably also
> needs to be called for NULL return (twice).
> 
> Regards
> 
> David Binderman
> 
>  		 	   		  
> 

------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

[David Binderman]

Hello there Richard,

----------------------------------------
> Can you please render this into a proper patch and re-send to the mailinglist?

I have a 100% failure rate with patches, so doing a proper patch is beyond my skill set. Sorry.


Regards

David Binderman

 		 	   		  
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

[Geert Uytterhoeven]

Hi David,

On Mon, Jul 13, 2015 at 2:52 PM, David Binderman <dcb314@hotmail.com> wrote:
> ----------------------------------------
>> Can you please render this into a proper patch and re-send to the mailinglist?
>
> I have a 100% failure rate with patches, so doing a proper patch is beyond my skill set. Sorry.

In that case we feel obliged to guide you to a proper patch submission.

Please give it a try. We won't bite ;-)

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

[Richard Weinberger]

Am 13.07.2015 um 14:58 schrieb Geert Uytterhoeven:
> Hi David,
> 
> On Mon, Jul 13, 2015 at 2:52 PM, David Binderman <dcb314@hotmail.com> wrote:
>> ----------------------------------------
>>> Can you please render this into a proper patch and re-send to the mailinglist?
>>
>> I have a 100% failure rate with patches, so doing a proper patch is beyond my skill set. Sorry.
> 
> In that case we feel obliged to guide you to a proper patch submission.
> 
> Please give it a try. We won't bite ;-)

+1

Thanks,
//richard

RE: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

[David Binderman]

Hello there Geert,

----------------------------------------
> In that case we feel obliged to guide you to a proper patch submission.
>
> Please give it a try. We won't bite ;-)

Since you've been so nice about it, here is my umpteenth go at a
linux kernel patch.

Signed-off-by: David Binderman <dcb314@hotmail.com>

--- linux-4.2-rc2/arch/um/drivers/net_user.c.sav    2015-07-13 15:41:33.2115
48852 +0100
+++ linux-4.2-rc2/arch/um/drivers/net_user.c    2015-07-13 15:42:50.191786525 +0
100
@@ -254,13 +254,17 @@ char *split_if_spec(char *str, ...)
 
     va_start(ap, str);
     while ((arg = va_arg(ap, char **)) != NULL) {
-        if (*str == '\0')
+        if (*str == '\0') {
+            va_end(ap);
             return NULL;
+        }
         end = strchr(str, ',');
         if (end != str)
             *arg = str;
-        if (end == NULL)
+        if (end == NULL) {
+            va_end(ap);
             return NULL;
+        }
         *end++ = '\0';
         str = end;
     }

 		 	   		  

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

[Jeff Dike]

> Since you've been so nice about it, here is my umpteenth go at a
> linux kernel patch.

Just eyeballing it, that looks right to me.  It just needs your
original bug report above the Signed-off-by.

				Jeff
-- 
Jeff Dike
AddToIt
978-254-0789 (o)
978-394-8986 (c)

RE: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

[David Binderman]

Hello there Jeff,

----------------------------------------
> Just eyeballing it, that looks right to me. It just needs your
> original bug report above the Signed-off-by.

Righto. Second try:

Hello there,

[linux-4.2-rc2/arch/um/drivers/net_user.c:258]: (error) va_list 'ap' was opened but not closed by va_end().

Source code is

    va_start(ap, str);
    while ((arg = va_arg(ap, char **)) != NULL) {
        if (*str == '\0')
            return NULL;
        end = strchr(str, ',');
        if (end != str)
            *arg = str;
        if (end == NULL)
            return NULL;
        *end++ = '\0';
        str = end;
    }
    va_end(ap);
    return str;

If va_end needs to be called for successful return, it probably also
needs to be called for NULL return (twice).

Regards

David Binderman

Signed-off-by: David Binderman <dcb314@hotmail.com>

--- linux-4.2-rc2/arch/um/drivers/net_user.c.sav    2015-07-13 15:41:33.2115
48852 +0100
+++ linux-4.2-rc2/arch/um/drivers/net_user.c    2015-07-13 15:42:50.191786525 +0
100
@@ -254,13 +254,17 @@ char *split_if_spec(char *str, ...)
 
     va_start(ap, str);
     while ((arg = va_arg(ap, char **)) != NULL) {
-        if (*str == '\0')
+        if (*str == '\0') {
+            va_end(ap);
             return NULL;
+        }
         end = strchr(str, ',');
         if (end != str)
             *arg = str;
-        if (end == NULL)
+        if (end == NULL) {
+            va_end(ap);
             return NULL;
+        }
         *end++ = '\0';
         str = end;
     }

 		 	   		  

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

[Geert Uytterhoeven]

Hi David,

On Mon, Jul 13, 2015 at 4:57 PM, David Binderman <dcb314@hotmail.com> wrote:
> Hello there Geert,
>
> ----------------------------------------
>> In that case we feel obliged to guide you to a proper patch submission.
>>
>> Please give it a try. We won't bite ;-)
>
> Since you've been so nice about it, here is my umpteenth go at a
> linux kernel patch.

Thanks for your patch!

As Jeff already commented, you should include a proper patch description.

> Signed-off-by: David Binderman <dcb314@hotmail.com>
>
> --- linux-4.2-rc2/arch/um/drivers/net_user.c.sav    2015-07-13 15:41:33.2115
> 48852 +0100
> +++ linux-4.2-rc2/arch/um/drivers/net_user.c    2015-07-13 15:42:50.191786525 +0
> 100
> @@ -254,13 +254,17 @@ char *split_if_spec(char *str, ...)
>
>      va_start(ap, str);
>      while ((arg = va_arg(ap, char **)) != NULL) {
> -        if (*str == '\0')
> +        if (*str == '\0') {
> +            va_end(ap);
>              return NULL;
> +        }
>          end = strchr(str, ',');
>          if (end != str)
>              *arg = str;
> -        if (end == NULL)
> +        if (end == NULL) {
> +            va_end(ap);
>              return NULL;
> +        }
>          *end++ = '\0';
>          str = end;
>      }

Unfortunately the patch is whitespace-damaged.
Did you paste it in a web-based email client?

Do you use git?
If yes, perhaps you can use git-send-email.

Based on http://www.serversmtp.com/en/smtp-hotmail, I would try to
add the following to .gitconfig:

[sendemail]
        smtpencryption = ssl
        smtpserver = smtp.live.com
        smtpuser = your Hotmail account
        smtppass = your Hotmail password
        smtpserverport = 465

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

[Toralf Förster]

On 07/13/2015 05:26 PM, Geert Uytterhoeven wrote:
>         smtpencryption = ssl
I do have :
smtpencryption = tls


-- 
Toralf, pgp key: 872AE508 0076E94E

------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

[Geert Uytterhoeven]

On Mon, Jul 13, 2015 at 5:40 PM, Toralf Förster <toralf.foerster@gmx.de> wrote:
> On 07/13/2015 05:26 PM, Geert Uytterhoeven wrote:
>>         smtpencryption = ssl
> I do have :
> smtpencryption = tls

For hotmail, port 465?

I use tls, too, for gmail port 587.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

[Toralf Förster]

On 07/13/2015 05:46 PM, Geert Uytterhoeven wrote:
> For hotmail, port 465?
Ick - right, I use GMX, where tls works flawlessly (BTW I didn't specify the port in .gitconfig)

-- 
Toralf, pgp key: 872AE508 0076E94E

RE: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

[David Binderman]

Hello there Geert,

----------------------------------------
> Thanks for your patch!

You are welcome.

> As Jeff already commented, you should include a proper patch description.

How about

[PATCH]: Add missing va_end to split_if_spec

> Unfortunately the patch is whitespace-damaged.
> Did you paste it in a web-based email client?

Yes.

> Do you use git?

No.

BTW, the same problem we are discussing also occurs in the arch/xtensa subsystem.

A chap called Max Filippov <jcmvbkbc@gmail.com> managed to brew up
a suitable patch as soon as I informed him of his bug. Perhaps it would
be cheaper and easier for you to get in touch with him about his patch
and adapt it to your purposes ?

Just an idea.

Regards

David Binderman