* [review-request][PATCH] bitbake: toaster: do not stop data import on bad data
@ 2015-07-14 21:06 Brian Avery
2015-07-15 10:52 ` Michael Wood
2015-07-15 14:13 ` Damian, Alexandru
0 siblings, 2 replies; 6+ messages in thread
From: Brian Avery @ 2015-07-14 21:06 UTC (permalink / raw)
To: toaster
Continue storing layers in the database even if we hit
a bad layer.
[YOCTO #7955]
---
bitbake/lib/toaster/orm/models.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bitbake/lib/toaster/orm/models.py b/bitbake/lib/toaster/orm/models.py
index 4ea75f2..c218198 100644
--- a/bitbake/lib/toaster/orm/models.py
+++ b/bitbake/lib/toaster/orm/models.py
@@ -891,7 +891,7 @@ class LayerIndexLayerSource(LayerSource):
dependlist[lv].append(Layer_Version.objects.get(layer_source = self, layer__up_id = ldi['dependency'], up_branch = lv.up_branch))
except Layer_Version.DoesNotExist as e:
print "Cannot find layer version ", self, ldi['dependency'], lv.up_branch
- raise e
+ pass
for lv in dependlist:
LayerVersionDependency.objects.filter(layer_version = lv).delete()
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [review-request][PATCH] bitbake: toaster: do not stop data import on bad data
2015-07-14 21:06 [review-request][PATCH] bitbake: toaster: do not stop data import on bad data Brian Avery
@ 2015-07-15 10:52 ` Michael Wood
2015-07-15 14:13 ` Damian, Alexandru
1 sibling, 0 replies; 6+ messages in thread
From: Michael Wood @ 2015-07-15 10:52 UTC (permalink / raw)
To: toaster
On 14/07/15 22:06, Brian Avery wrote:
> Continue storing layers in the database even if we hit
> a bad layer.
>
> [YOCTO #7955]
> ---
> bitbake/lib/toaster/orm/models.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bitbake/lib/toaster/orm/models.py b/bitbake/lib/toaster/orm/models.py
> index 4ea75f2..c218198 100644
> --- a/bitbake/lib/toaster/orm/models.py
> +++ b/bitbake/lib/toaster/orm/models.py
> @@ -891,7 +891,7 @@ class LayerIndexLayerSource(LayerSource):
> dependlist[lv].append(Layer_Version.objects.get(layer_source = self, layer__up_id = ldi['dependency'], up_branch = lv.up_branch))
> except Layer_Version.DoesNotExist as e:
> print "Cannot find layer version ", self, ldi['dependency'], lv.up_branch
> - raise e
> + pass
>
> for lv in dependlist:
> LayerVersionDependency.objects.filter(layer_version = lv).delete()
You can also remove the variable "e" to avoid an unused variable warning
here.
(pylint will pick this up
https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Python )
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [review-request][PATCH] bitbake: toaster: do not stop data import on bad data
2015-07-14 21:06 [review-request][PATCH] bitbake: toaster: do not stop data import on bad data Brian Avery
2015-07-15 10:52 ` Michael Wood
@ 2015-07-15 14:13 ` Damian, Alexandru
2015-07-15 16:43 ` Damian, Alexandru
1 sibling, 1 reply; 6+ messages in thread
From: Damian, Alexandru @ 2015-07-15 14:13 UTC (permalink / raw)
To: Brian Avery; +Cc: toaster@yoctoproject.org
[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]
Hello,
I am not sure why submitting a patch when I already had a patch for review,
as bug 7955 status was set to IN PROGRESS REVIEW.
Anyhow, the
pass
is superfluous there, as highlighted by pylint.
Cheers,
Alex
On Tue, Jul 14, 2015 at 10:06 PM, Brian Avery <brian.avery@intel.com> wrote:
> Continue storing layers in the database even if we hit
> a bad layer.
>
> [YOCTO #7955]
> ---
> bitbake/lib/toaster/orm/models.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bitbake/lib/toaster/orm/models.py
> b/bitbake/lib/toaster/orm/models.py
> index 4ea75f2..c218198 100644
> --- a/bitbake/lib/toaster/orm/models.py
> +++ b/bitbake/lib/toaster/orm/models.py
> @@ -891,7 +891,7 @@ class LayerIndexLayerSource(LayerSource):
>
> dependlist[lv].append(Layer_Version.objects.get(layer_source = self,
> layer__up_id = ldi['dependency'], up_branch = lv.up_branch))
> except Layer_Version.DoesNotExist as e:
> print "Cannot find layer version ", self,
> ldi['dependency'], lv.up_branch
> - raise e
> + pass
>
> for lv in dependlist:
> LayerVersionDependency.objects.filter(layer_version =
> lv).delete()
> --
> 1.9.1
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 2663 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [review-request][PATCH] bitbake: toaster: do not stop data import on bad data
2015-07-15 14:13 ` Damian, Alexandru
@ 2015-07-15 16:43 ` Damian, Alexandru
2015-07-15 16:44 ` Damian, Alexandru
0 siblings, 1 reply; 6+ messages in thread
From: Damian, Alexandru @ 2015-07-15 16:43 UTC (permalink / raw)
To: Brian Avery; +Cc: toaster@yoctoproject.org
[-- Attachment #1: Type: text/plain, Size: 1745 bytes --]
This is the patch I was mentioning.
On Wed, Jul 15, 2015 at 3:13 PM, Damian, Alexandru <
alexandru.damian@intel.com> wrote:
> Hello,
>
> I am not sure why submitting a patch when I already had a patch for
> review, as bug 7955 status was set to IN PROGRESS REVIEW.
>
> Anyhow, the
> pass
>
> is superfluous there, as highlighted by pylint.
>
>
> Cheers,
> Alex
>
> On Tue, Jul 14, 2015 at 10:06 PM, Brian Avery <brian.avery@intel.com>
> wrote:
>
>> Continue storing layers in the database even if we hit
>> a bad layer.
>>
>> [YOCTO #7955]
>> ---
>> bitbake/lib/toaster/orm/models.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/bitbake/lib/toaster/orm/models.py
>> b/bitbake/lib/toaster/orm/models.py
>> index 4ea75f2..c218198 100644
>> --- a/bitbake/lib/toaster/orm/models.py
>> +++ b/bitbake/lib/toaster/orm/models.py
>> @@ -891,7 +891,7 @@ class LayerIndexLayerSource(LayerSource):
>>
>> dependlist[lv].append(Layer_Version.objects.get(layer_source = self,
>> layer__up_id = ldi['dependency'], up_branch = lv.up_branch))
>> except Layer_Version.DoesNotExist as e:
>> print "Cannot find layer version ", self,
>> ldi['dependency'], lv.up_branch
>> - raise e
>> + pass
>>
>> for lv in dependlist:
>> LayerVersionDependency.objects.filter(layer_version =
>> lv).delete()
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster
>>
>
>
>
> --
> Alex Damian
> Yocto Project
> SSG / OTC
>
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 3381 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [review-request][PATCH] bitbake: toaster: do not stop data import on bad data
2015-07-15 16:43 ` Damian, Alexandru
@ 2015-07-15 16:44 ` Damian, Alexandru
0 siblings, 0 replies; 6+ messages in thread
From: Damian, Alexandru @ 2015-07-15 16:44 UTC (permalink / raw)
To: Brian Avery; +Cc: toaster@yoctoproject.org
[-- Attachment #1: Type: text/plain, Size: 2233 bytes --]
Actual patch link.
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=adamian/20150707_bugs&id=1b59005b9d09acfa97c42c58a0259e5835c69c53
It is not easily backported in its current format to fido; something like
your patch needs to be there.
On Wed, Jul 15, 2015 at 5:43 PM, Damian, Alexandru <
alexandru.damian@intel.com> wrote:
> This is the patch I was mentioning.
>
>
> On Wed, Jul 15, 2015 at 3:13 PM, Damian, Alexandru <
> alexandru.damian@intel.com> wrote:
>
>> Hello,
>>
>> I am not sure why submitting a patch when I already had a patch for
>> review, as bug 7955 status was set to IN PROGRESS REVIEW.
>>
>> Anyhow, the
>> pass
>>
>> is superfluous there, as highlighted by pylint.
>>
>>
>> Cheers,
>> Alex
>>
>> On Tue, Jul 14, 2015 at 10:06 PM, Brian Avery <brian.avery@intel.com>
>> wrote:
>>
>>> Continue storing layers in the database even if we hit
>>> a bad layer.
>>>
>>> [YOCTO #7955]
>>> ---
>>> bitbake/lib/toaster/orm/models.py | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/bitbake/lib/toaster/orm/models.py
>>> b/bitbake/lib/toaster/orm/models.py
>>> index 4ea75f2..c218198 100644
>>> --- a/bitbake/lib/toaster/orm/models.py
>>> +++ b/bitbake/lib/toaster/orm/models.py
>>> @@ -891,7 +891,7 @@ class LayerIndexLayerSource(LayerSource):
>>>
>>> dependlist[lv].append(Layer_Version.objects.get(layer_source = self,
>>> layer__up_id = ldi['dependency'], up_branch = lv.up_branch))
>>> except Layer_Version.DoesNotExist as e:
>>> print "Cannot find layer version ", self,
>>> ldi['dependency'], lv.up_branch
>>> - raise e
>>> + pass
>>>
>>> for lv in dependlist:
>>> LayerVersionDependency.objects.filter(layer_version =
>>> lv).delete()
>>> --
>>> 1.9.1
>>>
>>> --
>>> _______________________________________________
>>> toaster mailing list
>>> toaster@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/toaster
>>>
>>
>>
>>
>> --
>> Alex Damian
>> Yocto Project
>> SSG / OTC
>>
>
>
>
> --
> Alex Damian
> Yocto Project
> SSG / OTC
>
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 4482 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [review-request][PATCH] bitbake: toaster: do not stop data import on bad data
@ 2015-07-14 21:03 Brian Avery
0 siblings, 0 replies; 6+ messages in thread
From: Brian Avery @ 2015-07-14 21:03 UTC (permalink / raw)
To: toaster
Continue storing layers in the database even if we hit
a bad layer.
[YOCTO #7955]
---
bitbake/lib/toaster/orm/models.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bitbake/lib/toaster/orm/models.py b/bitbake/lib/toaster/orm/models.py
index 4ea75f2..c218198 100644
--- a/bitbake/lib/toaster/orm/models.py
+++ b/bitbake/lib/toaster/orm/models.py
@@ -891,7 +891,7 @@ class LayerIndexLayerSource(LayerSource):
dependlist[lv].append(Layer_Version.objects.get(layer_source = self, layer__up_id = ldi['dependency'], up_branch = lv.up_branch))
except Layer_Version.DoesNotExist as e:
print "Cannot find layer version ", self, ldi['dependency'], lv.up_branch
- raise e
+ pass
for lv in dependlist:
LayerVersionDependency.objects.filter(layer_version = lv).delete()
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-07-15 16:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-14 21:06 [review-request][PATCH] bitbake: toaster: do not stop data import on bad data Brian Avery
2015-07-15 10:52 ` Michael Wood
2015-07-15 14:13 ` Damian, Alexandru
2015-07-15 16:43 ` Damian, Alexandru
2015-07-15 16:44 ` Damian, Alexandru
-- strict thread matches above, loose matches on Subject: below --
2015-07-14 21:03 Brian Avery
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.