All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhengxing <zhengxing@rock-chips.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: alsa-devel@alsa-project.org, heiko@sntech.de,
	Takashi Iwai <tiwai@suse.de>,
	linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
	dianders@chromium.org, linux-rockchip@lists.infradead.org,
	Mark Brown <broonie@kernel.org>,
	dgreid@chromium.org, sonnyrao@chromium.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec
Date: Thu, 16 Jul 2015 19:20:52 +0800	[thread overview]
Message-ID: <55A79394.5090905@rock-chips.com> (raw)
In-Reply-To: <1437033944.27428.11.camel@tiscali.nl>

Hi Paul,
     Thank you for your reply.

On 2015年07月16日 16:05, Paul Bolle wrote:
> On wo, 2015-07-15 at 11:15 +0800, Xing Zheng wrote:
>> +static const struct of_device_id rockchip_max98090_of_match[] = {
>> +	{ .compatible = "rockchip,rockchip-audio-max98090", },
>> +	{},
>> +};
>> +
>> +static struct platform_driver snd_rk_mc_driver = {
>> +	.probe = snd_rk_mc_probe,
>> +	.remove = snd_rk_mc_remove,
>> +	.driver = {
>> +		.name = DRV_NAME,
>> +		.owner = THIS_MODULE,
>> +		.pm =&snd_soc_pm_ops,
>> +		.of_match_table = rockchip_max98090_of_match,
>> +	},
>> +};
>> +
>> +module_platform_driver(snd_rk_mc_driver);
> Nit: empty line here.
Done.
>
>> +MODULE_AUTHOR("jianqun<jay.xu@rock-chips.com>");
>> +MODULE_DESCRIPTION("Rockchip max98090 machine ASoC driver");
>> +MODULE_LICENSE("GPL v2");
>> +MODULE_ALIAS("platform:" DRV_NAME);
> This seems only useful if there's a corresponding struct
> platform_device. Ie, a platform_device with a "rockchip-snd-max98090"
> .name, which will trigger a "MODALIAS=platform:rockchip-snd-max98090"
> uevent when it's created. But I couldn't find where such a
> platform_device is created.
>
> Did I miss something? Or is there another way this alias is useful here?
Yes, I didn't care about this but I think it maybe correct.
>> +MODULE_DEVICE_TABLE(of, rockchip_max98090_of_match);
> The common pattern is to put MODULE_DEVICE_TABLE() directly after the
> table it exports.
Done.
> Likewise for 2/2 (except the empty line nit, that is).
OK, done.

> Thanks,
>
>
> Paul Bolle
>
>
>


_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: zhengxing@rock-chips.com (zhengxing)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec
Date: Thu, 16 Jul 2015 19:20:52 +0800	[thread overview]
Message-ID: <55A79394.5090905@rock-chips.com> (raw)
In-Reply-To: <1437033944.27428.11.camel@tiscali.nl>

Hi Paul,
     Thank you for your reply.

On 2015?07?16? 16:05, Paul Bolle wrote:
> On wo, 2015-07-15 at 11:15 +0800, Xing Zheng wrote:
>> +static const struct of_device_id rockchip_max98090_of_match[] = {
>> +	{ .compatible = "rockchip,rockchip-audio-max98090", },
>> +	{},
>> +};
>> +
>> +static struct platform_driver snd_rk_mc_driver = {
>> +	.probe = snd_rk_mc_probe,
>> +	.remove = snd_rk_mc_remove,
>> +	.driver = {
>> +		.name = DRV_NAME,
>> +		.owner = THIS_MODULE,
>> +		.pm =&snd_soc_pm_ops,
>> +		.of_match_table = rockchip_max98090_of_match,
>> +	},
>> +};
>> +
>> +module_platform_driver(snd_rk_mc_driver);
> Nit: empty line here.
Done.
>
>> +MODULE_AUTHOR("jianqun<jay.xu@rock-chips.com>");
>> +MODULE_DESCRIPTION("Rockchip max98090 machine ASoC driver");
>> +MODULE_LICENSE("GPL v2");
>> +MODULE_ALIAS("platform:" DRV_NAME);
> This seems only useful if there's a corresponding struct
> platform_device. Ie, a platform_device with a "rockchip-snd-max98090"
> .name, which will trigger a "MODALIAS=platform:rockchip-snd-max98090"
> uevent when it's created. But I couldn't find where such a
> platform_device is created.
>
> Did I miss something? Or is there another way this alias is useful here?
Yes, I didn't care about this but I think it maybe correct.
>> +MODULE_DEVICE_TABLE(of, rockchip_max98090_of_match);
> The common pattern is to put MODULE_DEVICE_TABLE() directly after the
> table it exports.
Done.
> Likewise for 2/2 (except the empty line nit, that is).
OK, done.

> Thanks,
>
>
> Paul Bolle
>
>
>

WARNING: multiple messages have this Message-ID (diff)
From: zhengxing <zhengxing@rock-chips.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: dgreid@chromium.org, dianders@chromium.org, heiko@sntech.de,
	sonnyrao@chromium.org, linux-rockchip@lists.infradead.org,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.de>,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec
Date: Thu, 16 Jul 2015 19:20:52 +0800	[thread overview]
Message-ID: <55A79394.5090905@rock-chips.com> (raw)
In-Reply-To: <1437033944.27428.11.camel@tiscali.nl>

Hi Paul,
     Thank you for your reply.

On 2015年07月16日 16:05, Paul Bolle wrote:
> On wo, 2015-07-15 at 11:15 +0800, Xing Zheng wrote:
>> +static const struct of_device_id rockchip_max98090_of_match[] = {
>> +	{ .compatible = "rockchip,rockchip-audio-max98090", },
>> +	{},
>> +};
>> +
>> +static struct platform_driver snd_rk_mc_driver = {
>> +	.probe = snd_rk_mc_probe,
>> +	.remove = snd_rk_mc_remove,
>> +	.driver = {
>> +		.name = DRV_NAME,
>> +		.owner = THIS_MODULE,
>> +		.pm =&snd_soc_pm_ops,
>> +		.of_match_table = rockchip_max98090_of_match,
>> +	},
>> +};
>> +
>> +module_platform_driver(snd_rk_mc_driver);
> Nit: empty line here.
Done.
>
>> +MODULE_AUTHOR("jianqun<jay.xu@rock-chips.com>");
>> +MODULE_DESCRIPTION("Rockchip max98090 machine ASoC driver");
>> +MODULE_LICENSE("GPL v2");
>> +MODULE_ALIAS("platform:" DRV_NAME);
> This seems only useful if there's a corresponding struct
> platform_device. Ie, a platform_device with a "rockchip-snd-max98090"
> .name, which will trigger a "MODALIAS=platform:rockchip-snd-max98090"
> uevent when it's created. But I couldn't find where such a
> platform_device is created.
>
> Did I miss something? Or is there another way this alias is useful here?
Yes, I didn't care about this but I think it maybe correct.
>> +MODULE_DEVICE_TABLE(of, rockchip_max98090_of_match);
> The common pattern is to put MODULE_DEVICE_TABLE() directly after the
> table it exports.
Done.
> Likewise for 2/2 (except the empty line nit, that is).
OK, done.

> Thanks,
>
>
> Paul Bolle
>
>
>



  parent reply	other threads:[~2015-07-16 11:27 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15  3:15 [PATCH 0/2] Add codec machine driver for rockchip platform Xing Zheng
2015-07-15  3:15 ` Xing Zheng
2015-07-15  3:15 ` [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec Xing Zheng
2015-07-15  3:15   ` Xing Zheng
2015-07-16  8:05   ` Paul Bolle
2015-07-16  8:05     ` Paul Bolle
2015-07-16  8:05     ` Paul Bolle
2015-07-16 11:00     ` Mark Brown
2015-07-16 11:00       ` Mark Brown
2015-07-16 11:22       ` zhengxing
2015-07-16 11:22         ` zhengxing
2015-07-16 11:22         ` zhengxing
2015-07-16 11:47       ` Paul Bolle
2015-07-16 11:47         ` Paul Bolle
2015-07-16 12:55         ` Mark Brown
2015-07-16 12:55           ` Mark Brown
2015-07-16 14:15           ` Paul Bolle
2015-07-16 14:15             ` Paul Bolle
2015-07-16 15:05             ` Mark Brown
2015-07-16 15:05               ` Mark Brown
2015-07-16 16:22               ` Paul Bolle
2015-07-16 16:22                 ` Paul Bolle
2015-07-16 19:57                 ` Mark Brown
2015-07-16 19:57                   ` Mark Brown
2015-07-17  2:17             ` zhengxing
2015-07-17  2:17               ` zhengxing
2015-07-17  2:17               ` zhengxing
2015-07-16 11:20     ` zhengxing [this message]
2015-07-16 11:20       ` zhengxing
2015-07-16 11:20       ` zhengxing
2015-07-16 11:49       ` Paul Bolle
2015-07-16 11:49         ` Paul Bolle
2015-07-16 11:59         ` zhengxing
2015-07-16 11:59           ` zhengxing
2015-07-16 14:19           ` Paul Bolle
2015-07-16 14:19             ` Paul Bolle
2015-07-16 15:25             ` Jiang Liu
2015-07-16 15:25               ` Jiang Liu
2015-07-16 16:08               ` Paul Bolle
2015-07-16 16:08                 ` Paul Bolle
2015-07-17 18:04   ` Mark Brown
2015-07-17 18:04     ` Mark Brown
2015-07-18  3:51     ` zhengxing
2015-07-18  3:51       ` zhengxing
2015-07-18  4:15       ` zhengxing
2015-07-18  4:15         ` zhengxing
2015-07-18  4:15         ` zhengxing
2015-07-15  3:15 ` [PATCH 2/2] ASoC: rockchip: Add machine driver for rt5645/rt5650 codec Xing Zheng
2015-07-15  3:15   ` Xing Zheng
2015-07-17 18:11   ` Mark Brown
2015-07-17 18:11     ` Mark Brown
2015-07-18  3:52     ` zhengxing
2015-07-18  3:52       ` zhengxing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A79394.5090905@rock-chips.com \
    --to=zhengxing@rock-chips.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=dgreid@chromium.org \
    --cc=dianders@chromium.org \
    --cc=heiko@sntech.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=pebolle@tiscali.nl \
    --cc=sonnyrao@chromium.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.