All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Juergen Borleis <jbe@pengutronix.de>, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.cz>,
	linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH v3] serial: mxs-auart: keep the AUART unit in reset state when not in use
Date: Thu, 16 Jul 2015 17:36:17 +0200	[thread overview]
Message-ID: <55A7CF71.7050507@i2se.com> (raw)
In-Reply-To: <1437032458-8577-1-git-send-email-jbe@pengutronix.de>

> Whenever the UART device driver gets closed from userland, the driver
> disables the UART unit and then stops its clock to save power.
>
> The bit which disabled the UART unit is described as:
>
>   "UART Enable. If this bit is set to 1, the UART is enabled. Data
>   transmission and reception occurs for the UART signals. When the
>   UART is disabled in the middle of transmission or reception, it
>   completes the current character before stopping."
>
> The important part is the "it completes the current character". Whenever
> a reception is ongoing when the UART gets disabled (including the clock
> off) the statemachine freezes and "remembers" this state on the next
> open() and re-enabling of the unit's clock.
>
> In this case we end up receiving an additional bogus character
> immediately.
>
> The solution in this change is to move the AUART unit into its reset
> state on close() and only release it from its reset state on the next
> open().
>
> Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> ---

Acked-by: Stefan Wahren <stefan.wahren@i2se.com>

Thanks
Stefan

WARNING: multiple messages have this Message-ID (diff)
From: stefan.wahren@i2se.com (Stefan Wahren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] serial: mxs-auart: keep the AUART unit in reset state when not in use
Date: Thu, 16 Jul 2015 17:36:17 +0200	[thread overview]
Message-ID: <55A7CF71.7050507@i2se.com> (raw)
In-Reply-To: <1437032458-8577-1-git-send-email-jbe@pengutronix.de>

> Whenever the UART device driver gets closed from userland, the driver
> disables the UART unit and then stops its clock to save power.
>
> The bit which disabled the UART unit is described as:
>
>   "UART Enable. If this bit is set to 1, the UART is enabled. Data
>   transmission and reception occurs for the UART signals. When the
>   UART is disabled in the middle of transmission or reception, it
>   completes the current character before stopping."
>
> The important part is the "it completes the current character". Whenever
> a reception is ongoing when the UART gets disabled (including the clock
> off) the statemachine freezes and "remembers" this state on the next
> open() and re-enabling of the unit's clock.
>
> In this case we end up receiving an additional bogus character
> immediately.
>
> The solution in this change is to move the AUART unit into its reset
> state on close() and only release it from its reset state on the next
> open().
>
> Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> ---

Acked-by: Stefan Wahren <stefan.wahren@i2se.com>

Thanks
Stefan

  reply	other threads:[~2015-07-16 15:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16  7:40 [PATCH v3] serial: mxs-auart: keep the AUART unit in reset state when not in use Juergen Borleis
2015-07-16  7:40 ` Juergen Borleis
2015-07-16 15:36 ` Stefan Wahren [this message]
2015-07-16 15:36   ` Stefan Wahren
2015-07-17 13:10 ` Peter Hurley
2015-07-17 13:10   ` Peter Hurley
2015-07-17 14:35   ` Philipp Zabel
2015-07-17 14:35     ` Philipp Zabel
2015-07-20  8:04   ` Juergen Borleis
2015-07-20  8:04     ` Juergen Borleis
2015-07-20 13:00     ` Peter Hurley
2015-07-20 13:00       ` Peter Hurley
2015-07-20 13:18       ` Juergen Borleis
2015-07-20 13:18         ` Juergen Borleis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A7CF71.7050507@i2se.com \
    --to=stefan.wahren@i2se.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbe@pengutronix.de \
    --cc=jslaby@suse.cz \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.