All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Hartmut Knaack <knaack.h@gmx.de>, linux-iio@vger.kernel.org
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	Irina Tirdea <irina.tirdea@intel.com>,
	Vlad Dogaru <vlad.dogaru@intel.com>
Subject: Re: [PATCH 2/8] iio:magnetometer:bmc150_magn: sort entry alphabetically
Date: Sun, 19 Jul 2015 11:03:04 +0100	[thread overview]
Message-ID: <55AB75D8.5090408@kernel.org> (raw)
In-Reply-To: <187b63157fb2a62f1d4d4820a5fb4b914298c7a7.1437090791.git.knaack.h@gmx.de>

On 17/07/15 09:52, Hartmut Knaack wrote:
> Sort the entry for bmc105_magn in Kconfig and Makefile to its correct
> position. Also add the minor module information for completeness.
> 
> Fixes: c91746a2361d ("iio: magn: Add support for BMC150 magnetometer")
> 
> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
Technically this isn't a fix so will have to go the slow way.  Obviously it's
dependent on the previous patch, so if I forget about it do poke me!

Jonathan
> ---
>  drivers/iio/magnetometer/Kconfig  | 33 ++++++++++++++++++---------------
>  drivers/iio/magnetometer/Makefile |  3 +--
>  2 files changed, 19 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/iio/magnetometer/Kconfig b/drivers/iio/magnetometer/Kconfig
> index efb9350b0d76..868abada3409 100644
> --- a/drivers/iio/magnetometer/Kconfig
> +++ b/drivers/iio/magnetometer/Kconfig
> @@ -24,6 +24,24 @@ config AK09911
>  	help
>  	  Deprecated: AK09911 is now supported by AK8975 driver.
>  
> +config BMC150_MAGN
> +	tristate "Bosch BMC150 Magnetometer Driver"
> +	depends on I2C
> +	select REGMAP_I2C
> +	select IIO_BUFFER
> +	select IIO_TRIGGERED_BUFFER
> +	help
> +	  Say yes here to build support for the BMC150 magnetometer.
> +
> +	  Currently this only supports the device via an i2c interface.
> +
> +	  This is a combo module with both accelerometer and magnetometer.
> +	  This driver is only implementing magnetometer part, which has
> +	  its own address and register map.
> +
> +	  To compile this driver as a module, choose M here: the module will be
> +	  called bmc150_magn.
> +
>  config MAG3110
>  	tristate "Freescale MAG3110 3-Axis Magnetometer"
>  	depends on I2C
> @@ -87,19 +105,4 @@ config IIO_ST_MAGN_SPI_3AXIS
>  	depends on IIO_ST_MAGN_3AXIS
>  	depends on IIO_ST_SENSORS_SPI
>  
> -config BMC150_MAGN
> -	tristate "Bosch BMC150 Magnetometer Driver"
> -	depends on I2C
> -	select REGMAP_I2C
> -	select IIO_BUFFER
> -	select IIO_TRIGGERED_BUFFER
> -	help
> -	  Say yes here to build support for the BMC150 magnetometer.
> -
> -	  Currently this only supports the device via an i2c interface.
> -
> -	  This is a combo module with both accelerometer and magnetometer.
> -	  This driver is only implementing magnetometer part, which has
> -	  its own address and register map.
> -
>  endmenu
> diff --git a/drivers/iio/magnetometer/Makefile b/drivers/iio/magnetometer/Makefile
> index 33b1d4d54ee7..2c72df458ec2 100644
> --- a/drivers/iio/magnetometer/Makefile
> +++ b/drivers/iio/magnetometer/Makefile
> @@ -4,6 +4,7 @@
>  
>  # When adding new entries keep the list in alphabetical order
>  obj-$(CONFIG_AK8975)	+= ak8975.o
> +obj-$(CONFIG_BMC150_MAGN) += bmc150_magn.o
>  obj-$(CONFIG_MAG3110)	+= mag3110.o
>  obj-$(CONFIG_HID_SENSOR_MAGNETOMETER_3D) += hid-sensor-magn-3d.o
>  obj-$(CONFIG_MMC35240)	+= mmc35240.o
> @@ -14,5 +15,3 @@ st_magn-$(CONFIG_IIO_BUFFER) += st_magn_buffer.o
>  
>  obj-$(CONFIG_IIO_ST_MAGN_I2C_3AXIS) += st_magn_i2c.o
>  obj-$(CONFIG_IIO_ST_MAGN_SPI_3AXIS) += st_magn_spi.o
> -
> -obj-$(CONFIG_BMC150_MAGN) += bmc150_magn.o
> 


  reply	other threads:[~2015-07-19 10:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17  8:52 [PATCH 0/8] bmc150_magn fix and cleanup Hartmut Knaack
2015-07-17  8:52 ` [PATCH 1/8] iio:magnetometer:bmc150_magn: add regmap dependency Hartmut Knaack
2015-07-19 10:02   ` Jonathan Cameron
2015-07-17  8:52 ` [PATCH 2/8] iio:magnetometer:bmc150_magn: sort entry alphabetically Hartmut Knaack
2015-07-19 10:03   ` Jonathan Cameron [this message]
2015-08-12 21:18     ` Jonathan Cameron
2015-07-17  8:52 ` [PATCH 3/8] iio:magnetometer:bmc150_magn: output intended variable Hartmut Knaack
2015-07-19 10:03   ` Jonathan Cameron
2015-07-17  8:52 ` [PATCH 4/8] iio:magnetometer:bmc150_magn: replace magic value Hartmut Knaack
2015-07-19 10:05   ` Jonathan Cameron
2015-07-17  8:52 ` [PATCH 5/8] iio:magnetometer:bmc150_magn: add error handling on gpio probe Hartmut Knaack
2015-07-19 10:06   ` Jonathan Cameron
2015-07-20 17:36   ` Tirdea, Irina
2015-07-20 17:44     ` Jonathan Cameron
2015-07-17  8:52 ` [PATCH 6/8] iio:magnetometer:bmc150_magn: protect runtime_resume with mutex Hartmut Knaack
2015-07-19 10:08   ` Jonathan Cameron
2015-07-20 17:45   ` Tirdea, Irina
2015-07-22 21:28     ` Hartmut Knaack
2015-07-17  8:52 ` [PATCH 7/8] iio:magnetometer:bmc150_magn: expand mutex in trigger_handler Hartmut Knaack
2015-07-20 17:48   ` Tirdea, Irina
2015-08-02 17:04     ` Jonathan Cameron
2015-07-17  8:52 ` [PATCH 8/8] iio:magnetometer:bmc150_magn: use descriptive name for mask Hartmut Knaack
2015-07-20 17:52   ` Tirdea, Irina
2015-08-02 17:05     ` Jonathan Cameron
2015-07-20 17:30 ` [PATCH 0/8] bmc150_magn fix and cleanup Tirdea, Irina
2015-07-20 17:48   ` Jonathan Cameron
2015-07-22 14:50     ` Tirdea, Irina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AB75D8.5090408@kernel.org \
    --to=jic23@kernel.org \
    --cc=irina.tirdea@intel.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=vlad.dogaru@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.