Re: [PATCH 8/8] iio:magnetometer:bmc150_magn: use descriptive name for mask

[Jonathan Cameron <jic23@kernel.org>]

On 20/07/15 18:52, Tirdea, Irina wrote:
> 
> 
>> -----Original Message-----
>> From: Hartmut Knaack [mailto:knaack.h@gmx.de]
>> Sent: 17 July, 2015 11:53
>> To: linux-iio@vger.kernel.org
>> Cc: Jonathan Cameron; Lars-Peter Clausen; Peter Meerwald; Tirdea, Irina; Dogaru, Vlad
>> Subject: [PATCH 8/8] iio:magnetometer:bmc150_magn: use descriptive name for mask
>>
>> Define and use a descriptive name for the repetition registers data mask,
>> instead of a 'magic' value.
>>
> 
> Missed this hardcoded value. Thanks for catching this!
> 
> Acked-by: Irina Tirdea <irina.tirdea@intel.com>
Applied, thanks!

Jonathan
>  
>> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
>> ---
>>  drivers/iio/magnetometer/bmc150_magn.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c
>> index bdcf49ee75df..e8cf08ee2d15 100644
>> --- a/drivers/iio/magnetometer/bmc150_magn.c
>> +++ b/drivers/iio/magnetometer/bmc150_magn.c
>> @@ -85,6 +85,7 @@
>>  #define BMC150_MAGN_REG_HIGH_THRESH		0x50
>>  #define BMC150_MAGN_REG_REP_XY			0x51
>>  #define BMC150_MAGN_REG_REP_Z			0x52
>> +#define BMC150_MAGN_REG_REP_DATAMASK		GENMASK(7, 0)
>>
>>  #define BMC150_MAGN_REG_TRIM_START		0x5D
>>  #define BMC150_MAGN_REG_TRIM_END		0x71
>> @@ -559,7 +560,7 @@ static int bmc150_magn_write_raw(struct iio_dev *indio_dev,
>>  			}
>>  			ret = regmap_update_bits(data->regmap,
>>  						 BMC150_MAGN_REG_REP_XY,
>> -						 0xFF,
>> +						 BMC150_MAGN_REG_REP_DATAMASK,
>>  						 BMC150_MAGN_REPXY_TO_REGVAL
>>  						 (val));
>>  			mutex_unlock(&data->mutex);
>> @@ -575,7 +576,7 @@ static int bmc150_magn_write_raw(struct iio_dev *indio_dev,
>>  			}
>>  			ret = regmap_update_bits(data->regmap,
>>  						 BMC150_MAGN_REG_REP_Z,
>> -						 0xFF,
>> +						 BMC150_MAGN_REG_REP_DATAMASK,
>>  						 BMC150_MAGN_REPZ_TO_REGVAL
>>  						 (val));
>>  			mutex_unlock(&data->mutex);
>> --
>> 2.4.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>