From: Jonathan Cameron <jic23@kernel.org>
To: Hartmut Knaack <knaack.h@gmx.de>, linux-iio@vger.kernel.org
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Irina Tirdea <irina.tirdea@intel.com>,
Vlad Dogaru <vlad.dogaru@intel.com>
Subject: Re: [PATCH 3/8] iio:magnetometer:bmc150_magn: output intended variable
Date: Sun, 19 Jul 2015 11:03:55 +0100 [thread overview]
Message-ID: <55AB760B.5020901@kernel.org> (raw)
In-Reply-To: <8f490c090729953bfdb9c02c9ad36cc873a701d7.1437090791.git.knaack.h@gmx.de>
On 17/07/15 09:52, Hartmut Knaack wrote:
> According to the debug/error string, the content of chip_id is supposed to
> be output, rather than the return value of the previous operation.
>
> Fixes: c91746a2361d ("iio: magn: Add support for BMC150 magnetometer")
>
> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/iio/magnetometer/bmc150_magn.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c
> index cd002710dd02..7da4ce9409e8 100644
> --- a/drivers/iio/magnetometer/bmc150_magn.c
> +++ b/drivers/iio/magnetometer/bmc150_magn.c
> @@ -694,11 +694,11 @@ static int bmc150_magn_init(struct bmc150_magn_data *data)
> goto err_poweroff;
> }
> if (chip_id != BMC150_MAGN_CHIP_ID_VAL) {
> - dev_err(&data->client->dev, "Invalid chip id 0x%x\n", ret);
> + dev_err(&data->client->dev, "Invalid chip id 0x%x\n", chip_id);
> ret = -ENODEV;
> goto err_poweroff;
> }
> - dev_dbg(&data->client->dev, "Chip id %x\n", ret);
> + dev_dbg(&data->client->dev, "Chip id %x\n", chip_id);
>
> preset = bmc150_magn_presets_table[BMC150_MAGN_DEFAULT_PRESET];
> ret = bmc150_magn_set_odr(data, preset.odr);
>
next prev parent reply other threads:[~2015-07-19 10:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 8:52 [PATCH 0/8] bmc150_magn fix and cleanup Hartmut Knaack
2015-07-17 8:52 ` [PATCH 1/8] iio:magnetometer:bmc150_magn: add regmap dependency Hartmut Knaack
2015-07-19 10:02 ` Jonathan Cameron
2015-07-17 8:52 ` [PATCH 2/8] iio:magnetometer:bmc150_magn: sort entry alphabetically Hartmut Knaack
2015-07-19 10:03 ` Jonathan Cameron
2015-08-12 21:18 ` Jonathan Cameron
2015-07-17 8:52 ` [PATCH 3/8] iio:magnetometer:bmc150_magn: output intended variable Hartmut Knaack
2015-07-19 10:03 ` Jonathan Cameron [this message]
2015-07-17 8:52 ` [PATCH 4/8] iio:magnetometer:bmc150_magn: replace magic value Hartmut Knaack
2015-07-19 10:05 ` Jonathan Cameron
2015-07-17 8:52 ` [PATCH 5/8] iio:magnetometer:bmc150_magn: add error handling on gpio probe Hartmut Knaack
2015-07-19 10:06 ` Jonathan Cameron
2015-07-20 17:36 ` Tirdea, Irina
2015-07-20 17:44 ` Jonathan Cameron
2015-07-17 8:52 ` [PATCH 6/8] iio:magnetometer:bmc150_magn: protect runtime_resume with mutex Hartmut Knaack
2015-07-19 10:08 ` Jonathan Cameron
2015-07-20 17:45 ` Tirdea, Irina
2015-07-22 21:28 ` Hartmut Knaack
2015-07-17 8:52 ` [PATCH 7/8] iio:magnetometer:bmc150_magn: expand mutex in trigger_handler Hartmut Knaack
2015-07-20 17:48 ` Tirdea, Irina
2015-08-02 17:04 ` Jonathan Cameron
2015-07-17 8:52 ` [PATCH 8/8] iio:magnetometer:bmc150_magn: use descriptive name for mask Hartmut Knaack
2015-07-20 17:52 ` Tirdea, Irina
2015-08-02 17:05 ` Jonathan Cameron
2015-07-20 17:30 ` [PATCH 0/8] bmc150_magn fix and cleanup Tirdea, Irina
2015-07-20 17:48 ` Jonathan Cameron
2015-07-22 14:50 ` Tirdea, Irina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AB760B.5020901@kernel.org \
--to=jic23@kernel.org \
--cc=irina.tirdea@intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=vlad.dogaru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.