All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Danin <danindrey@mail.ru>
To: Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
	Simon Horman <horms@verge.net.au>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-tegra@vger.kernel.org
Subject: Re: [RFC 0/9] i2c: slave: improve i2c client address spaces and their DT support
Date: Mon, 20 Jul 2015 10:23:04 +0300	[thread overview]
Message-ID: <55ACA1D8.6010403@mail.ru> (raw)
In-Reply-To: <1437142109-31975-1-git-send-email-wsa@the-dreams.de>

Hello Wolfram,

On 17.07.2015 17:08, Wolfram Sang wrote:
> As promised here is my RFC to improve address spaces for I2C. This should give
> i2c seperate address spaces for standard clients, 10 bit clients, and our own
> slave clients. So, you can now have a 7 bit slave at 0x50 and a 10 bit slave at
> 0x050. Or, you can have a slave driver listening at some address and at the
> same time have a client driver talking to this address. Note that this is only
> the core support for that separation, I am still not sure if there is hardware
> being able talking to its own slave address, but we will see.
>
> This RFC and while I did some quick tests, it is not thoroughly tested. But I
> wanted to push it out before I leave the computer for the weekend. It still
> shows what path I chose to solve the problem. So, comments on that and further
> testing are more than welcome!
>
> BTW Andrey, I did not modify your patch and couldn't get the i2c-slave-eeprom driver
> to work with my Jetson TK1. Does this work for you?
>
> Thanks,
>
>     Wolfram
>

Thanks for the patches. Slave mode works for me.

The series looks good. Only hardcoded values in patch 4 confuse me a little.

WARNING: multiple messages have this Message-ID (diff)
From: Andrey Danin <danindrey@mail.ru>
To: Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
	Simon Horman <horms@verge.net.au>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-tegra@vger.kernel.org
Subject: Re: [RFC 0/9] i2c: slave: improve i2c client address spaces and their DT support
Date: Mon, 20 Jul 2015 07:23:04 +0000	[thread overview]
Message-ID: <55ACA1D8.6010403@mail.ru> (raw)
In-Reply-To: <1437142109-31975-1-git-send-email-wsa@the-dreams.de>

Hello Wolfram,

On 17.07.2015 17:08, Wolfram Sang wrote:
> As promised here is my RFC to improve address spaces for I2C. This should give
> i2c seperate address spaces for standard clients, 10 bit clients, and our own
> slave clients. So, you can now have a 7 bit slave at 0x50 and a 10 bit slave at
> 0x050. Or, you can have a slave driver listening at some address and at the
> same time have a client driver talking to this address. Note that this is only
> the core support for that separation, I am still not sure if there is hardware
> being able talking to its own slave address, but we will see.
>
> This RFC and while I did some quick tests, it is not thoroughly tested. But I
> wanted to push it out before I leave the computer for the weekend. It still
> shows what path I chose to solve the problem. So, comments on that and further
> testing are more than welcome!
>
> BTW Andrey, I did not modify your patch and couldn't get the i2c-slave-eeprom driver
> to work with my Jetson TK1. Does this work for you?
>
> Thanks,
>
>     Wolfram
>

Thanks for the patches. Slave mode works for me.

The series looks good. Only hardcoded values in patch 4 confuse me a little.

  parent reply	other threads:[~2015-07-20  7:23 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17 14:08 [RFC 0/9] i2c: slave: improve i2c client address spaces and their DT support Wolfram Sang
2015-07-17 14:08 ` Wolfram Sang
2015-07-17 14:08 ` [RFC 4/9] i2c: apply address offset for slaves, too Wolfram Sang
2015-07-17 14:08   ` Wolfram Sang
2015-07-17 14:08 ` [RFC 5/9] i2c: rename address check functions Wolfram Sang
2015-07-17 14:08   ` Wolfram Sang
2015-07-17 14:08 ` [RFC 7/9] i2c: apply DT flags when probing Wolfram Sang
2015-07-17 14:08   ` Wolfram Sang
2015-07-20  7:23 ` Andrey Danin [this message]
2015-07-20  7:23   ` [RFC 0/9] i2c: slave: improve i2c client address spaces and their DT support Andrey Danin
     [not found]   ` <55ACA1D8.6010403-JGs/UdohzUI@public.gmane.org>
2015-07-20  8:52     ` Wolfram Sang
2015-07-20  8:52       ` Wolfram Sang
2015-07-20  8:59 ` Andrey Danin
2015-07-20  8:59   ` Andrey Danin
     [not found] ` <1437142109-31975-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-07-17 14:08   ` [RFC 1/9] i2c: tegra: implement slave mode Wolfram Sang
2015-07-17 14:08     ` Wolfram Sang
2015-07-17 14:08   ` [RFC 2/9] dt-bindings: add header for generic I2C flags in bindings Wolfram Sang
2015-07-17 14:08     ` Wolfram Sang
2015-07-17 14:08   ` [RFC 3/9] i2c: add a flag to mark clients as slaves Wolfram Sang
2015-07-17 14:08     ` Wolfram Sang
2015-07-17 14:08   ` [RFC 6/9] i2c: make address check indpendent from client struct Wolfram Sang
2015-07-17 14:08     ` Wolfram Sang
2015-07-17 14:08   ` [RFC 8/9] i2c: take address space into account when checking for used addresses Wolfram Sang
2015-07-17 14:08     ` Wolfram Sang
2015-07-17 14:08   ` [RFC 9/9] dts: tegra: WIP: hack dts to test new dt flags for i2c Wolfram Sang
2015-07-17 14:08     ` Wolfram Sang
2015-07-17 14:11     ` Wolfram Sang
2015-07-17 14:11       ` Wolfram Sang
2015-07-20  7:28     ` Andrey Danin
2015-07-20  7:28       ` Andrey Danin
2015-07-20  9:03       ` Wolfram Sang
2015-07-20  9:03         ` Wolfram Sang
     [not found]     ` <1437142109-31975-10-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-07-20  7:53       ` Laurent Pinchart
2015-07-20  7:53         ` Laurent Pinchart
2015-07-20  8:45         ` Wolfram Sang
2015-07-20  8:45           ` Wolfram Sang
2015-07-20 16:10           ` Rob Herring
2015-07-20 16:10             ` Rob Herring
2015-07-20 22:09             ` Stephen Warren
2015-07-20 22:09               ` Stephen Warren
     [not found]               ` <55AD71A6.4030105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-07-21  6:55                 ` Wolfram Sang
2015-07-21  6:55                   ` Wolfram Sang
2015-07-20 22:13   ` [RFC 0/9] i2c: slave: improve i2c client address spaces and their DT support Stephen Warren
2015-07-20 22:13     ` Stephen Warren
     [not found]     ` <55AD7279.5090203-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-07-21  7:00       ` Wolfram Sang
2015-07-21  7:00         ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55ACA1D8.6010403@mail.ru \
    --to=danindrey@mail.ru \
    --cc=geert@linux-m68k.org \
    --cc=horms@verge.net.au \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.