From: Stephen Warren <swarren@wwwdotorg.org>
To: Rob Herring <robherring2@gmail.com>, Wolfram Sang <wsa@the-dreams.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
SH-Linux <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Andrey Danin <danindrey@mail.ru>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [RFC 9/9] dts: tegra: WIP: hack dts to test new dt flags for i2c
Date: Mon, 20 Jul 2015 16:09:42 -0600 [thread overview]
Message-ID: <55AD71A6.4030105@wwwdotorg.org> (raw)
In-Reply-To: <CAL_JsqKAoydzJ5KOKJTByB9kOQ8KrSX99hVYNkm6FnOZ33xN1w@mail.gmail.com>
On 07/20/2015 10:10 AM, Rob Herring wrote:
> On Mon, Jul 20, 2015 at 3:45 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
>>
>>>> +
>>>> + eeprom@42 {
>>>> + compatible = "linux,slave-24c02";
>>>> + //FIXME: Should be I2C_OWN_SLAVE_ADDRESS | 0x42
>>>> + reg = <0xc0000042>;
>>>
>>> The node name doesn't match the reg property anymore. Isn't that considered as
>>> a problem ?
>>
>> Hmm, true. So far, Rob (CCed) was fine with this approach:
>> http://www.spinics.net/lists/linux-tegra/msg22760.html
>>
>> @Rob: If we introduce flag bits in the MSBs of an I2C address, the reg
>> property is different from the node name. Is this a problem?
>
> No, I don't it is a problem.
The rule so far has been that the unit address (the value in the node
name) must match the first value in the reg property. I don't see why
this rule should change. To solve this, just name the node
eeprom@c0000042 (or eeprom@40000042 with the correction pointed out
earlier in the thread).
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Rob Herring <robherring2@gmail.com>, Wolfram Sang <wsa@the-dreams.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
SH-Linux <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Andrey Danin <danindrey@mail.ru>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [RFC 9/9] dts: tegra: WIP: hack dts to test new dt flags for i2c
Date: Mon, 20 Jul 2015 22:09:42 +0000 [thread overview]
Message-ID: <55AD71A6.4030105@wwwdotorg.org> (raw)
In-Reply-To: <CAL_JsqKAoydzJ5KOKJTByB9kOQ8KrSX99hVYNkm6FnOZ33xN1w@mail.gmail.com>
On 07/20/2015 10:10 AM, Rob Herring wrote:
> On Mon, Jul 20, 2015 at 3:45 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
>>
>>>> +
>>>> + eeprom@42 {
>>>> + compatible = "linux,slave-24c02";
>>>> + //FIXME: Should be I2C_OWN_SLAVE_ADDRESS | 0x42
>>>> + reg = <0xc0000042>;
>>>
>>> The node name doesn't match the reg property anymore. Isn't that considered as
>>> a problem ?
>>
>> Hmm, true. So far, Rob (CCed) was fine with this approach:
>> http://www.spinics.net/lists/linux-tegra/msg22760.html
>>
>> @Rob: If we introduce flag bits in the MSBs of an I2C address, the reg
>> property is different from the node name. Is this a problem?
>
> No, I don't it is a problem.
The rule so far has been that the unit address (the value in the node
name) must match the first value in the reg property. I don't see why
this rule should change. To solve this, just name the node
eeprom@c0000042 (or eeprom@40000042 with the correction pointed out
earlier in the thread).
next prev parent reply other threads:[~2015-07-20 22:09 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 14:08 [RFC 0/9] i2c: slave: improve i2c client address spaces and their DT support Wolfram Sang
2015-07-17 14:08 ` Wolfram Sang
2015-07-17 14:08 ` [RFC 4/9] i2c: apply address offset for slaves, too Wolfram Sang
2015-07-17 14:08 ` Wolfram Sang
2015-07-17 14:08 ` [RFC 5/9] i2c: rename address check functions Wolfram Sang
2015-07-17 14:08 ` Wolfram Sang
2015-07-17 14:08 ` [RFC 7/9] i2c: apply DT flags when probing Wolfram Sang
2015-07-17 14:08 ` Wolfram Sang
[not found] ` <1437142109-31975-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-07-17 14:08 ` [RFC 1/9] i2c: tegra: implement slave mode Wolfram Sang
2015-07-17 14:08 ` Wolfram Sang
2015-07-17 14:08 ` [RFC 2/9] dt-bindings: add header for generic I2C flags in bindings Wolfram Sang
2015-07-17 14:08 ` Wolfram Sang
2015-07-17 14:08 ` [RFC 3/9] i2c: add a flag to mark clients as slaves Wolfram Sang
2015-07-17 14:08 ` Wolfram Sang
2015-07-17 14:08 ` [RFC 6/9] i2c: make address check indpendent from client struct Wolfram Sang
2015-07-17 14:08 ` Wolfram Sang
2015-07-17 14:08 ` [RFC 8/9] i2c: take address space into account when checking for used addresses Wolfram Sang
2015-07-17 14:08 ` Wolfram Sang
2015-07-17 14:08 ` [RFC 9/9] dts: tegra: WIP: hack dts to test new dt flags for i2c Wolfram Sang
2015-07-17 14:08 ` Wolfram Sang
2015-07-17 14:11 ` Wolfram Sang
2015-07-17 14:11 ` Wolfram Sang
2015-07-20 7:28 ` Andrey Danin
2015-07-20 7:28 ` Andrey Danin
2015-07-20 9:03 ` Wolfram Sang
2015-07-20 9:03 ` Wolfram Sang
[not found] ` <1437142109-31975-10-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-07-20 7:53 ` Laurent Pinchart
2015-07-20 7:53 ` Laurent Pinchart
2015-07-20 8:45 ` Wolfram Sang
2015-07-20 8:45 ` Wolfram Sang
2015-07-20 16:10 ` Rob Herring
2015-07-20 16:10 ` Rob Herring
2015-07-20 22:09 ` Stephen Warren [this message]
2015-07-20 22:09 ` Stephen Warren
[not found] ` <55AD71A6.4030105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-07-21 6:55 ` Wolfram Sang
2015-07-21 6:55 ` Wolfram Sang
2015-07-20 22:13 ` [RFC 0/9] i2c: slave: improve i2c client address spaces and their DT support Stephen Warren
2015-07-20 22:13 ` Stephen Warren
[not found] ` <55AD7279.5090203-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-07-21 7:00 ` Wolfram Sang
2015-07-21 7:00 ` Wolfram Sang
2015-07-20 7:23 ` Andrey Danin
2015-07-20 7:23 ` Andrey Danin
[not found] ` <55ACA1D8.6010403-JGs/UdohzUI@public.gmane.org>
2015-07-20 8:52 ` Wolfram Sang
2015-07-20 8:52 ` Wolfram Sang
2015-07-20 8:59 ` Andrey Danin
2015-07-20 8:59 ` Andrey Danin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AD71A6.4030105@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=danindrey@mail.ru \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robherring2@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.