All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: <nicolas.ferre@atmel.com>, <broonie@kernel.org>,
	<linux-spi@vger.kernel.org>, <dwmw2@infradead.org>,
	<computersforpeace@gmail.com>, <zajec5@gmail.com>,
	<beanhuo@micron.com>, <juhosg@openwrt.org>, <marex@denx.de>,
	<shijie.huang@intel.com>, <ben@decadent.org.uk>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <robh+dt@kernel.org>,
	<pawel.moll@arm.com>, <mark.rutland@arm.com>,
	<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
	<linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 7/7] mtd: atmel-quadspi: add driver for Atmel QSPI controller
Date: Mon, 20 Jul 2015 10:55:54 +0200	[thread overview]
Message-ID: <55ACB79A.3010101@atmel.com> (raw)
In-Reply-To: <1437123868.24981.7.camel@tiscali.nl>

Hi Paul,

I've removed the ".bus = &plaform_bus_type" for the next series.
Thank you for the explanation and the review :)

Best Regards,

Cyrille

Le 17/07/2015 11:04, Paul Bolle a écrit :
> On do, 2015-07-16 at 17:27 +0200, Cyrille Pitchen wrote:
>> --- /dev/null
>> +++ b/drivers/mtd/spi-nor/atmel-quadspi.c
> 
>> +static struct platform_driver atmel_qspi_driver = {
>> +	.driver		= {
>> +		[...]
>> +		.bus	= &platform_bus_type,
>> +		[...]
>> +};
>> +module_platform_driver(atmel_qspi_driver);
> 
> Nit: on module init this will basically do
>     __platform_driver_register(&atmel_qspi_driver, THIS_MODULE);
> 
> which will again set bus to &platform_bus_type. So you might as well
> drop that line.
> 
> 
> Paul Bolle
> 

WARNING: multiple messages have this Message-ID (diff)
From: cyrille.pitchen@atmel.com (Cyrille Pitchen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] mtd: atmel-quadspi: add driver for Atmel QSPI controller
Date: Mon, 20 Jul 2015 10:55:54 +0200	[thread overview]
Message-ID: <55ACB79A.3010101@atmel.com> (raw)
In-Reply-To: <1437123868.24981.7.camel@tiscali.nl>

Hi Paul,

I've removed the ".bus = &plaform_bus_type" for the next series.
Thank you for the explanation and the review :)

Best Regards,

Cyrille

Le 17/07/2015 11:04, Paul Bolle a ?crit :
> On do, 2015-07-16 at 17:27 +0200, Cyrille Pitchen wrote:
>> --- /dev/null
>> +++ b/drivers/mtd/spi-nor/atmel-quadspi.c
> 
>> +static struct platform_driver atmel_qspi_driver = {
>> +	.driver		= {
>> +		[...]
>> +		.bus	= &platform_bus_type,
>> +		[...]
>> +};
>> +module_platform_driver(atmel_qspi_driver);
> 
> Nit: on module init this will basically do
>     __platform_driver_register(&atmel_qspi_driver, THIS_MODULE);
> 
> which will again set bus to &platform_bus_type. So you might as well
> drop that line.
> 
> 
> Paul Bolle
> 

WARNING: multiple messages have this Message-ID (diff)
From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: nicolas.ferre@atmel.com, broonie@kernel.org,
	linux-spi@vger.kernel.org, dwmw2@infradead.org,
	computersforpeace@gmail.com, zajec5@gmail.com,
	beanhuo@micron.com, juhosg@openwrt.org, marex@denx.de,
	shijie.huang@intel.com, ben@decadent.org.uk,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH 7/7] mtd: atmel-quadspi: add driver for Atmel QSPI controller
Date: Mon, 20 Jul 2015 10:55:54 +0200	[thread overview]
Message-ID: <55ACB79A.3010101@atmel.com> (raw)
In-Reply-To: <1437123868.24981.7.camel@tiscali.nl>

Hi Paul,

I've removed the ".bus = &plaform_bus_type" for the next series.
Thank you for the explanation and the review :)

Best Regards,

Cyrille

Le 17/07/2015 11:04, Paul Bolle a écrit :
> On do, 2015-07-16 at 17:27 +0200, Cyrille Pitchen wrote:
>> --- /dev/null
>> +++ b/drivers/mtd/spi-nor/atmel-quadspi.c
> 
>> +static struct platform_driver atmel_qspi_driver = {
>> +	.driver		= {
>> +		[...]
>> +		.bus	= &platform_bus_type,
>> +		[...]
>> +};
>> +module_platform_driver(atmel_qspi_driver);
> 
> Nit: on module init this will basically do
>     __platform_driver_register(&atmel_qspi_driver, THIS_MODULE);
> 
> which will again set bus to &platform_bus_type. So you might as well
> drop that line.
> 
> 
> Paul Bolle
> 

  reply	other threads:[~2015-07-20  8:55 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 15:27 [PATCH 0/7] add driver for Atmel QSPI controller Cyrille Pitchen
2015-07-16 15:27 ` Cyrille Pitchen
2015-07-16 15:27 ` Cyrille Pitchen
2015-07-16 15:27 ` Cyrille Pitchen
2015-07-16 15:27 ` [PATCH 1/7] Documentation: mtd: add a DT property to set the number of dummy cycles Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-16 15:27 ` [PATCH 2/7] mtd: spi-nor: notify (Q)SPI controller about protocol change Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-16 15:27 ` [PATCH 3/7] mtd: spi-nor: allow to tune the number of dummy cycles Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-16 15:27 ` [PATCH 4/7] Documentation: mtd: add a DT property to set the latency code of Spansion memory Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-16 17:44   ` Marek Vasut
2015-07-16 17:44     ` Marek Vasut
2015-07-16 17:44     ` Marek Vasut
2015-07-20  9:23     ` Cyrille Pitchen
2015-07-20  9:23       ` Cyrille Pitchen
2015-07-20  9:23       ` Cyrille Pitchen
2015-07-20  9:23       ` Cyrille Pitchen
2015-07-20 19:29       ` Marek Vasut
2015-07-20 19:29         ` Marek Vasut
2015-07-20 19:29         ` Marek Vasut
2015-07-16 15:27 ` [PATCH 5/7] mtd: spi-nor: allow the set the latency code on Spansion memories Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-16 15:27 ` [PATCH 6/7] Documentation: atmel-quadspi: add binding file for Atmel QSPI driver Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-17 11:44   ` Sergei Shtylyov
2015-07-17 11:44     ` Sergei Shtylyov
2015-07-17 11:44     ` Sergei Shtylyov
2015-07-20  8:54     ` Cyrille Pitchen
2015-07-20  8:54       ` Cyrille Pitchen
2015-07-20  8:54       ` Cyrille Pitchen
2015-07-20  8:54       ` Cyrille Pitchen
2015-07-16 15:27 ` [PATCH 7/7] mtd: atmel-quadspi: add driver for Atmel QSPI controller Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-16 15:27   ` Cyrille Pitchen
2015-07-17  9:04   ` Paul Bolle
2015-07-17  9:04     ` Paul Bolle
2015-07-17  9:04     ` Paul Bolle
2015-07-20  8:55     ` Cyrille Pitchen [this message]
2015-07-20  8:55       ` Cyrille Pitchen
2015-07-20  8:55       ` Cyrille Pitchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55ACB79A.3010101@atmel.com \
    --to=cyrille.pitchen@atmel.com \
    --cc=beanhuo@micron.com \
    --cc=ben@decadent.org.uk \
    --cc=broonie@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=juhosg@openwrt.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=pawel.moll@arm.com \
    --cc=pebolle@tiscali.nl \
    --cc=robh+dt@kernel.org \
    --cc=shijie.huang@intel.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.